Patch Detail
Show a patch.
GET /api/patches/979/?format=api
{ "id": 979, "url": "https://patchwork.libcamera.org/api/patches/979/?format=api", "web_url": "https://patchwork.libcamera.org/patch/979/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190414013506.10515-11-niklas.soderlund@ragnatech.se>", "date": "2019-04-14T01:35:05", "name": "[libcamera-devel,RFC,10/11] libcamera: pipeline_handler: Add functions to lock a whole pipeline", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c4059c6249667513367dc728ce959ed160cee939", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/979/mbox/", "series": [ { "id": 249, "url": "https://patchwork.libcamera.org/api/series/249/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=249", "date": "2019-04-14T01:34:55", "name": "libcamerea: Add support for exclusive access to cameras between processes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/249/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/979/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/979/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 87D6760DB9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 14 Apr 2019 03:35:20 +0200 (CEST)", "from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 90395d99-5e55-11e9-8e2c-005056917f90;\n\tSun, 14 Apr 2019 03:35:19 +0200 (CEST)" ], "X-Halon-ID": "90395d99-5e55-11e9-8e2c-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 14 Apr 2019 03:35:05 +0200", "Message-Id": "<20190414013506.10515-11-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190414013506.10515-1-niklas.soderlund@ragnatech.se>", "References": "<20190414013506.10515-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC 10/11] libcamera: pipeline_handler: Add\n\tfunctions to lock a whole pipeline", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sun, 14 Apr 2019 01:35:21 -0000" }, "content": "Add lock() and unlock() which backed by the MediaDevice implementation\ncan will lock all media devices claimed by a pipeline handler instance.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/include/pipeline_handler.h | 3 +++\n src/libcamera/pipeline_handler.cpp | 18 ++++++++++++++++++\n 2 files changed, 21 insertions(+)", "diff": "diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\nindex d995a7e56d90f706..0e79b05035cc2abb 100644\n--- a/src/libcamera/include/pipeline_handler.h\n+++ b/src/libcamera/include/pipeline_handler.h\n@@ -56,6 +56,9 @@ public:\n \tstd::shared_ptr<MediaDevice> tryAcquire(DeviceEnumerator *enumerator,\n \t\t\t\t\t\tconst DeviceMatch &dm);\n \n+\tbool lock();\n+\tvoid unlock();\n+\n \tvirtual CameraConfiguration\n \tstreamConfiguration(Camera *camera, const std::vector<StreamUsage> &usages) = 0;\n \tvirtual int configureStreams(Camera *camera, const CameraConfiguration &config) = 0;\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 7f4035c008f95f91..317b680214d91071 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -170,6 +170,24 @@ out:\n \treturn media;\n }\n \n+bool PipelineHandler::lock()\n+{\n+\tfor (std::shared_ptr<MediaDevice> media : mediaDevices_) {\n+\t\tif (!media->lock()) {\n+\t\t\tunlock();\n+\t\t\treturn false;\n+\t\t}\n+\t}\n+\n+\treturn true;\n+}\n+\n+void PipelineHandler::unlock()\n+{\n+\tfor (std::shared_ptr<MediaDevice> media : mediaDevices_)\n+\t\tmedia->unlock();\n+}\n+\n /**\n * \\fn PipelineHandler::streamConfiguration()\n * \\brief Retrieve a group of stream configurations for a specified camera\n", "prefixes": [ "libcamera-devel", "RFC", "10/11" ] }