Patch Detail
Show a patch.
GET /api/patches/9776/?format=api
{ "id": 9776, "url": "https://patchwork.libcamera.org/api/patches/9776/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9776/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200924071922.231063-10-ricardo@ribalda.com>", "date": "2020-09-24T07:19:20", "name": "[libcamera-devel,v2,09/11] Documentation: Move all dependencies into features", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "607d45f4dc67f231b8a11432335c8a967059ceaa", "submitter": { "id": 71, "url": "https://patchwork.libcamera.org/api/people/71/?format=api", "name": "Ricardo Ribalda", "email": "ricardo@ribalda.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9776/mbox/", "series": [ { "id": 1316, "url": "https://patchwork.libcamera.org/api/series/1316/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1316", "date": "2020-09-24T07:19:12", "name": "Fix README.rst", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1316/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9776/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9776/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 08A5CC3B5C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 24 Sep 2020 07:19:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C8B6662FD8;\n\tThu, 24 Sep 2020 09:19:45 +0200 (CEST)", "from mail-wm1-x342.google.com (mail-wm1-x342.google.com\n\t[IPv6:2a00:1450:4864:20::342])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 827BD62FFF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 24 Sep 2020 09:19:43 +0200 (CEST)", "by mail-wm1-x342.google.com with SMTP id e17so2421684wme.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 24 Sep 2020 00:19:43 -0700 (PDT)", "from piling.lan ([80.71.134.83]) by smtp.gmail.com with ESMTPSA id\n\tz9sm2275393wmg.46.2020.09.24.00.19.41\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 24 Sep 2020 00:19:41 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"UNsm5Ww0\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=hgtoPMRRqiFZnbQV2BHKS+1MSojaHGMLHyWc0s81ID4=;\n\tb=UNsm5Ww01KOjMTXecIJHTt1SMnBuXR7QoVer/wpyBgRycyVANsHkzbGmXHHGgBNLwG\n\tyFrqZOhS/nv5cVhZYKRe5/imSTkSx6ae3eLxtMH6HDDd2Es466u7MAGeClU80X+OzKpA\n\tNZ6hTveIotmelBjWODXKKmkbC4fJ/3fB+2d1so4YfFacl/GJ5YnyEvgDrBmC8lVTRfT1\n\ttGrEwZe8iqsel7lxwJHwnAa1rxR3lgTE01pU6rgeaNM7CziRRefMUkhC3mj79zXAWxke\n\t1HNIhiWYRKb7z5AeSp1Qgj/KTlsQ4LyDEAQ/wbHb8E0l41aBM9mAyDZ319g/QErH3g63\n\tg7Zw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=hgtoPMRRqiFZnbQV2BHKS+1MSojaHGMLHyWc0s81ID4=;\n\tb=XD1mZsJsqTPsFYDnPLz1ykJty1X1jryIZgFFeRzwClAGO7f7Usi03FE74A0u1Lb7b8\n\tKTr3yRqroQaCwAActfuVVfJ6OGasoDL5K0XW+wdhKcG2NpYvJRALTAIjAdbpnOFaSQOF\n\tcfmJGJYbvdl1tuDM+NexzeFYqLySD6HuQMLBTMXkRroUC2YRzy0Io0mxrHTpFTI5ekNO\n\toXdqnD8lX+1Dwf6OoH9jX6HTbr6+fOlCVDnxHjr02hv638wiXW1JI2DnAbxeXZRHf4Je\n\t29S4kw/lfMCLzNoFllEYmIt8POpbrO+SUM7H21bNr81/83pWf7C4tow1uEh/KWOxNAFZ\n\tDDTg==", "X-Gm-Message-State": "AOAM531t25EpJxJ9OPNZ/UFx2Cbgxlfe52zL+CNz4fCKjHMSu11wHGaR\n\tpfViTGK+993jYId1CSsmkXaCyMK6XlLdGg==", "X-Google-Smtp-Source": "ABdhPJzRysluMPluwraA3skzVNZNMwlZUIGsjKcNLxqa+4Y96oZFn6t7cpDutcT/59qiQyWz/719Hg==", "X-Received": "by 2002:a1c:39c4:: with SMTP id\n\tg187mr3148376wma.126.1600931982608; \n\tThu, 24 Sep 2020 00:19:42 -0700 (PDT)", "From": "Ricardo Ribalda <ricardo@ribalda.com>", "To": "libcamera-devel@lists.libcamera.org,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Date": "Thu, 24 Sep 2020 09:19:20 +0200", "Message-Id": "<20200924071922.231063-10-ricardo@ribalda.com>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200924071922.231063-1-ricardo@ribalda.com>", "References": "<20200924071922.231063-1-ricardo@ribalda.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 09/11] Documentation: Move all\n\tdependencies into features", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This way if the user enables the documentation and the dependencies are\nmissing the configure fails.\n\nSuggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Ricardo Ribalda <ricardo@ribalda.com>\n---\n Documentation/meson.build | 6 +++---\n meson.build | 4 +---\n meson_options.txt | 2 +-\n 3 files changed, 5 insertions(+), 7 deletions(-)", "diff": "diff --git a/Documentation/meson.build b/Documentation/meson.build\nindex 7b497ae..d3d64f7 100644\n--- a/Documentation/meson.build\n+++ b/Documentation/meson.build\n@@ -7,8 +7,8 @@ doc_install_dir = join_paths(get_option('datadir'), 'doc',\n # Doxygen\n #\n \n-doxygen = find_program('doxygen', required : false)\n-dot = find_program('dot', required : false)\n+doxygen = find_program('doxygen', required : get_option('documentation'))\n+dot = find_program('dot', required : get_option('documentation'))\n \n if doxygen.found() and dot.found()\n cdata = configuration_data()\n@@ -42,7 +42,7 @@ endif\n \n sphinx = find_program('sphinx-build-3', required : false)\n if not sphinx.found()\n- sphinx = find_program('sphinx-build', required : false)\n+ sphinx = find_program('sphinx-build', required : get_option('documentation'))\n endif\n \n if sphinx.found()\ndiff --git a/meson.build b/meson.build\nindex c58d458..992281c 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -108,9 +108,7 @@ subdir('utils')\n # The documentation and test components are optional and can be disabled\n # through configuration values. They are enabled by default.\n \n-if get_option('documentation')\n- subdir('Documentation')\n-endif\n+subdir('Documentation')\n \n if get_option('test')\n subdir('test')\ndiff --git a/meson_options.txt b/meson_options.txt\nindex d2e07ef..7f7b3e5 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -6,7 +6,7 @@ option('android',\n description : 'Compile libcamera with Android Camera3 HAL interface')\n \n option('documentation',\n- type : 'boolean',\n+ type : 'feature',\n description : 'Generate the project documentation')\n \n option('gstreamer',\n", "prefixes": [ "libcamera-devel", "v2", "09/11" ] }