Patch Detail
Show a patch.
GET /api/patches/9750/?format=api
{ "id": 9750, "url": "https://patchwork.libcamera.org/api/patches/9750/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9750/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200923143949.310439-5-kieran.bingham@ideasonboard.com>", "date": "2020-09-23T14:39:49", "name": "[libcamera-devel,v2,4/4] libcamera: ipa: Move key generation to utils", "commit_ref": "4af45819d009bf5a0d2f61e044045c6accbb7142", "pull_url": null, "state": "accepted", "archived": false, "hash": "2c170fbf6fbe257eabbcc98bfe650eda3f244db8", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9750/mbox/", "series": [ { "id": 1312, "url": "https://patchwork.libcamera.org/api/series/1312/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1312", "date": "2020-09-23T14:39:45", "name": "Unify utils locations", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1312/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9750/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9750/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D5F38C3B5B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 23 Sep 2020 14:39:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A1B6360576;\n\tWed, 23 Sep 2020 16:39:59 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1907962FD2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 23 Sep 2020 16:39:55 +0200 (CEST)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A124C1243;\n\tWed, 23 Sep 2020 16:39:54 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"D3ybd8ea\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600871994;\n\tbh=2qopBN6t9zjfnRYk78W8H/eApeiVo7i3/d03ZRJhrcM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=D3ybd8eaDA56JBla9/ywCdVNnuySb8EkPpg0ysau5cT7lg895sOuoWRHJKV+/f88O\n\tpsm087iXkRs10jVLTXCVjBrh7R/GdAjZcntaWTNRJKGfGRjOUIoT8rQ/ZB+ofuvX1O\n\tbQxRs+FP8jhyb5bdKX4p9RyCvYt6Xx318uL8RNFU=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Wed, 23 Sep 2020 15:39:49 +0100", "Message-Id": "<20200923143949.310439-5-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200923143949.310439-1-kieran.bingham@ideasonboard.com>", "References": "<20200923143949.310439-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 4/4] libcamera: ipa: Move key\n\tgeneration to utils", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Move the GPLv2 utilities used for generating public and private keys to\nthe utilities subtree.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\nThe ipa-sign and installation scripts are more complex to move and can\nbe handled separately if this series is deemed worthwhile.\n---\n src/libcamera/meson.build | 1 -\n src/meson.build | 1 -\n {src/ipa => utils}/gen-ipa-priv-key.sh | 0\n {src/libcamera => utils}/gen-ipa-pub-key.py | 0\n utils/meson.build | 4 ++++\n 5 files changed, 4 insertions(+), 2 deletions(-)\n rename {src/ipa => utils}/gen-ipa-priv-key.sh (100%)\n rename {src/libcamera => utils}/gen-ipa-pub-key.py (100%)", "diff": "diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex d63dacd55cc7..18ea3261bc15 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -100,7 +100,6 @@ version_cpp = vcs_tag(command : [gen_version, meson.build_root()],\n libcamera_sources += version_cpp\n \n if ipa_sign_module\n- gen_ipa_pub_key = files('gen-ipa-pub-key.py')\n ipa_pub_key_cpp = custom_target('ipa_pub_key_cpp',\n input : [ ipa_priv_key, 'ipa_pub_key.cpp.in' ],\n output : 'ipa_pub_key.cpp',\ndiff --git a/src/meson.build b/src/meson.build\nindex db155e68e848..b9c7e7599d61 100644\n--- a/src/meson.build\n+++ b/src/meson.build\n@@ -4,7 +4,6 @@ subdir('android')\n \n openssl = find_program('openssl', required : true)\n if openssl.found()\n- gen_ipa_priv_key = files('ipa/gen-ipa-priv-key.sh')\n ipa_priv_key = custom_target('ipa-priv-key',\n output : [ 'ipa-priv-key.pem' ],\n command : [ gen_ipa_priv_key, '@OUTPUT@' ])\ndiff --git a/src/ipa/gen-ipa-priv-key.sh b/utils/gen-ipa-priv-key.sh\nsimilarity index 100%\nrename from src/ipa/gen-ipa-priv-key.sh\nrename to utils/gen-ipa-priv-key.sh\ndiff --git a/src/libcamera/gen-ipa-pub-key.py b/utils/gen-ipa-pub-key.py\nsimilarity index 100%\nrename from src/libcamera/gen-ipa-pub-key.py\nrename to utils/gen-ipa-pub-key.py\ndiff --git a/utils/meson.build b/utils/meson.build\nindex ef5507b1c5ca..456bf7f89f82 100644\n--- a/utils/meson.build\n+++ b/utils/meson.build\n@@ -6,3 +6,7 @@ subdir('ipu3')\n gen_controls = files('gen-controls.py')\n gen_formats = files('gen-formats.py')\n gen_header = files('gen-header.sh')\n+\n+## Module signing\n+gen_ipa_priv_key = files('gen-ipa-priv-key.sh')\n+gen_ipa_pub_key = files('gen-ipa-pub-key.py')\n", "prefixes": [ "libcamera-devel", "v2", "4/4" ] }