Patch Detail
Show a patch.
GET /api/patches/9677/?format=api
{ "id": 9677, "url": "https://patchwork.libcamera.org/api/patches/9677/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9677/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200921031057.3564-3-laurent.pinchart@ideasonboard.com>", "date": "2020-09-21T03:10:55", "name": "[libcamera-devel,2/4] libcamera: camera_manager: Make CameraManager::Private::mutex_ mutable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f08d5d59481903ee07404788963383a4c1dc42d6", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9677/mbox/", "series": [ { "id": 1301, "url": "https://patchwork.libcamera.org/api/series/1301/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1301", "date": "2020-09-21T03:10:53", "name": "libcamera: Implement d-pointer design pattern", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1301/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9677/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9677/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 33490BF01C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 21 Sep 2020 03:11:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3219E62FAE;\n\tMon, 21 Sep 2020 05:11:37 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4AC9362FAC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Sep 2020 05:11:34 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D537027B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Sep 2020 05:11:33 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OV0+Coa/\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600657894;\n\tbh=CJXFFwYMbLRkvxmm3Vzks8qplmPsS31TgHEJ+x2jlPU=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=OV0+Coa/XjEKyBdFvul/zmxGd3hGdFafLKf8MUz34AwY1FtIv3LQDBLH1eopavsHs\n\tWJw8cx78yCBBYbEm8xdkpikl5iwzRnV2Lt+5964nmQHKwy6smh0Kf+jtzLUPcg37g1\n\ti2sQWLH2Qz9xq3nSTu0hnjVE7LK7dZeQF1kO1I3g=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 21 Sep 2020 06:10:55 +0300", "Message-Id": "<20200921031057.3564-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200921031057.3564-1-laurent.pinchart@ideasonboard.com>", "References": "<20200921031057.3564-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 2/4] libcamera: camera_manager: Make\n\tCameraManager::Private::mutex_ mutable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The mutex_ stored in the CameraManager::Private class is used to protect\nmembers that may need to be accessed from const functions. Make it\nmutable to allow this.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/camera_manager.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex 47d56256abd6..780a66a7ac10 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -46,7 +46,7 @@ public:\n \t * - initialized_ and status_ during initialization\n \t * - cameras_ and camerasByDevnum_ after initialization\n \t */\n-\tMutex mutex_;\n+\tmutable Mutex mutex_;\n \tstd::vector<std::shared_ptr<Camera>> cameras_;\n \tstd::map<dev_t, std::weak_ptr<Camera>> camerasByDevnum_;\n \n", "prefixes": [ "libcamera-devel", "2/4" ] }