Patch Detail
Show a patch.
GET /api/patches/9673/?format=api
{ "id": 9673, "url": "https://patchwork.libcamera.org/api/patches/9673/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9673/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200920134409.24688-1-laurent.pinchart@ideasonboard.com>", "date": "2020-09-20T13:44:09", "name": "[libcamera-devel] test: Include specific headers instead of libcamera.h", "commit_ref": "beed258a5a3f6a690c6774d37815527fe60375eb", "pull_url": null, "state": "accepted", "archived": false, "hash": "945b743236dda15bc7a1bbfa140f22f285bc9524", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9673/mbox/", "series": [ { "id": 1299, "url": "https://patchwork.libcamera.org/api/series/1299/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1299", "date": "2020-09-20T13:44:09", "name": "[libcamera-devel] test: Include specific headers instead of libcamera.h", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1299/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9673/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9673/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 830F6BF01C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 20 Sep 2020 13:44:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 50B6C62FAC;\n\tSun, 20 Sep 2020 15:44:46 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 72B2D62E65\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 20 Sep 2020 15:44:44 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0D2434FB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 20 Sep 2020 15:44:44 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rQM3hvhF\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600609484;\n\tbh=pCPyHQNWB6YvkJDv6guRyOz+KJOQTJ+rjCckvj6QQuE=;\n\th=From:To:Subject:Date:From;\n\tb=rQM3hvhFI5+rcvVgMiDW0VpZoCfakZBjYFelUy7wocWev24W//7QFqzBPCjtVEouA\n\t2R9eS3+xYfobrj4VuZ1Qr5c4ukiN3hgCEEe7wCHCiPd4M0HRKNZrAGiOLhUKCtwA66\n\tQHqlsgNb2taTmF/Dq++eolBiO9fZdqOwKtODFPNw=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 20 Sep 2020 16:44:09 +0300", "Message-Id": "<20200920134409.24688-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] test: Include specific headers instead of\n\tlibcamera.h", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Let's only pull required headers, to avoid slowing compilation down.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/camera/buffer_import.cpp | 3 +++\n test/camera/capture.cpp | 4 ++++\n test/camera/statemachine.cpp | 2 ++\n test/libtest/buffer_source.h | 2 +-\n test/libtest/camera_test.h | 5 ++++-\n test/mapped-buffer.cpp | 2 ++\n 6 files changed, 16 insertions(+), 2 deletions(-)", "diff": "diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\nindex d57ffa75edeb..64e96264c90b 100644\n--- a/test/camera/buffer_import.cpp\n+++ b/test/camera/buffer_import.cpp\n@@ -12,6 +12,9 @@\n #include <numeric>\n #include <vector>\n \n+#include <libcamera/event_dispatcher.h>\n+#include <libcamera/timer.h>\n+\n #include \"libcamera/internal/device_enumerator.h\"\n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/v4l2_videodevice.h\"\ndiff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\nindex eb67bf2da71f..51bbd25809ee 100644\n--- a/test/camera/capture.cpp\n+++ b/test/camera/capture.cpp\n@@ -7,6 +7,10 @@\n \n #include <iostream>\n \n+#include <libcamera/event_dispatcher.h>\n+#include <libcamera/framebuffer_allocator.h>\n+#include <libcamera/timer.h>\n+\n #include \"camera_test.h\"\n #include \"test.h\"\n \ndiff --git a/test/camera/statemachine.cpp b/test/camera/statemachine.cpp\nindex 0bda6fe4b0b2..28faeb913f2e 100644\n--- a/test/camera/statemachine.cpp\n+++ b/test/camera/statemachine.cpp\n@@ -7,6 +7,8 @@\n \n #include <iostream>\n \n+#include <libcamera/framebuffer_allocator.h>\n+\n #include \"camera_test.h\"\n #include \"test.h\"\n \ndiff --git a/test/libtest/buffer_source.h b/test/libtest/buffer_source.h\nindex 95a82a8229fa..14b4770e8d8a 100644\n--- a/test/libtest/buffer_source.h\n+++ b/test/libtest/buffer_source.h\n@@ -7,7 +7,7 @@\n #ifndef __LIBCAMERA_BUFFER_SOURCE_TEST_H__\n #define __LIBCAMERA_BUFFER_SOURCE_TEST_H__\n \n-#include <libcamera/libcamera.h>\n+#include <libcamera/stream.h>\n \n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/v4l2_videodevice.h\"\ndiff --git a/test/libtest/camera_test.h b/test/libtest/camera_test.h\nindex 0b6bad05e37c..7939798f886e 100644\n--- a/test/libtest/camera_test.h\n+++ b/test/libtest/camera_test.h\n@@ -7,7 +7,10 @@\n #ifndef __LIBCAMERA_CAMERA_TEST_H__\n #define __LIBCAMERA_CAMERA_TEST_H__\n \n-#include <libcamera/libcamera.h>\n+#include <memory>\n+\n+#include <libcamera/camera.h>\n+#include <libcamera/camera_manager.h>\n \n using namespace libcamera;\n \ndiff --git a/test/mapped-buffer.cpp b/test/mapped-buffer.cpp\nindex 39d624cde6d5..027923375ed9 100644\n--- a/test/mapped-buffer.cpp\n+++ b/test/mapped-buffer.cpp\n@@ -7,6 +7,8 @@\n \n #include <iostream>\n \n+#include <libcamera/framebuffer_allocator.h>\n+\n #include \"libcamera/internal/buffer.h\"\n \n #include \"camera_test.h\"\n", "prefixes": [ "libcamera-devel" ] }