Patch Detail
Show a patch.
GET /api/patches/9623/?format=api
{ "id": 9623, "url": "https://patchwork.libcamera.org/api/patches/9623/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9623/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200915142038.28757-14-paul.elder@ideasonboard.com>", "date": "2020-09-15T14:20:28", "name": "[libcamera-devel,13/23] libcamera: IPAInterface: Remove all functions from IPAInterface", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8d0a7d0f597e245ccf371b5e1d96166347af0b65", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9623/mbox/", "series": [ { "id": 1291, "url": "https://patchwork.libcamera.org/api/series/1291/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1291", "date": "2020-09-15T14:20:16", "name": "IPA isolation implementation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1291/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9623/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9623/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7D35FBF01C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 15 Sep 2020 14:21:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 47EE962E30;\n\tTue, 15 Sep 2020 16:21:24 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2934B603EE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 15 Sep 2020 16:21:23 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 686CF1620;\n\tTue, 15 Sep 2020 16:21:21 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"t/5rP/eI\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600179682;\n\tbh=wzGdd1JnYp6naLTSildYQuu4PfeQ/BwsU5DGLaEbhsI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=t/5rP/eIz02d1jf9jL1rngkVdgVtt6+14174J2iAds+WyhNqUX3/uRgojp6xmXirD\n\tE+lVilxKF5rVZOxOMf9Mft/WormhH1JPYt81Vsz2VhX8DcFJQ3QCQRTUbmLXcVGucD\n\tdt1r/9hjMw/uMwcEHCvFY+BU5LnAL5wqYQhDaCZw=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 15 Sep 2020 23:20:28 +0900", "Message-Id": "<20200915142038.28757-14-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200915142038.28757-1-paul.elder@ideasonboard.com>", "References": "<20200915142038.28757-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 13/23] libcamera: IPAInterface: Remove all\n\tfunctions from IPAInterface", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that all the functions in the IPA interface are defined in the data\ndefinition file and a specialized IPAInterface is generated per pipeline\nhandler, remove all the functions from the case IPAInterface.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n include/libcamera/ipa/ipa_interface.h | 16 ----------------\n 1 file changed, 16 deletions(-)", "diff": "diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\nindex 5016ec25..cbe325ea 100644\n--- a/include/libcamera/ipa/ipa_interface.h\n+++ b/include/libcamera/ipa/ipa_interface.h\n@@ -151,22 +151,6 @@ class IPAInterface\n {\n public:\n \tvirtual ~IPAInterface() {}\n-\n-\tvirtual int init(const IPASettings &settings) = 0;\n-\tvirtual int start() = 0;\n-\tvirtual void stop() = 0;\n-\n-\tvirtual void configure(const CameraSensorInfo &sensorInfo,\n-\t\t\t const std::map<unsigned int, IPAStream> &streamConfig,\n-\t\t\t const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n-\t\t\t const IPAOperationData &ipaConfig,\n-\t\t\t IPAOperationData *result) = 0;\n-\n-\tvirtual void mapBuffers(const std::vector<IPABuffer> &buffers) = 0;\n-\tvirtual void unmapBuffers(const std::vector<unsigned int> &ids) = 0;\n-\n-\tvirtual void processEvent(const IPAOperationData &data) = 0;\n-\tSignal<unsigned int, const IPAOperationData &> queueFrameAction;\n };\n \n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "13/23" ] }