Patch Detail
Show a patch.
GET /api/patches/9593/?format=api
{ "id": 9593, "url": "https://patchwork.libcamera.org/api/patches/9593/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9593/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200914142149.63857-2-niklas.soderlund@ragnatech.se>", "date": "2020-09-14T14:21:37", "name": "[libcamera-devel,v2,01/13] libcamera: pipeline: rkisp1: Set number of planes based on format", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "271b472c8089a7c0ab7c683931dd191b060e3d39", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9593/mbox/", "series": [ { "id": 1289, "url": "https://patchwork.libcamera.org/api/series/1289/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1289", "date": "2020-09-14T14:21:36", "name": "libcamera: pipeline: rkisp1: Extend to support two streams", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1289/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9593/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9593/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 663C0BF01C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 14 Sep 2020 14:22:07 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C88462DFD;\n\tMon, 14 Sep 2020 16:22:06 +0200 (CEST)", "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A344F62C8C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 14 Sep 2020 16:22:05 +0200 (CEST)", "from bismarck.berto.se (p54ac52a8.dip0.t-ipconnect.de\n\t[84.172.82.168]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid a96c795e-f695-11ea-a39b-005056917f90;\n\tMon, 14 Sep 2020 16:22:04 +0200 (CEST)" ], "X-Halon-ID": "a96c795e-f695-11ea-a39b-005056917f90", "Authorized-sender": "niklas.soderlund@fsdn.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 14 Sep 2020 16:21:37 +0200", "Message-Id": "<20200914142149.63857-2-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200914142149.63857-1-niklas.soderlund@ragnatech.se>", "References": "<20200914142149.63857-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 01/13] libcamera: pipeline: rkisp1: Set\n\tnumber of planes based on format", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The RkISP1 pipeline originally only supported NV formats which have 2\nplanes. When support for YUV formats was added the plane count on the\noutput format was not made to reflect this. Instead of hard coding the\nplane count to 2 fetch the number of planes from the format information.\n\nReported-by: Jacopo Mondi <jacopo@jmondi.org>\nFixes: 2b1a908b5222e263 (\"libcamera: camera: Add a validation API to the CameraConfiguration class\")\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex a6fc3b8e36f3b00a..009d190d3ec828f0 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -667,10 +667,11 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \n \tLOG(RkISP1, Debug) << \"Resizer output pad configured with \" << format.toString();\n \n+\tconst PixelFormatInfo &info = PixelFormatInfo::info(cfg.pixelFormat);\n \tV4L2DeviceFormat outputFormat = {};\n \toutputFormat.fourcc = video_->toV4L2PixelFormat(cfg.pixelFormat);\n \toutputFormat.size = cfg.size;\n-\toutputFormat.planesCount = 2;\n+\toutputFormat.planesCount = info.numPlanes();\n \n \tret = video_->setFormat(&outputFormat);\n \tif (ret)\n", "prefixes": [ "libcamera-devel", "v2", "01/13" ] }