Patch Detail
Show a patch.
GET /api/patches/9491/?format=api
{ "id": 9491, "url": "https://patchwork.libcamera.org/api/patches/9491/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9491/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200904103042.1593-2-david.plowman@raspberrypi.com>", "date": "2020-09-04T10:30:35", "name": "[libcamera-devel,v7,1/8] libcamera: pipeline: raspberrypi: Revert \"Set sensor default orientation before configure()\"", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "08438caf827d0447a41a61ceec45ce9ba27cb2e7", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9491/mbox/", "series": [ { "id": 1265, "url": "https://patchwork.libcamera.org/api/series/1265/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1265", "date": "2020-09-04T10:30:34", "name": "2D transforms", "version": 7, "mbox": "https://patchwork.libcamera.org/series/1265/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9491/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9491/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6077EBE174\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 4 Sep 2020 10:30:50 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6B09A62B29;\n\tFri, 4 Sep 2020 12:30:49 +0200 (CEST)", "from mail-wr1-x432.google.com (mail-wr1-x432.google.com\n\t[IPv6:2a00:1450:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E95A60371\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 4 Sep 2020 12:30:48 +0200 (CEST)", "by mail-wr1-x432.google.com with SMTP id c18so6191174wrm.9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 04 Sep 2020 03:30:48 -0700 (PDT)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tq4sm10294542wru.65.2020.09.04.03.30.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 04 Sep 2020 03:30:46 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"YtpSf56c\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=WGbtWdgkXnhzgLWEMiyouzRS4O02UfaVPvUia46yucQ=;\n\tb=YtpSf56c0u5jArBM3jlRVl0hl8kyzr0oZRuNYZOcoIUyrSUkxypt6pyZO6PQYLRN3y\n\tW4fBjCJ7KetLXRuG+6Pdt8xDjoVKSNDeVBmDAmhaEyfnOeYy+1z7gEK16uAemi+f0ZUf\n\tT5ufuXK7TF8+Jf+CGjjhZ+ySX6b7XtQf2H7LEkOuzwORGpe9xiJOJRqkEf4pU4orw3+x\n\tcMqk8dwv7SkvaVgNtwYGQOifIiVbJOCUgjoFAQ3K5y7rKdxrd1sC+94QGxFYiKrSvCyQ\n\t6mpGE35IZcTGryKY0ktsNIRucWiWyaD93vVRom+JAuB0dRBU9lGoMHccJSFruwi2Uxi3\n\tvRsw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=WGbtWdgkXnhzgLWEMiyouzRS4O02UfaVPvUia46yucQ=;\n\tb=UKqGwvPcURIqiuN7FQ0YKKBYRUNUJ68yDD5tq6f12L+IrV1uFNEN9JLBnGvcXpFqqS\n\tzaYkLRyfesZGSQH3Tl/v8bZVFmvRZUXiHA3ns2b0wdm8ELHU3FY14dCxntyG1t2552Rl\n\tbGlKKGnXHgKAWAp9Ix60qioPP6yoIrmO/CoaApgkVWwkfqkBKeataEj70eLxISbYNE/K\n\tP76iZbZw3mew0/j8gD2Gm44uTYUqq2aWhBr+gS5PoQcKeorkw18AqKP364CKzpDmZl13\n\t8CC9R1BJLr/nIOhbamn/nNicxpW0IVMZOp4y9Ujk75Tu/pkYCOCRdQnrOlMfhS9bHo+o\n\tK6nQ==", "X-Gm-Message-State": "AOAM530uQvXQPaD1qfWR4nuTE1kZBDN6+ru/jOo7IuAp2MwGl1YxVBhc\n\tMiEVA9U1i5Lmw8VSgTDwWIQrs28NuORa9w==", "X-Google-Smtp-Source": "ABdhPJznHi5+h3Fzjidm0jyRZ1owLdCXs9KSvhHCSHIygxWpsuPr3TZA3jDM/yboKqHhZPKlOxG7Uw==", "X-Received": "by 2002:adf:9d44:: with SMTP id o4mr6978623wre.361.1599215447393;\n\tFri, 04 Sep 2020 03:30:47 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 4 Sep 2020 11:30:35 +0100", "Message-Id": "<20200904103042.1593-2-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200904103042.1593-1-david.plowman@raspberrypi.com>", "References": "<20200904103042.1593-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v7 1/8] libcamera: pipeline: raspberrypi:\n\tRevert \"Set sensor default orientation before configure()\"", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This reverts commit 1e8c91b65695449c5246d17ba7dc439c8058b781.\n\nNow that we shall be implementing application-defined 2D transforms\nit's no longer possible to set the sensor orientation so early on. We\nhave to wait until we have the CameraConfiguration object as that's\nwhere the application puts its choice of transform.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex ce43af3..f78b73e 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -962,13 +962,6 @@ bool PipelineHandlerRPi::match(DeviceEnumerator *enumerator)\n \t/* Initialize the camera properties. */\n \tdata->properties_ = data->sensor_->properties();\n \n-\t/* Configure the H/V flip controls based on the sensor rotation. */\n-\tControlList ctrls(data->unicam_[Unicam::Image].dev()->controls());\n-\tint32_t rotation = data->properties_.get(properties::Rotation);\n-\tctrls.set(V4L2_CID_HFLIP, static_cast<int32_t>(!!rotation));\n-\tctrls.set(V4L2_CID_VFLIP, static_cast<int32_t>(!!rotation));\n-\tdata->unicam_[Unicam::Image].dev()->setControls(&ctrls);\n-\n \t/*\n \t * List the available output streams.\n \t * Currently cannot do Unicam streams!\n@@ -1173,6 +1166,13 @@ int RPiCameraData::configureIPA()\n \t\t\t\t\t { V4L2_CID_EXPOSURE, result.data[1] } });\n \t\t\tsensorMetadata_ = result.data[2];\n \t\t}\n+\n+\t\t/* Configure the H/V flip controls based on the sensor rotation. */\n+\t\tControlList ctrls(unicam_[Unicam::Image].dev()->controls());\n+\t\tint32_t rotation = sensor_->properties().get(properties::Rotation);\n+\t\tctrls.set(V4L2_CID_HFLIP, static_cast<int32_t>(!!rotation));\n+\t\tctrls.set(V4L2_CID_VFLIP, static_cast<int32_t>(!!rotation));\n+\t\tunicam_[Unicam::Image].dev()->setControls(&ctrls);\n \t}\n \n \tif (result.operation & RPI_IPA_CONFIG_SENSOR) {\n", "prefixes": [ "libcamera-devel", "v7", "1/8" ] }