Patch Detail
Show a patch.
GET /api/patches/9464/?format=api
{ "id": 9464, "url": "https://patchwork.libcamera.org/api/patches/9464/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9464/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200902152236.69770-4-jacopo@jmondi.org>", "date": "2020-09-02T15:22:27", "name": "[libcamera-devel,v2,03/12] android: camera_device: Add debug to stream initialization", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9d478f4e24d0e77cfb0de9151cf1e3ac8ca9239d", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9464/mbox/", "series": [ { "id": 1259, "url": "https://patchwork.libcamera.org/api/series/1259/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1259", "date": "2020-09-02T15:22:24", "name": "android: camera_device: Fix JPEG/RAW sizes", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1259/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9464/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9464/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 273E0BE174\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 2 Sep 2020 15:19:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 00B44629C7;\n\tWed, 2 Sep 2020 17:19:03 +0200 (CEST)", "from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 759DD60374\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 2 Sep 2020 17:19:01 +0200 (CEST)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 1ADF5240012;\n\tWed, 2 Sep 2020 15:18:59 +0000 (UTC)" ], "X-Originating-IP": "93.34.118.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 2 Sep 2020 17:22:27 +0200", "Message-Id": "<20200902152236.69770-4-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200902152236.69770-1-jacopo@jmondi.org>", "References": "<20200902152236.69770-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 03/12] android: camera_device: Add\n\tdebug to stream initialization", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "tfiga@google.com, hiroh@google.com", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add debug printouts to the CameraDevice::initializeStreamConfigurations()\nfunction that helps to follow the process of building the stream\nconfigurations map.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_device.cpp | 26 +++++++++++++++++++++++++-\n 1 file changed, 25 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 8a8072123961..493d6cecde72 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -363,6 +363,9 @@ int CameraDevice::initializeStreamConfigurations()\n \t\tconst std::vector<PixelFormat> &libcameraFormats =\n \t\t\tcamera3Format.libcameraFormats;\n \n+\t\tLOG(HAL, Debug) << \"Testing Android format: \"\n+\t\t\t\t<< camera3Format.name;\n+\n \t\t/*\n \t\t * Fixed format mapping for JPEG.\n \t\t *\n@@ -375,6 +378,10 @@ int CameraDevice::initializeStreamConfigurations()\n \t\t */\n \t\tif (androidFormat == HAL_PIXEL_FORMAT_BLOB) {\n \t\t\tformatsMap_[androidFormat] = formats::MJPEG;\n+\t\t\tLOG(HAL, Debug) << \"Mapped Android format: \"\n+\t\t\t\t\t<< camera3Format.name << \" to: \"\n+\t\t\t\t\t<< formats::MJPEG.toString()\n+\t\t\t\t\t<< \" (fixed mapping)\";\n \t\t\tcontinue;\n \t\t}\n \n@@ -385,6 +392,10 @@ int CameraDevice::initializeStreamConfigurations()\n \t\tPixelFormat mappedFormat;\n \t\tfor (const PixelFormat &pixelFormat : libcameraFormats) {\n \n+\t\t\tLOG(HAL, Debug) << \"Testing Android format: \"\n+\t\t\t\t\t<< camera3Format.name << \" with: \"\n+\t\t\t\t\t<< pixelFormat.toString();\n+\n \t\t\t/*\n \t\t\t * The stream configuration size can be adjusted,\n \t\t\t * not the pixel format.\n@@ -420,14 +431,27 @@ int CameraDevice::initializeStreamConfigurations()\n \t\t * stream configurations map, by testing the image resolutions.\n \t\t */\n \t\tformatsMap_[androidFormat] = mappedFormat;\n+\t\tLOG(HAL, Debug) << \"Mapped Android format: \"\n+\t\t\t\t<< camera3Format.name << \" to: \"\n+\t\t\t\t<< mappedFormat.toString();\n \n \t\tfor (const Size &res : cameraResolutions) {\n \t\t\tcfg.pixelFormat = mappedFormat;\n \t\t\tcfg.size = res;\n \n+\t\t\tstd::stringstream ss;\n+\t\t\tss << \"Testing (\" << res.toString() << \")[\"\n+\t\t\t << mappedFormat.toString() << \"]: \";\n+\n \t\t\tCameraConfiguration::Status status = cameraConfig->validate();\n-\t\t\tif (status != CameraConfiguration::Valid)\n+\t\t\tif (status != CameraConfiguration::Valid) {\n+\t\t\t\tss << \" not supported\";\n+\t\t\t\tLOG(HAL, Debug) << ss.str();\n \t\t\t\tcontinue;\n+\t\t\t}\n+\n+\t\t\tss << \" supported\";\n+\t\t\tLOG(HAL, Debug) << ss.str();\n \n \t\t\tstreamConfigurations_.push_back({ res, androidFormat });\n \n", "prefixes": [ "libcamera-devel", "v2", "03/12" ] }