Patch Detail
Show a patch.
GET /api/patches/9450/?format=api
{ "id": 9450, "url": "https://patchwork.libcamera.org/api/patches/9450/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9450/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200902104410.7569-8-david.plowman@raspberrypi.com>", "date": "2020-09-02T10:44:09", "name": "[libcamera-devel,v6,7/8] libcamera: raspberrypi: Plumb user transform through to IPA", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5334887d752a4982827c85307acc431ddc5f307c", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9450/mbox/", "series": [ { "id": 1256, "url": "https://patchwork.libcamera.org/api/series/1256/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1256", "date": "2020-09-02T10:44:02", "name": "2D transforms", "version": 6, "mbox": "https://patchwork.libcamera.org/series/1256/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9450/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9450/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A81C7BF6D3\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 2 Sep 2020 10:44:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6B2CB629BF;\n\tWed, 2 Sep 2020 12:44:23 +0200 (CEST)", "from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com\n\t[IPv6:2a00:1450:4864:20::42b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DE695629E1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 2 Sep 2020 12:44:21 +0200 (CEST)", "by mail-wr1-x42b.google.com with SMTP id z4so4703502wrr.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 02 Sep 2020 03:44:21 -0700 (PDT)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tm3sm5583062wmb.26.2020.09.02.03.44.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 02 Sep 2020 03:44:20 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"l8wFuPv7\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=jW1QQnzuQ0Fne7ITcP+39LfIm90WZZddE0H4H+DyRQY=;\n\tb=l8wFuPv7Q/lq+BeGBABMIN/Qsrfyj5h+3Ho2UR+CEWuL3r0ALw6UeUz07n8APlaIh5\n\tdepL5opG3AEX9YcwkCIYa030aToFEtp3gf9xD+WnBMBDLxEkEqQ4wLp34fE3T/WP1yo8\n\tS7HcQ+/sjgcXslDcFGwSss3P38FfjBHeH+X5eOvr1YS4QrE6wKngdwi+vOoJXUQzUPHP\n\t+s4H7yCrk0yhIuKZ17VP3PZBXHqi26mCoLjBXUX8K9btX0+aTJzbwIFAjQphq72nFGdW\n\t+6It2U6K4wkHqaIyf2Rk2tx09D4WZG5zafVUMVrPtXWq2KDy3txlGONFUA4qIPAxuvPB\n\trksg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=jW1QQnzuQ0Fne7ITcP+39LfIm90WZZddE0H4H+DyRQY=;\n\tb=dTlzEgLMQoxHgbTk+mX5IolX2UuSKfdLWQzl0iPDED7Dq9vDVa4YZ4JkgNddwO/PGq\n\tXLeG1o7/JKVywbGEtnwM6C06vrK4gUT/mMDz4sKvBbsrLndHccjyCfkzd9NZr41gyhAQ\n\tSsaNP+i/oezdqiPGjqjXxzjSkEqg0sV4kCJgMwb+jWVvVUBgkvXSVdPNkyLSsu3QZifP\n\tKDB+0VrkOQya/yNL2audMcuSJXc82BNnEGqgDR8iZV34If4q5KRoXmg7XHHkSjrDDGWL\n\toXSm+Egric9HSM9oRRQer55vJ3+KEKnknNkDzdRg1o1C2U7bD9EISHeCxjQq3rkicBZx\n\tHPSQ==", "X-Gm-Message-State": "AOAM530klkIVjRavAGSH/DNh+EpZJziSCzSjDMnzTZXaTYwEujOKT1zq\n\tMtuS1lhTL/vCCILhCmCt8NKOUINvddtibQ==", "X-Google-Smtp-Source": "ABdhPJzVZThlK5V5zD6vvYWvthEJVgOdBVXM1u/m3cyVUyj12kcnLpDRLDO/oexP3AO0FSa+ApW5Mg==", "X-Received": "by 2002:adf:f812:: with SMTP id s18mr6778387wrp.96.1599043461287;\n\tWed, 02 Sep 2020 03:44:21 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 2 Sep 2020 11:44:09 +0100", "Message-Id": "<20200902104410.7569-8-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200902104410.7569-1-david.plowman@raspberrypi.com>", "References": "<20200902104410.7569-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v6 7/8] libcamera: raspberrypi: Plumb user\n\ttransform through to IPA", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This commit plumbs the user transform from the Raspberry Pi pipeline\nhandler through to the IPA. Note that the transform is actually\nhandled in the sensor (by setting the h/v flip bits), so the IPAs need\nto understand the orientation of the image they receive.\n\nOnce in the IPA we add it to the CameraMode description, so that it\nbecomes automatically available to all the individual control\nalgorithms.\n\nThe IPA configure method has to be reordered just a little so as to\nfill in the transform in the camera mode before calling SwitchMode.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/raspberrypi/controller/camera_mode.h | 4 ++\n src/ipa/raspberrypi/raspberrypi.cpp | 48 +++++++++++--------\n .../pipeline/raspberrypi/raspberrypi.cpp | 5 +-\n 3 files changed, 35 insertions(+), 22 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/controller/camera_mode.h b/src/ipa/raspberrypi/controller/camera_mode.h\nindex 875bab3..920f11b 100644\n--- a/src/ipa/raspberrypi/controller/camera_mode.h\n+++ b/src/ipa/raspberrypi/controller/camera_mode.h\n@@ -6,6 +6,8 @@\n */\n #pragma once\n \n+#include <libcamera/transform.h>\n+\n // Description of a \"camera mode\", holding enough information for control\n // algorithms to adapt their behaviour to the different modes of the camera,\n // including binning, scaling, cropping etc.\n@@ -33,6 +35,8 @@ struct CameraMode {\n \tdouble noise_factor;\n \t// line time in nanoseconds\n \tdouble line_length;\n+\t// any camera transform *not* reflected already in the camera tuning\n+\tlibcamera::Transform transform;\n };\n \n #ifdef __cplusplus\ndiff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex 4557016..c730326 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -232,6 +232,33 @@ void IPARPi::configure(const CameraSensorInfo &sensorInfo,\n \t/* Re-assemble camera mode using the sensor info. */\n \tsetMode(sensorInfo);\n \n+\t/*\n+\t * The ipaConfig.data always gives us the user transform first. Note that\n+\t * this will always make the LS table pointer (if present) element 1.\n+\t */\n+\tmode_.transform = static_cast<libcamera::Transform>(ipaConfig.data[0]);\n+\n+\t/* Store the lens shading table pointer and handle if available. */\n+\tif (ipaConfig.operation & RPI_IPA_CONFIG_LS_TABLE) {\n+\t\t/* Remove any previous table, if there was one. */\n+\t\tif (lsTable_) {\n+\t\t\tmunmap(lsTable_, MAX_LS_GRID_SIZE);\n+\t\t\tlsTable_ = nullptr;\n+\t\t}\n+\n+\t\t/* Map the LS table buffer into user space (now element 1). */\n+\t\tlsTableHandle_ = FileDescriptor(ipaConfig.data[1]);\n+\t\tif (lsTableHandle_.isValid()) {\n+\t\t\tlsTable_ = mmap(nullptr, MAX_LS_GRID_SIZE, PROT_READ | PROT_WRITE,\n+\t\t\t\t\tMAP_SHARED, lsTableHandle_.fd(), 0);\n+\n+\t\t\tif (lsTable_ == MAP_FAILED) {\n+\t\t\t\tLOG(IPARPI, Error) << \"dmaHeap mmap failure for LS table.\";\n+\t\t\t\tlsTable_ = nullptr;\n+\t\t\t}\n+\t\t}\n+\t}\n+\n \t/* Pass the camera mode to the CamHelper to setup algorithms. */\n \thelper_->SetCameraMode(mode_);\n \n@@ -280,27 +307,6 @@ void IPARPi::configure(const CameraSensorInfo &sensorInfo,\n \t}\n \n \tlastMode_ = mode_;\n-\n-\t/* Store the lens shading table pointer and handle if available. */\n-\tif (ipaConfig.operation & RPI_IPA_CONFIG_LS_TABLE) {\n-\t\t/* Remove any previous table, if there was one. */\n-\t\tif (lsTable_) {\n-\t\t\tmunmap(lsTable_, MAX_LS_GRID_SIZE);\n-\t\t\tlsTable_ = nullptr;\n-\t\t}\n-\n-\t\t/* Map the LS table buffer into user space. */\n-\t\tlsTableHandle_ = FileDescriptor(ipaConfig.data[0]);\n-\t\tif (lsTableHandle_.isValid()) {\n-\t\t\tlsTable_ = mmap(nullptr, MAX_LS_GRID_SIZE, PROT_READ | PROT_WRITE,\n-\t\t\t\t\tMAP_SHARED, lsTableHandle_.fd(), 0);\n-\n-\t\t\tif (lsTable_ == MAP_FAILED) {\n-\t\t\t\tLOG(IPARPI, Error) << \"dmaHeap mmap failure for LS table.\";\n-\t\t\t\tlsTable_ = nullptr;\n-\t\t\t}\n-\t\t}\n-\t}\n }\n \n void IPARPi::mapBuffers(const std::vector<IPABuffer> &buffers)\ndiff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 29112da..728973a 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -1252,6 +1252,9 @@ int RPiCameraData::configureIPA()\n \tentityControls.emplace(0, unicam_[Unicam::Image].dev()->controls());\n \tentityControls.emplace(1, isp_[Isp::Input].dev()->controls());\n \n+\t/* Always send the user transform to the IPA. */\n+\tipaConfig.data = { static_cast<unsigned int>(userTransform_) };\n+\n \t/* Allocate the lens shading table via dmaHeap and pass to the IPA. */\n \tif (!lsTable_.isValid()) {\n \t\tlsTable_ = dmaHeap_.alloc(\"ls_grid\", MAX_LS_GRID_SIZE);\n@@ -1260,7 +1263,7 @@ int RPiCameraData::configureIPA()\n \n \t\t/* Allow the IPA to mmap the LS table via the file descriptor. */\n \t\tipaConfig.operation = RPI_IPA_CONFIG_LS_TABLE;\n-\t\tipaConfig.data = { static_cast<unsigned int>(lsTable_.fd()) };\n+\t\tipaConfig.data.push_back(static_cast<unsigned int>(lsTable_.fd()));\n \t}\n \n \tCameraSensorInfo sensorInfo = {};\n", "prefixes": [ "libcamera-devel", "v6", "7/8" ] }