Patch Detail
Show a patch.
GET /api/patches/944/?format=api
{ "id": 944, "url": "https://patchwork.libcamera.org/api/patches/944/?format=api", "web_url": "https://patchwork.libcamera.org/patch/944/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190408134817.15247-5-niklas.soderlund@ragnatech.se>", "date": "2019-04-08T13:48:13", "name": "[libcamera-devel,v4,4/8] libcamera: Make geometry.h a public header", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "84990748c82b6c06c46f2b96ddc640dbfdd93885", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/944/mbox/", "series": [ { "id": 245, "url": "https://patchwork.libcamera.org/api/series/245/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=245", "date": "2019-04-08T13:48:09", "name": "libcamera: stream: Add basic stream usages", "version": 4, "mbox": "https://patchwork.libcamera.org/series/245/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/944/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/944/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4728C60004\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 8 Apr 2019 15:49:17 +0200 (CEST)", "from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 0fdf0ff1-5a05-11e9-846a-005056917a89;\n\tMon, 08 Apr 2019 15:49:11 +0200 (CEST)" ], "X-Halon-ID": "0fdf0ff1-5a05-11e9-846a-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 8 Apr 2019 15:48:13 +0200", "Message-Id": "<20190408134817.15247-5-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190408134817.15247-1-niklas.soderlund@ragnatech.se>", "References": "<20190408134817.15247-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 4/8] libcamera: Make geometry.h a\n\tpublic header", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 08 Apr 2019 13:49:17 -0000" }, "content": "Make the geometry header public so it can be used by the API facing\napplications.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n {src/libcamera/include => include/libcamera}/geometry.h | 0\n include/libcamera/meson.build | 1 +\n src/libcamera/geometry.cpp | 2 +-\n src/libcamera/include/formats.h | 2 +-\n src/libcamera/include/v4l2_subdevice.h | 3 ++-\n src/libcamera/v4l2_subdevice.cpp | 3 ++-\n test/v4l2_subdevice/list_formats.cpp | 3 ++-\n 7 files changed, 9 insertions(+), 5 deletions(-)\n rename {src/libcamera/include => include/libcamera}/geometry.h (100%)", "diff": "diff --git a/src/libcamera/include/geometry.h b/include/libcamera/geometry.h\nsimilarity index 100%\nrename from src/libcamera/include/geometry.h\nrename to include/libcamera/geometry.h\ndiff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\nindex 3f4d1e28208b1084..83d226ac5078bfc7 100644\n--- a/include/libcamera/meson.build\n+++ b/include/libcamera/meson.build\n@@ -4,6 +4,7 @@ libcamera_api = files([\n 'camera_manager.h',\n 'event_dispatcher.h',\n 'event_notifier.h',\n+ 'geometry.h',\n 'libcamera.h',\n 'object.h',\n 'request.h',\ndiff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\nindex d0c63c353ab3fc0b..d63eceaf827b99a4 100644\n--- a/src/libcamera/geometry.cpp\n+++ b/src/libcamera/geometry.cpp\n@@ -7,7 +7,7 @@\n \n #include <sstream>\n \n-#include \"geometry.h\"\n+#include <libcamera/geometry.h>\n \n /**\n * \\file geometry.h\ndiff --git a/src/libcamera/include/formats.h b/src/libcamera/include/formats.h\nindex 5fcfb11318e749d1..a73772b1eda068b4 100644\n--- a/src/libcamera/include/formats.h\n+++ b/src/libcamera/include/formats.h\n@@ -11,7 +11,7 @@\n #include <map>\n #include <vector>\n \n-#include \"geometry.h\"\n+#include <libcamera/geometry.h>\n \n namespace libcamera {\n \ndiff --git a/src/libcamera/include/v4l2_subdevice.h b/src/libcamera/include/v4l2_subdevice.h\nindex ee7c72468d21b83b..c71dce7d864494e5 100644\n--- a/src/libcamera/include/v4l2_subdevice.h\n+++ b/src/libcamera/include/v4l2_subdevice.h\n@@ -11,8 +11,9 @@\n #include <string>\n #include <vector>\n \n+#include <libcamera/geometry.h>\n+\n #include \"formats.h\"\n-#include \"geometry.h\"\n #include \"log.h\"\n #include \"media_object.h\"\n \ndiff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex 0abeaa204eda465b..e34cc1693b46b374 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -14,7 +14,8 @@\n \n #include <linux/v4l2-subdev.h>\n \n-#include \"geometry.h\"\n+#include <libcamera/geometry.h>\n+\n #include \"log.h\"\n #include \"media_device.h\"\n #include \"media_object.h\"\ndiff --git a/test/v4l2_subdevice/list_formats.cpp b/test/v4l2_subdevice/list_formats.cpp\nindex db486554b7b5c6a9..47ae3a1c1a28c350 100644\n--- a/test/v4l2_subdevice/list_formats.cpp\n+++ b/test/v4l2_subdevice/list_formats.cpp\n@@ -9,7 +9,8 @@\n #include <iostream>\n #include <vector>\n \n-#include \"geometry.h\"\n+#include <libcamera/geometry.h>\n+\n #include \"v4l2_subdevice.h\"\n #include \"v4l2_subdevice_test.h\"\n \n", "prefixes": [ "libcamera-devel", "v4", "4/8" ] }