Patch Detail
Show a patch.
GET /api/patches/938/?format=api
{ "id": 938, "url": "https://patchwork.libcamera.org/api/patches/938/?format=api", "web_url": "https://patchwork.libcamera.org/patch/938/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190405235929.27987-6-niklas.soderlund@ragnatech.se>", "date": "2019-04-05T23:59:29", "name": "[libcamera-devel,v3,5/5] cam: Allow cameras with more than one stream", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0aa16e0bd5013d402949b1ad4569fcc35095a833", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/938/mbox/", "series": [ { "id": 243, "url": "https://patchwork.libcamera.org/api/series/243/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=243", "date": "2019-04-05T23:59:24", "name": "cam: Add support to specify multiple stream configurations with roles", "version": 3, "mbox": "https://patchwork.libcamera.org/series/243/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/938/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/938/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C22A4611A9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 6 Apr 2019 01:59:39 +0200 (CEST)", "from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid de4f6167-57fe-11e9-8144-0050569116f7;\n\tSat, 06 Apr 2019 01:59:37 +0200 (CEST)" ], "X-Halon-ID": "de4f6167-57fe-11e9-8144-0050569116f7", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 6 Apr 2019 01:59:29 +0200", "Message-Id": "<20190405235929.27987-6-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190405235929.27987-1-niklas.soderlund@ragnatech.se>", "References": "<20190405235929.27987-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 5/5] cam: Allow cameras with more than\n\tone stream", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 05 Apr 2019 23:59:40 -0000" }, "content": "The libcamera API and the cam tool are now ready to make use of cameras\nwith more than one stream. Remove the limitation in the tool which\ndisallows cameras that provide more than one stream.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/cam/main.cpp | 8 --------\n 1 file changed, 8 deletions(-)", "diff": "diff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex da5ca3402ce1a823..86f8069cda6a04de 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -315,14 +315,6 @@ int main(int argc, char **argv)\n \t\t\tgoto out;\n \t\t}\n \n-\t\tconst std::set<Stream *> &streams = camera->streams();\n-\t\tif (streams.size() != 1) {\n-\t\t\tstd::cout << \"Camera has \" << streams.size()\n-\t\t\t\t << \" streams, only 1 is supported\"\n-\t\t\t\t << std::endl;\n-\t\t\tgoto out;\n-\t\t}\n-\n \t\tif (camera->acquire()) {\n \t\t\tstd::cout << \"Failed to acquire camera\" << std::endl;\n \t\t\tgoto out;\n", "prefixes": [ "libcamera-devel", "v3", "5/5" ] }