Patch Detail
Show a patch.
GET /api/patches/9370/?format=api
{ "id": 9370, "url": "https://patchwork.libcamera.org/api/patches/9370/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9370/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200822200037.20892-5-laurent.pinchart@ideasonboard.com>", "date": "2020-08-22T20:00:36", "name": "[libcamera-devel,4/5] meson: Remove -Wno-unused-parameter", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "16a56c4676e5305b2a59a665dd6e5c4ab744461a", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9370/mbox/", "series": [ { "id": 1235, "url": "https://patchwork.libcamera.org/api/series/1235/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1235", "date": "2020-08-22T20:00:32", "name": "libcamera: Switch to C++17", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1235/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9370/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9370/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9E495BE175\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 22 Aug 2020 20:01:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E30262724;\n\tSat, 22 Aug 2020 22:01:05 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D3DA62724\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 22 Aug 2020 22:01:02 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AE2EC4FB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 22 Aug 2020 22:01:01 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ThdBVlom\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1598126461;\n\tbh=ZNVp50yEDPM/6qYwMLCqey2f+8vNzBuBLw0TL0fQwMY=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=ThdBVlomImwtQ1vordRpXYYE59CPpy0kW5ih3DENHAVE9Ip65Z3Y+LIiTD47Lv2E3\n\tralrZiQbIigjN+tfE6IVhHVukajWrXk+0ZfnfO84xUrMcREZf+NCE1ms1j7NAp8X8u\n\tl1WnrI4TvghoujwYZ6YdURLON5+kc5fwdMLM3oQw=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 22 Aug 2020 23:00:36 +0300", "Message-Id": "<20200822200037.20892-5-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200822200037.20892-1-laurent.pinchart@ideasonboard.com>", "References": "<20200822200037.20892-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 4/5] meson: Remove -Wno-unused-parameter", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We build libcamera with -Wno-unused-parameter and this doesn't cause\nmuch issue internally. However, it prevents catching unused parameters\nin inline functions defined in public headers. This can lead to\ncompilation warnings for applications compiled without\n-Wno-unused-parameter.\n\nTo catch those issues, remove -Wno-unused-parameter and fix all the\nrelated warnings.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/bound_method.h | 2 +-\n include/libcamera/signal.h | 2 +-\n include/libcamera/span.h | 4 ++--\n meson.build | 1 -\n src/android/camera3_hal.cpp | 11 +++++----\n src/android/camera_device.cpp | 5 ++--\n src/android/camera_ops.cpp | 5 ++--\n src/cam/main.cpp | 2 +-\n src/gstreamer/gstlibcamerapool.cpp | 2 +-\n src/gstreamer/gstlibcameraprovider.cpp | 2 +-\n src/gstreamer/gstlibcamerasrc.cpp | 7 ++++--\n src/ipa/raspberrypi/controller/rpi/agc.cpp | 3 ++-\n src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n src/ipa/rkisp1/rkisp1.cpp | 13 +++++++----\n src/ipa/vimc/vimc.cpp | 16 ++++++-------\n src/libcamera/device_enumerator_udev.cpp | 2 +-\n src/libcamera/ipc_unixsocket.cpp | 2 +-\n .../pipeline/raspberrypi/raspberrypi.cpp | 5 ++--\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n src/libcamera/pipeline/rkisp1/timeline.cpp | 2 +-\n src/libcamera/process.cpp | 2 +-\n src/libcamera/proxy/ipa_proxy_linux.cpp | 23 +++++++++++--------\n src/libcamera/v4l2_pixelformat.cpp | 2 +-\n src/libcamera/v4l2_videodevice.cpp | 4 ++--\n src/qcam/dng_writer.cpp | 5 ++--\n src/qcam/main.cpp | 2 +-\n src/v4l2/v4l2_camera.cpp | 2 +-\n test/camera/buffer_import.cpp | 3 ++-\n test/camera/capture.cpp | 3 ++-\n test/hotplug-cameras.cpp | 4 ++--\n test/ipa/ipa_wrappers_test.cpp | 4 ++--\n test/libtest/test.h | 2 +-\n test/log/log_process.cpp | 3 ++-\n test/object-invoke.cpp | 2 +-\n test/process/process_test.cpp | 3 ++-\n test/timer-thread.cpp | 2 +-\n test/timer.cpp | 2 +-\n 37 files changed, 89 insertions(+), 69 deletions(-)", "diff": "diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h\nindex 983bb5cbbad0..d1e4448304a9 100644\n--- a/include/libcamera/bound_method.h\n+++ b/include/libcamera/bound_method.h\n@@ -214,7 +214,7 @@ public:\n \n \tbool match(R (*func)(Args...)) const { return func == func_; }\n \n-\tR activate(Args... args, bool deleteMethod = false) override\n+\tR activate(Args... args, [[maybe_unused]] bool deleteMethod = false) override\n \t{\n \t\treturn (*func_)(args...);\n \t}\ndiff --git a/include/libcamera/signal.h b/include/libcamera/signal.h\nindex ed30eb559127..accb797e911c 100644\n--- a/include/libcamera/signal.h\n+++ b/include/libcamera/signal.h\n@@ -70,7 +70,7 @@ public:\n \n \tvoid disconnect()\n \t{\n-\t\tSignalBase::disconnect([](SlotList::iterator &iter) {\n+\t\tSignalBase::disconnect([]([[maybe_unused]] SlotList::iterator &iter) {\n \t\t\treturn true;\n \t\t});\n \t}\ndiff --git a/include/libcamera/span.h b/include/libcamera/span.h\nindex 513ddb432405..738af6aca871 100644\n--- a/include/libcamera/span.h\n+++ b/include/libcamera/span.h\n@@ -113,12 +113,12 @@ public:\n \t{\n \t}\n \n-\tconstexpr Span(pointer ptr, size_type count)\n+\tconstexpr Span(pointer ptr, [[maybe_unused]] size_type count)\n \t\t: data_(ptr)\n \t{\n \t}\n \n-\tconstexpr Span(pointer first, pointer last)\n+\tconstexpr Span(pointer first, [[maybe_unused]] pointer last)\n \t\t: data_(first)\n \t{\n \t}\ndiff --git a/meson.build b/meson.build\nindex ce1d1c63ddc6..d7e8122ccaa3 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -37,7 +37,6 @@ if cc.has_header_symbol('stdlib.h', 'secure_getenv', prefix : '#define _GNU_SOUR\n endif\n \n common_arguments = [\n- '-Wno-unused-parameter',\n '-include', 'config.h',\n ]\n \ndiff --git a/src/android/camera3_hal.cpp b/src/android/camera3_hal.cpp\nindex decaf59e6915..ddcfea591ce6 100644\n--- a/src/android/camera3_hal.cpp\n+++ b/src/android/camera3_hal.cpp\n@@ -32,18 +32,21 @@ static int hal_get_camera_info(int id, struct camera_info *info)\n \treturn cameraManager.getCameraInfo(id, info);\n }\n \n-static int hal_set_callbacks(const camera_module_callbacks_t *callbacks)\n+static int hal_set_callbacks([[maybe_unused]] const camera_module_callbacks_t *callbacks)\n {\n \treturn 0;\n }\n \n-static int hal_open_legacy(const struct hw_module_t *module, const char *id,\n-\t\t\t uint32_t halVersion, struct hw_device_t **device)\n+static int hal_open_legacy([[maybe_unused]] const struct hw_module_t *module,\n+\t\t\t [[maybe_unused]] const char *id,\n+\t\t\t [[maybe_unused]] uint32_t halVersion,\n+\t\t\t [[maybe_unused]] struct hw_device_t **device)\n {\n \treturn -ENOSYS;\n }\n \n-static int hal_set_torch_mode(const char *camera_id, bool enabled)\n+static int hal_set_torch_mode([[maybe_unused]] const char *camera_id,\n+\t\t\t [[maybe_unused]] bool enabled)\n {\n \treturn -ENOSYS;\n }\ndiff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 3419236a061c..8a39bee690a0 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1541,8 +1541,9 @@ void CameraDevice::notifyError(uint32_t frameNumber, camera3_stream_t *stream)\n /*\n * Produce a set of fixed result metadata.\n */\n-std::unique_ptr<CameraMetadata> CameraDevice::getResultMetadata(int frame_number,\n-\t\t\t\t\t\t\t\tint64_t timestamp)\n+std::unique_ptr<CameraMetadata>\n+CameraDevice::getResultMetadata([[maybe_unused]] int frame_number,\n+\t\t\t\tint64_t timestamp)\n {\n \t/*\n \t * \\todo Keep this in sync with the actual number of entries.\ndiff --git a/src/android/camera_ops.cpp b/src/android/camera_ops.cpp\nindex 216ac285f964..696e80436821 100644\n--- a/src/android/camera_ops.cpp\n+++ b/src/android/camera_ops.cpp\n@@ -61,11 +61,12 @@ static int hal_dev_process_capture_request(const struct camera3_device *dev,\n \treturn camera->processCaptureRequest(request);\n }\n \n-static void hal_dev_dump(const struct camera3_device *dev, int fd)\n+static void hal_dev_dump([[maybe_unused]] const struct camera3_device *dev,\n+\t\t\t [[maybe_unused]] int fd)\n {\n }\n \n-static int hal_dev_flush(const struct camera3_device *dev)\n+static int hal_dev_flush([[maybe_unused]] const struct camera3_device *dev)\n {\n \treturn 0;\n }\ndiff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex cc3facd5a5b2..244720b491f5 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -378,7 +378,7 @@ int CamApp::run()\n \treturn 0;\n }\n \n-void signalHandler(int signal)\n+void signalHandler([[maybe_unused]] int signal)\n {\n \tstd::cout << \"Exiting\" << std::endl;\n \tCamApp::instance()->quit();\ndiff --git a/src/gstreamer/gstlibcamerapool.cpp b/src/gstreamer/gstlibcamerapool.cpp\nindex 8f536169455f..b756ee356d61 100644\n--- a/src/gstreamer/gstlibcamerapool.cpp\n+++ b/src/gstreamer/gstlibcamerapool.cpp\n@@ -33,7 +33,7 @@ G_DEFINE_TYPE(GstLibcameraPool, gst_libcamera_pool, GST_TYPE_BUFFER_POOL);\n \n static GstFlowReturn\n gst_libcamera_pool_acquire_buffer(GstBufferPool *pool, GstBuffer **buffer,\n-\t\t\t\t GstBufferPoolAcquireParams *params)\n+\t\t\t\t [[maybe_unused]] GstBufferPoolAcquireParams *params)\n {\n \tGstLibcameraPool *self = GST_LIBCAMERA_POOL(pool);\n \tGstBuffer *buf = GST_BUFFER(gst_atomic_queue_pop(self->queue));\ndiff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp\nindex 840e87a3d8da..cd850d813a6e 100644\n--- a/src/gstreamer/gstlibcameraprovider.cpp\n+++ b/src/gstreamer/gstlibcameraprovider.cpp\n@@ -89,7 +89,7 @@ gst_libcamera_device_set_property(GObject *object, guint prop_id,\n }\n \n static void\n-gst_libcamera_device_init(GstLibcameraDevice *self)\n+gst_libcamera_device_init([[maybe_unused]] GstLibcameraDevice *self)\n {\n }\n \ndiff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 0c28ae3f2852..1bfc2e2f8cf3 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -338,7 +338,8 @@ gst_libcamera_src_task_run(gpointer user_data)\n }\n \n static void\n-gst_libcamera_src_task_enter(GstTask *task, GThread *thread, gpointer user_data)\n+gst_libcamera_src_task_enter(GstTask *task, [[maybe_unused]] GThread *thread,\n+\t\t\t gpointer user_data)\n {\n \tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(user_data);\n \tGLibRecLocker lock(&self->stream_lock);\n@@ -467,7 +468,9 @@ done:\n }\n \n static void\n-gst_libcamera_src_task_leave(GstTask *task, GThread *thread, gpointer user_data)\n+gst_libcamera_src_task_leave([[maybe_unused]] GstTask *task,\n+\t\t\t [[maybe_unused]] GThread *thread,\n+\t\t\t gpointer user_data)\n {\n \tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(user_data);\n \tGstLibcameraSrcState *state = self->state;\ndiff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp\nindex c02b5ece242f..3573f36be46a 100644\n--- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n@@ -221,7 +221,8 @@ void Agc::SetConstraintMode(std::string const &constraint_mode_name)\n \tconstraint_mode_name_ = constraint_mode_name;\n }\n \n-void Agc::SwitchMode(CameraMode const &camera_mode, Metadata *metadata)\n+void Agc::SwitchMode([[maybe_unused]] CameraMode const &camera_mode,\n+\t\t Metadata *metadata)\n {\n \t// On a mode switch, it's possible the exposure profile could change,\n \t// so we run through the dividing up of exposure/gain again and\ndiff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex 37472087f5a9..4557016c2dd4 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -191,7 +191,7 @@ void IPARPi::setMode(const CameraSensorInfo &sensorInfo)\n }\n \n void IPARPi::configure(const CameraSensorInfo &sensorInfo,\n-\t\t const std::map<unsigned int, IPAStream> &streamConfig,\n+\t\t [[maybe_unused]] const std::map<unsigned int, IPAStream> &streamConfig,\n \t\t const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n \t\t const IPAOperationData &ipaConfig,\n \t\t IPAOperationData *result)\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 3a1c50c4add0..d95d902adff3 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -32,7 +32,10 @@ LOG_DEFINE_CATEGORY(IPARkISP1)\n class IPARkISP1 : public IPAInterface\n {\n public:\n-\tint init(const IPASettings &settings) override { return 0; }\n+\tint init([[maybe_unused]] const IPASettings &settings) override\n+\t{\n+\t\treturn 0;\n+\t}\n \tint start() override { return 0; }\n \tvoid stop() override {}\n \n@@ -75,11 +78,11 @@ private:\n * assemble one. Make sure the reported sensor information are relevant\n * before accessing them.\n */\n-void IPARkISP1::configure(const CameraSensorInfo &info,\n-\t\t\t const std::map<unsigned int, IPAStream> &streamConfig,\n+void IPARkISP1::configure([[maybe_unused]] const CameraSensorInfo &info,\n+\t\t\t [[maybe_unused]] const std::map<unsigned int, IPAStream> &streamConfig,\n \t\t\t const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n-\t\t\t const IPAOperationData &ipaConfig,\n-\t\t\t IPAOperationData *result)\n+\t\t\t [[maybe_unused]] const IPAOperationData &ipaConfig,\n+\t\t\t [[maybe_unused]] IPAOperationData *result)\n {\n \tif (entityControls.empty())\n \t\treturn;\ndiff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\nindex 1593c92d80f3..ef257762a1d4 100644\n--- a/src/ipa/vimc/vimc.cpp\n+++ b/src/ipa/vimc/vimc.cpp\n@@ -37,14 +37,14 @@ public:\n \tint start() override;\n \tvoid stop() override;\n \n-\tvoid configure(const CameraSensorInfo &sensorInfo,\n-\t\t const std::map<unsigned int, IPAStream> &streamConfig,\n-\t\t const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n-\t\t const IPAOperationData &ipaConfig,\n-\t\t IPAOperationData *result) override {}\n-\tvoid mapBuffers(const std::vector<IPABuffer> &buffers) override {}\n-\tvoid unmapBuffers(const std::vector<unsigned int> &ids) override {}\n-\tvoid processEvent(const IPAOperationData &event) override {}\n+\tvoid configure([[maybe_unused]] const CameraSensorInfo &sensorInfo,\n+\t\t [[maybe_unused]] const std::map<unsigned int, IPAStream> &streamConfig,\n+\t\t [[maybe_unused]] const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n+\t\t [[maybe_unused]] const IPAOperationData &ipaConfig,\n+\t\t [[maybe_unused]] IPAOperationData *result) override {}\n+\tvoid mapBuffers([[maybe_unused]] const std::vector<IPABuffer> &buffers) override {}\n+\tvoid unmapBuffers([[maybe_unused]] const std::vector<unsigned int> &ids) override {}\n+\tvoid processEvent([[maybe_unused]] const IPAOperationData &event) override {}\n \n private:\n \tvoid initTrace();\ndiff --git a/src/libcamera/device_enumerator_udev.cpp b/src/libcamera/device_enumerator_udev.cpp\nindex 96689daa5dd1..c6e23a1a7a18 100644\n--- a/src/libcamera/device_enumerator_udev.cpp\n+++ b/src/libcamera/device_enumerator_udev.cpp\n@@ -327,7 +327,7 @@ int DeviceEnumeratorUdev::addV4L2Device(dev_t devnum)\n \treturn 0;\n }\n \n-void DeviceEnumeratorUdev::udevNotify(EventNotifier *notifier)\n+void DeviceEnumeratorUdev::udevNotify([[maybe_unused]] EventNotifier *notifier)\n {\n \tstruct udev_device *dev = udev_monitor_receive_device(monitor_);\n \tstd::string action(udev_device_get_action(dev));\ndiff --git a/src/libcamera/ipc_unixsocket.cpp b/src/libcamera/ipc_unixsocket.cpp\nindex 7df86e885f23..701b2c518217 100644\n--- a/src/libcamera/ipc_unixsocket.cpp\n+++ b/src/libcamera/ipc_unixsocket.cpp\n@@ -308,7 +308,7 @@ int IPCUnixSocket::recvData(void *buffer, size_t length,\n \treturn 0;\n }\n \n-void IPCUnixSocket::dataNotifier(EventNotifier *notifier)\n+void IPCUnixSocket::dataNotifier([[maybe_unused]] EventNotifier *notifier)\n {\n \tint ret;\n \ndiff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex b8f0549f0c60..42c9caa03e2e 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -758,7 +758,7 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n \treturn ret;\n }\n \n-int PipelineHandlerRPi::exportFrameBuffers(Camera *camera, Stream *stream,\n+int PipelineHandlerRPi::exportFrameBuffers([[maybe_unused]] Camera *camera, Stream *stream,\n \t\t\t\t\t std::vector<std::unique_ptr<FrameBuffer>> *buffers)\n {\n \tRPiStream *s = static_cast<RPiStream *>(stream);\n@@ -1182,7 +1182,8 @@ int RPiCameraData::configureIPA()\n \treturn 0;\n }\n \n-void RPiCameraData::queueFrameAction(unsigned int frame, const IPAOperationData &action)\n+void RPiCameraData::queueFrameAction([[maybe_unused]] unsigned int frame,\n+\t\t\t\t const IPAOperationData &action)\n {\n \t/*\n \t * The following actions can be handled when the pipeline handler is in\ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 32fdaed7c661..4d89aab3845d 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -700,7 +700,7 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \treturn 0;\n }\n \n-int PipelineHandlerRkISP1::exportFrameBuffers(Camera *camera, Stream *stream,\n+int PipelineHandlerRkISP1::exportFrameBuffers([[maybe_unused]] Camera *camera, Stream *stream,\n \t\t\t\t\t std::vector<std::unique_ptr<FrameBuffer>> *buffers)\n {\n \tunsigned int count = stream->configuration().bufferCount;\ndiff --git a/src/libcamera/pipeline/rkisp1/timeline.cpp b/src/libcamera/pipeline/rkisp1/timeline.cpp\nindex f5194608ced7..6b83bbe5b589 100644\n--- a/src/libcamera/pipeline/rkisp1/timeline.cpp\n+++ b/src/libcamera/pipeline/rkisp1/timeline.cpp\n@@ -204,7 +204,7 @@ void Timeline::updateDeadline()\n \ttimer_.start(deadline);\n }\n \n-void Timeline::timeout(Timer *timer)\n+void Timeline::timeout([[maybe_unused]] Timer *timer)\n {\n \tutils::time_point now = std::chrono::steady_clock::now();\n \ndiff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\nindex 8311d274a288..994190dc6f3d 100644\n--- a/src/libcamera/process.cpp\n+++ b/src/libcamera/process.cpp\n@@ -89,7 +89,7 @@ void sigact(int signal, siginfo_t *info, void *ucontext)\n \n } /* namespace */\n \n-void ProcessManager::sighandler(EventNotifier *notifier)\n+void ProcessManager::sighandler([[maybe_unused]] EventNotifier *notifier)\n {\n \tchar data;\n \tssize_t ret = read(pipe_[0], &data, sizeof(data));\ndiff --git a/src/libcamera/proxy/ipa_proxy_linux.cpp b/src/libcamera/proxy/ipa_proxy_linux.cpp\nindex 68eafb307b2a..b78a0e4535f5 100644\n--- a/src/libcamera/proxy/ipa_proxy_linux.cpp\n+++ b/src/libcamera/proxy/ipa_proxy_linux.cpp\n@@ -26,17 +26,20 @@ public:\n \tIPAProxyLinux(IPAModule *ipam);\n \t~IPAProxyLinux();\n \n-\tint init(const IPASettings &settings) override { return 0; }\n+\tint init([[maybe_unused]] const IPASettings &settings) override\n+\t{\n+\t\treturn 0;\n+\t}\n \tint start() override { return 0; }\n \tvoid stop() override {}\n-\tvoid configure(const CameraSensorInfo &sensorInfo,\n-\t\t const std::map<unsigned int, IPAStream> &streamConfig,\n-\t\t const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n-\t\t const IPAOperationData &ipaConfig,\n-\t\t IPAOperationData *result) override {}\n-\tvoid mapBuffers(const std::vector<IPABuffer> &buffers) override {}\n-\tvoid unmapBuffers(const std::vector<unsigned int> &ids) override {}\n-\tvoid processEvent(const IPAOperationData &event) override {}\n+\tvoid configure([[maybe_unused]] const CameraSensorInfo &sensorInfo,\n+\t\t [[maybe_unused]] const std::map<unsigned int, IPAStream> &streamConfig,\n+\t\t [[maybe_unused]] const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n+\t\t [[maybe_unused]] const IPAOperationData &ipaConfig,\n+\t\t [[maybe_unused]] IPAOperationData *result) override {}\n+\tvoid mapBuffers([[maybe_unused]] const std::vector<IPABuffer> &buffers) override {}\n+\tvoid unmapBuffers([[maybe_unused]] const std::vector<unsigned int> &ids) override {}\n+\tvoid processEvent([[maybe_unused]] const IPAOperationData &event) override {}\n \n private:\n \tvoid readyRead(IPCUnixSocket *ipc);\n@@ -91,7 +94,7 @@ IPAProxyLinux::~IPAProxyLinux()\n \tdelete socket_;\n }\n \n-void IPAProxyLinux::readyRead(IPCUnixSocket *ipc)\n+void IPAProxyLinux::readyRead([[maybe_unused]] IPCUnixSocket *ipc)\n {\n }\n \ndiff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\nindex 8391ec48ac10..30c94bb98f44 100644\n--- a/src/libcamera/v4l2_pixelformat.cpp\n+++ b/src/libcamera/v4l2_pixelformat.cpp\n@@ -196,7 +196,7 @@ PixelFormat V4L2PixelFormat::toPixelFormat() const\n * \\return The V4L2PixelFormat corresponding to \\a pixelFormat\n */\n V4L2PixelFormat V4L2PixelFormat::fromPixelFormat(const PixelFormat &pixelFormat,\n-\t\t\t\t\t\t bool multiplanar)\n+\t\t\t\t\t\t [[maybe_unused]] bool multiplanar)\n {\n \tconst PixelFormatInfo &info = PixelFormatInfo::info(pixelFormat);\n \tif (!info.isValid())\ndiff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex 652677ff1d4d..508522ef42bb 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -1462,7 +1462,7 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n * For Capture video devices the FrameBuffer will contain valid data.\n * For Output video devices the FrameBuffer can be considered empty.\n */\n-void V4L2VideoDevice::bufferAvailable(EventNotifier *notifier)\n+void V4L2VideoDevice::bufferAvailable([[maybe_unused]] EventNotifier *notifier)\n {\n \tFrameBuffer *buffer = dequeueBuffer();\n \tif (!buffer)\n@@ -1539,7 +1539,7 @@ FrameBuffer *V4L2VideoDevice::dequeueBuffer()\n * When this slot is called, a V4L2 event is available to be dequeued from the\n * device.\n */\n-void V4L2VideoDevice::eventAvailable(EventNotifier *notifier)\n+void V4L2VideoDevice::eventAvailable([[maybe_unused]] EventNotifier *notifier)\n {\n \tstruct v4l2_event event{};\n \tint ret = ioctl(VIDIOC_DQEVENT, &event);\ndiff --git a/src/qcam/dng_writer.cpp b/src/qcam/dng_writer.cpp\nindex b5b81f0637b5..030d1387118d 100644\n--- a/src/qcam/dng_writer.cpp\n+++ b/src/qcam/dng_writer.cpp\n@@ -215,7 +215,7 @@ void packScanlineIPU3(void *output, const void *input, unsigned int width)\n \t}\n }\n \n-void thumbScanlineIPU3(const FormatInfo &info, void *output,\n+void thumbScanlineIPU3([[maybe_unused]] const FormatInfo &info, void *output,\n \t\t const void *input, unsigned int width,\n \t\t unsigned int stride)\n {\n@@ -350,7 +350,8 @@ static const std::map<PixelFormat, FormatInfo> formatInfo = {\n int DNGWriter::write(const char *filename, const Camera *camera,\n \t\t const StreamConfiguration &config,\n \t\t const ControlList &metadata,\n-\t\t const FrameBuffer *buffer, const void *data)\n+\t\t [[maybe_unused]] const FrameBuffer *buffer,\n+\t\t const void *data)\n {\n \tconst auto it = formatInfo.find(config.pixelFormat);\n \tif (it == formatInfo.cend()) {\ndiff --git a/src/qcam/main.cpp b/src/qcam/main.cpp\nindex b3468cbf47e2..bae358df0877 100644\n--- a/src/qcam/main.cpp\n+++ b/src/qcam/main.cpp\n@@ -17,7 +17,7 @@\n #include \"../cam/stream_options.h\"\n #include \"main_window.h\"\n \n-void signalHandler(int signal)\n+void signalHandler([[maybe_unused]] int signal)\n {\n \tqInfo() << \"Exiting\";\n \tqApp->quit();\ndiff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\nindex 61bca0732447..7a22f983ec0e 100644\n--- a/src/v4l2/v4l2_camera.cpp\n+++ b/src/v4l2/v4l2_camera.cpp\n@@ -158,7 +158,7 @@ int V4L2Camera::validateConfiguration(const PixelFormat &pixelFormat,\n \treturn 0;\n }\n \n-int V4L2Camera::allocBuffers(unsigned int count)\n+int V4L2Camera::allocBuffers([[maybe_unused]] unsigned int count)\n {\n \tStream *stream = config_->at(0).stream();\n \ndiff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\nindex 97a8582761a7..d57ffa75edeb 100644\n--- a/test/camera/buffer_import.cpp\n+++ b/test/camera/buffer_import.cpp\n@@ -33,7 +33,8 @@ public:\n \t}\n \n protected:\n-\tvoid bufferComplete(Request *request, FrameBuffer *buffer)\n+\tvoid bufferComplete([[maybe_unused]] Request *request,\n+\t\t\t FrameBuffer *buffer)\n \t{\n \t\tif (buffer->metadata().status != FrameMetadata::FrameSuccess)\n \t\t\treturn;\ndiff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\nindex 0fe3bf9be7f1..eb67bf2da71f 100644\n--- a/test/camera/capture.cpp\n+++ b/test/camera/capture.cpp\n@@ -26,7 +26,8 @@ protected:\n \tunsigned int completeBuffersCount_;\n \tunsigned int completeRequestsCount_;\n \n-\tvoid bufferComplete(Request *request, FrameBuffer *buffer)\n+\tvoid bufferComplete([[maybe_unused]] Request *request,\n+\t\t\t FrameBuffer *buffer)\n \t{\n \t\tif (buffer->metadata().status != FrameMetadata::FrameSuccess)\n \t\t\treturn;\ndiff --git a/test/hotplug-cameras.cpp b/test/hotplug-cameras.cpp\nindex 6a94535fa315..7d551eeb900d 100644\n--- a/test/hotplug-cameras.cpp\n+++ b/test/hotplug-cameras.cpp\n@@ -26,12 +26,12 @@ using namespace libcamera;\n class HotplugTest : public Test\n {\n protected:\n-\tvoid cameraAddedHandler(std::shared_ptr<Camera> cam)\n+\tvoid cameraAddedHandler([[maybe_unused]] std::shared_ptr<Camera> cam)\n \t{\n \t\tcameraAdded_ = true;\n \t}\n \n-\tvoid cameraRemovedHandler(std::shared_ptr<Camera> cam)\n+\tvoid cameraRemovedHandler([[maybe_unused]] std::shared_ptr<Camera> cam)\n \t{\n \t\tcameraRemoved_ = true;\n \t}\ndiff --git a/test/ipa/ipa_wrappers_test.cpp b/test/ipa/ipa_wrappers_test.cpp\nindex 23c799da0663..59d991cbbf6a 100644\n--- a/test/ipa/ipa_wrappers_test.cpp\n+++ b/test/ipa/ipa_wrappers_test.cpp\n@@ -70,8 +70,8 @@ public:\n \tvoid configure(const CameraSensorInfo &sensorInfo,\n \t\t const std::map<unsigned int, IPAStream> &streamConfig,\n \t\t const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n-\t\t const IPAOperationData &ipaConfig,\n-\t\t IPAOperationData *result) override\n+\t\t [[maybe_unused]] const IPAOperationData &ipaConfig,\n+\t\t [[maybe_unused]] IPAOperationData *result) override\n \t{\n \t\t/* Verify sensorInfo. */\n \t\tif (sensorInfo.outputSize.width != 2560 ||\ndiff --git a/test/libtest/test.h b/test/libtest/test.h\nindex 26d4b94bc12d..8ecf2bda950f 100644\n--- a/test/libtest/test.h\n+++ b/test/libtest/test.h\n@@ -30,7 +30,7 @@ protected:\n };\n \n #define TEST_REGISTER(klass)\t\t\t\t\t\t\\\n-int main(int argc, char *argv[])\t\t\t\t\t\\\n+int main([[maybe_unused]] int argc, [[maybe_unused]] char *argv[])\t\\\n {\t\t\t\t\t\t\t\t\t\\\n \treturn klass().execute();\t\t\t\t\t\\\n }\ndiff --git a/test/log/log_process.cpp b/test/log/log_process.cpp\nindex d46d5e354727..b024f002843c 100644\n--- a/test/log/log_process.cpp\n+++ b/test/log/log_process.cpp\n@@ -125,7 +125,8 @@ protected:\n \t}\n \n private:\n-\tvoid procFinished(Process *proc, enum Process::ExitStatus exitStatus, int exitCode)\n+\tvoid procFinished([[maybe_unused]] Process *proc,\n+\t\t\t enum Process::ExitStatus exitStatus, int exitCode)\n \t{\n \t\texitStatus_ = exitStatus;\n \t\texitCode_ = exitCode;\ndiff --git a/test/object-invoke.cpp b/test/object-invoke.cpp\nindex 1ae11bb11e16..f3fd23283239 100644\n--- a/test/object-invoke.cpp\n+++ b/test/object-invoke.cpp\n@@ -50,7 +50,7 @@ public:\n \t\tvalue_ = value;\n \t}\n \n-\tvoid methodWithReference(const int &value)\n+\tvoid methodWithReference([[maybe_unused]] const int &value)\n \t{\n \t}\n \ndiff --git a/test/process/process_test.cpp b/test/process/process_test.cpp\nindex 721a7c9d46ff..42a26749f5d9 100644\n--- a/test/process/process_test.cpp\n+++ b/test/process/process_test.cpp\n@@ -80,7 +80,8 @@ protected:\n \t}\n \n private:\n-\tvoid procFinished(Process *proc, enum Process::ExitStatus exitStatus, int exitCode)\n+\tvoid procFinished([[maybe_unused]] Process *proc,\n+\t\t\t enum Process::ExitStatus exitStatus, int exitCode)\n \t{\n \t\texitStatus_ = exitStatus;\n \t\texitCode_ = exitCode;\ndiff --git a/test/timer-thread.cpp b/test/timer-thread.cpp\nindex 2f901787f5fb..f794d8e7dd4e 100644\n--- a/test/timer-thread.cpp\n+++ b/test/timer-thread.cpp\n@@ -40,7 +40,7 @@ public:\n \t}\n \n private:\n-\tvoid timeoutHandler(Timer *timer)\n+\tvoid timeoutHandler([[maybe_unused]] Timer *timer)\n \t{\n \t\ttimeout_ = true;\n \t}\ndiff --git a/test/timer.cpp b/test/timer.cpp\nindex 7d5b93c37799..537489d736ad 100644\n--- a/test/timer.cpp\n+++ b/test/timer.cpp\n@@ -57,7 +57,7 @@ public:\n \t}\n \n private:\n-\tvoid timeoutHandler(Timer *timer)\n+\tvoid timeoutHandler([[maybe_unused]] Timer *timer)\n \t{\n \t\texpiration_ = std::chrono::steady_clock::now();\n \t\tcount_++;\n", "prefixes": [ "libcamera-devel", "4/5" ] }