Patch Detail
Show a patch.
GET /api/patches/9228/?format=api
{ "id": 9228, "url": "https://patchwork.libcamera.org/api/patches/9228/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9228/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200805151507.227503-2-kieran.bingham@ideasonboard.com>", "date": "2020-08-05T15:14:55", "name": "[libcamera-devel,v4,01/13] libcamera: buffer: Correct FrameBuffer references", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a785c8703f9170563f84cefcf7d1361a2eef6afe", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9228/mbox/", "series": [ { "id": 1198, "url": "https://patchwork.libcamera.org/api/series/1198/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1198", "date": "2020-08-05T15:14:54", "name": "android: JPEG support", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1198/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9228/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9228/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9EEF9BD86F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 5 Aug 2020 15:15:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 68BB4605C0;\n\tWed, 5 Aug 2020 17:15:13 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 497F360392\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 5 Aug 2020 17:15:11 +0200 (CEST)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C312D304;\n\tWed, 5 Aug 2020 17:15:10 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Y6rit37R\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596640511;\n\tbh=DxAIImIc1YcTwfXBvA42JnIiRQoaoMCbU5KR6C5iMW4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Y6rit37RMCymzw6+bQB+MLvWtSlAXIOhhg8MN89Jvn5FQKe0J/EOFcndlJBi7cgv+\n\teYtCEQf1/7nllPTU095TX9M9Opzu5ESjePIiIp8whm3WmSiyVs3P1IvlNCr3lzJSCx\n\tASGizU1jwVu9LMRo1qNP+DiBhsVSqeKgmB8gd1p4=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Wed, 5 Aug 2020 16:14:55 +0100", "Message-Id": "<20200805151507.227503-2-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200805151507.227503-1-kieran.bingham@ideasonboard.com>", "References": "<20200805151507.227503-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 01/13] libcamera: buffer: Correct\n\tFrameBuffer references", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Update the remaining (capitalised) Buffer references to the new FrameBuffer\nobject that they refer to.\n\nLower-case 'buffer' terms are kept, as a generic reference to a buffer\nrather than the specific type 'FrameBuffer'.\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/buffer.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/buffer.cpp b/src/libcamera/buffer.cpp\nindex 1a1d4bac7aed..8278f8a92af4 100644\n--- a/src/libcamera/buffer.cpp\n+++ b/src/libcamera/buffer.cpp\n@@ -174,11 +174,11 @@ FrameBuffer::FrameBuffer(const std::vector<Plane> &planes, unsigned int cookie)\n * The intended callers of this method are buffer completion handlers that\n * need to associate a buffer to the request it belongs to.\n *\n- * A Buffer is associated to a request by Request::addBuffer() and the\n+ * A FrameBuffer is associated to a request by Request::addBuffer() and the\n * association is valid until the buffer completes. The returned request\n * pointer is valid only during that interval.\n *\n- * \\return The Request the Buffer belongs to, or nullptr if the buffer is\n+ * \\return The Request the FrameBuffer belongs to, or nullptr if the buffer is\n * not associated with a request\n */\n \n@@ -224,7 +224,7 @@ FrameBuffer::FrameBuffer(const std::vector<Plane> &planes, unsigned int cookie)\n \n /**\n * \\brief Copy the contents from another buffer\n- * \\param[in] src Buffer to copy\n+ * \\param[in] src FrameBuffer to copy\n *\n * Copy the buffer contents and metadata from \\a src to this buffer. The\n * destination FrameBuffer shall have the same number of planes as the source\n", "prefixes": [ "libcamera-devel", "v4", "01/13" ] }