Patch Detail
Show a patch.
GET /api/patches/917/?format=api
{ "id": 917, "url": "https://patchwork.libcamera.org/api/patches/917/?format=api", "web_url": "https://patchwork.libcamera.org/patch/917/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190405020256.22520-4-niklas.soderlund@ragnatech.se>", "date": "2019-04-05T02:02:51", "name": "[libcamera-devel,v2,3/8] test: camera: Remove test for bad Stream IDs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "88d955343ab5dd8322a76b1af6bf136571071d35", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/917/mbox/", "series": [ { "id": 240, "url": "https://patchwork.libcamera.org/api/series/240/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=240", "date": "2019-04-05T02:02:48", "name": "libcamera: stream: Add basic stream usages", "version": 2, "mbox": "https://patchwork.libcamera.org/series/240/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/917/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/917/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 811A4610BF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 5 Apr 2019 04:03:08 +0200 (CEST)", "from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid f211df73-5746-11e9-8144-0050569116f7;\n\tFri, 05 Apr 2019 04:03:03 +0200 (CEST)" ], "X-Halon-ID": "f211df73-5746-11e9-8144-0050569116f7", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 5 Apr 2019 04:02:51 +0200", "Message-Id": "<20190405020256.22520-4-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190405020256.22520-1-niklas.soderlund@ragnatech.se>", "References": "<20190405020256.22520-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 3/8] test: camera: Remove test for bad\n\tStream IDs", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 05 Apr 2019 02:03:08 -0000" }, "content": "In preparation of reworking how a default configuration is retrieved\nfrom a camera remove test that stream IDs must be valid as the data type\npassed to Camera::streamConfiguration() will change. This change is in\npreparation for an invasive change.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n test/camera/configuration_default.cpp | 13 -------------\n 1 file changed, 13 deletions(-)", "diff": "diff --git a/test/camera/configuration_default.cpp b/test/camera/configuration_default.cpp\nindex 53ee021d33ca39b1..856cd415f7a6aec1 100644\n--- a/test/camera/configuration_default.cpp\n+++ b/test/camera/configuration_default.cpp\n@@ -49,19 +49,6 @@ protected:\n \t\t\treturn TestFail;\n \t\t}\n \n-\t\t/*\n-\t\t * Test that asking for configuration for an array of bad streams\n-\t\t * returns an empty list of configurations.\n-\t\t */\n-\t\tStream *stream_bad = reinterpret_cast<Stream *>(0xdeadbeef);\n-\t\tstd::set<Stream *> streams_bad = { stream_bad };\n-\t\tconf = camera_->streamConfiguration(streams_bad);\n-\t\tif (!conf.empty()) {\n-\t\t\tcout << \"Failed to retrieve configuration for bad streams\"\n-\t\t\t << endl;\n-\t\t\treturn TestFail;\n-\t\t}\n-\n \t\treturn TestPass;\n \t}\n };\n", "prefixes": [ "libcamera-devel", "v2", "3/8" ] }