Patch Detail
Show a patch.
GET /api/patches/9155/?format=api
{ "id": 9155, "url": "https://patchwork.libcamera.org/api/patches/9155/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9155/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200803211733.1037019-2-niklas.soderlund@ragnatech.se>", "date": "2020-08-03T21:17:25", "name": "[libcamera-devel,v6,1/9] libcamera: device_enumerator: Add method to lookup sysfs path", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e855d8a4d1e44ad050789b314c423c6e4b9f14f8", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9155/mbox/", "series": [ { "id": 1185, "url": "https://patchwork.libcamera.org/api/series/1185/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1185", "date": "2020-08-03T21:17:24", "name": "libcamera: Generate unique and stable camera IDs", "version": 6, "mbox": "https://patchwork.libcamera.org/series/1185/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9155/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9155/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F0C74BD87A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 3 Aug 2020 21:18:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E049D6199D;\n\tMon, 3 Aug 2020 23:18:00 +0200 (CEST)", "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9CC99605A9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Aug 2020 23:17:59 +0200 (CEST)", "from bismarck.berto.se (p54ac52a8.dip0.t-ipconnect.de\n\t[84.172.82.168]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 9c7cf789-d5ce-11ea-86ee-0050569116f7;\n\tMon, 03 Aug 2020 23:16:35 +0200 (CEST)" ], "X-Halon-ID": "9c7cf789-d5ce-11ea-86ee-0050569116f7", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 3 Aug 2020 23:17:25 +0200", "Message-Id": "<20200803211733.1037019-2-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200803211733.1037019-1-niklas.soderlund@ragnatech.se>", "References": "<20200803211733.1037019-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v6 1/9] libcamera: device_enumerator: Add\n\tmethod to lookup sysfs path", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add an implementation to lookup a device nodes sysfs interface path\nbased on the assumption that device name under /dev matches the one\nunder /sysfs. Subclasses of the DeviceEnumerator may override this to\ncreate more clever methods to lookup the path.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n include/libcamera/internal/device_enumerator.h | 2 ++\n src/libcamera/device_enumerator.cpp | 14 ++++++++++++++\n 2 files changed, 16 insertions(+)", "diff": "diff --git a/include/libcamera/internal/device_enumerator.h b/include/libcamera/internal/device_enumerator.h\nindex a9850400229d2b53..11961f4f9304f6d7 100644\n--- a/include/libcamera/internal/device_enumerator.h\n+++ b/include/libcamera/internal/device_enumerator.h\n@@ -45,6 +45,8 @@ public:\n \n \tstd::shared_ptr<MediaDevice> search(const DeviceMatch &dm);\n \n+\tvirtual std::string lookupSysfsPath(const std::string &deviceNode);\n+\n \tSignal<> devicesAdded;\n \n protected:\ndiff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\nindex 647974b17341f44b..ef2451ac29159bf0 100644\n--- a/src/libcamera/device_enumerator.cpp\n+++ b/src/libcamera/device_enumerator.cpp\n@@ -318,4 +318,18 @@ std::shared_ptr<MediaDevice> DeviceEnumerator::search(const DeviceMatch &dm)\n \treturn nullptr;\n }\n \n+/**\n+ * \\brief Lookup a nodes sysfs path\n+ * \\param[in] deviceNode device node to lookup\n+ *\n+ * Lookup \\a deviceNode sysfs interface.\n+ *\n+ * \\return Path in sysfs\n+ */\n+std::string DeviceEnumerator::lookupSysfsPath(const std::string &deviceNode)\n+{\n+\tstd::string dev = basename(deviceNode.c_str());\n+\treturn \"/sys/class/video4linux/\" + dev;\n+}\n+\n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "v6", "1/9" ] }