Patch Detail
Show a patch.
GET /api/patches/9153/?format=api
{ "id": 9153, "url": "https://patchwork.libcamera.org/api/patches/9153/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9153/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200803162811.77634-1-jacopo@jmondi.org>", "date": "2020-08-03T16:28:11", "name": "[libcamera-devel] libcamera: ipu3: Fix compilation issues with gcc5", "commit_ref": "375fef72f85ba9184c860c4af86013e8688896e7", "pull_url": null, "state": "accepted", "archived": false, "hash": "e3d301605d0392bddbc50f2b6a6b3ab29e15277e", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9153/mbox/", "series": [ { "id": 1184, "url": "https://patchwork.libcamera.org/api/series/1184/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1184", "date": "2020-08-03T16:28:11", "name": "[libcamera-devel] libcamera: ipu3: Fix compilation issues with gcc5", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1184/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9153/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9153/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DFC18BD86F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 3 Aug 2020 16:24:42 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8CDCC60745;\n\tMon, 3 Aug 2020 18:24:42 +0200 (CEST)", "from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D39AF605A9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Aug 2020 18:24:40 +0200 (CEST)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id F0ECFE000B;\n\tMon, 3 Aug 2020 16:24:39 +0000 (UTC)" ], "X-Originating-IP": "93.34.118.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 3 Aug 2020 18:28:11 +0200", "Message-Id": "<20200803162811.77634-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] libcamera: ipu3: Fix compilation issues\n\twith gcc5", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "GCC5 does not provide prototypes for the math library functions defined\nin the math.h header for the std:: namespace.\n\nInclude the C++ <cmath> header in place of <math.h> as it defines\noverloads for the std::abs and std::fmod function.\n\nThis goes intentionally against the libcamera coding guidelines, and\nis reported as warning by checkpatch.py.\n\nFixes: 968ab9bad0ed (\"libcamera: ipu3: imgu: Calculate ImgU pipe configuration\")\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\nindex b7593ceb3672..eb829e096561 100644\n--- a/src/libcamera/pipeline/ipu3/imgu.cpp\n+++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n@@ -7,8 +7,8 @@\n \n #include \"imgu.h\"\n \n+#include <cmath>\n #include <limits>\n-#include <math.h>\n \n #include <linux/media-bus-format.h>\n \n", "prefixes": [ "libcamera-devel" ] }