Patch Detail
Show a patch.
GET /api/patches/9146/?format=api
{ "id": 9146, "url": "https://patchwork.libcamera.org/api/patches/9146/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9146/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200803161816.107113-7-kieran.bingham@ideasonboard.com>", "date": "2020-08-03T16:18:10", "name": "[libcamera-devel,v2,06/12] android: camera_device: Report an error in notifyError()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6a6f80239b8efe7f32ac228987adb428ccadcba1", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9146/mbox/", "series": [ { "id": 1183, "url": "https://patchwork.libcamera.org/api/series/1183/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1183", "date": "2020-08-03T16:18:04", "name": "android: jpeg", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1183/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9146/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9146/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AB547BD86F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 3 Aug 2020 16:18:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 733BD61B35;\n\tMon, 3 Aug 2020 18:18:28 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2BC65619A6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Aug 2020 18:18:25 +0200 (CEST)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8AFD8D98;\n\tMon, 3 Aug 2020 18:18:23 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RTeL4JJM\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596471503;\n\tbh=wkI9536wnTTr4ozf9rNXc3a5+hWQMqW9dN1micTDvuE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=RTeL4JJMoU94teCcvWsovAGvH839+7mf6gcawEaO4LAKcwhvRGeVLSjwN+M1XHoyq\n\tuIrFEXvyNbcYZGzQ67JnQnQG/5Lp23cl/T//e8qhx3Y3Q5QdYvPTh0qxMYyzbT+CIe\n\tvk2bekYHs0mZTHGXVmhdvzfXkmSYHR6so9QC7HJ8=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Mon, 3 Aug 2020 17:18:10 +0100", "Message-Id": "<20200803161816.107113-7-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200803161816.107113-1-kieran.bingham@ideasonboard.com>", "References": "<20200803161816.107113-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 06/12] android: camera_device: Report\n\tan error in notifyError()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "If an error is generated, try to be verbose about it in the libcamera logs.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\nv2:\n - Add todo to note possible debug info expansion\n - Fix typo\n - Print .toString() formatted pixel format\n\nv3:\n - Remove colon from todo:\n\n\nNote that the calling point of this function always gives stream zero\nanyway.\n\n src/android/camera_device.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex cf50821eec71..388945b1075c 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1198,6 +1198,13 @@ void CameraDevice::notifyError(uint32_t frameNumber, camera3_stream_t *stream)\n {\n \tcamera3_notify_msg_t notify = {};\n \n+\t/*\n+\t * \\todo Report and identify the stream number or configuration to\n+\t * clarify the stream that failed.\n+\t */\n+\tLOG(HAL, Error) << \"Error occurred on frame \" << frameNumber << \" (\"\n+\t\t\t<< toPixelFormat(stream->format).toString() << \")\";\n+\n \tnotify.type = CAMERA3_MSG_ERROR;\n \tnotify.message.error.error_stream = stream;\n \tnotify.message.error.frame_number = frameNumber;\n", "prefixes": [ "libcamera-devel", "v2", "06/12" ] }