Patch Detail
Show a patch.
GET /api/patches/9092/?format=api
{ "id": 9092, "url": "https://patchwork.libcamera.org/api/patches/9092/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9092/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200731140801.13253-2-david.plowman@raspberrypi.com>", "date": "2020-07-31T14:07:58", "name": "[libcamera-devel,v2,1/4] libcamera: ipa: raspberrypi: ALSC: Camera mode does not need to be atomic", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b1978c475bea2a40a7f8c82ef7b9e185ff60c76c", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9092/mbox/", "series": [ { "id": 1169, "url": "https://patchwork.libcamera.org/api/series/1169/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1169", "date": "2020-07-31T14:07:57", "name": "Raspberry Pi ALSC improvements", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1169/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9092/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9092/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 18690BD86F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 31 Jul 2020 14:08:11 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D824A61ED2;\n\tFri, 31 Jul 2020 16:08:10 +0200 (CEST)", "from mail-wr1-x442.google.com (mail-wr1-x442.google.com\n\t[IPv6:2a00:1450:4864:20::442])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A38C61EA4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 31 Jul 2020 16:08:08 +0200 (CEST)", "by mail-wr1-x442.google.com with SMTP id z18so24567021wrm.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 31 Jul 2020 07:08:08 -0700 (PDT)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tg126sm12815084wme.16.2020.07.31.07.08.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 31 Jul 2020 07:08:07 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"ArUzHbxB\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=YsLkAYx4rUDXYF5WdVBATIg6lWA6O/bC19Vhs9ldyOk=;\n\tb=ArUzHbxB6oQpKl+h8z4DulkUc3SOFVXGCUIBG2bVMkXn7kaaFIB5jeJswU22YGgr9z\n\tfT0zcyl9U1DK/kah1wYn+LF6c8+xa8Sc+k854dYaAiXtQw04r/HZOUe7y/Y+ApQkiXYO\n\tgkvqFaBT0eH5PdoXYMN3KhRN72m7i1OlFZoL8uoTtZuczxy4rm12OmDrOk2Ymh+YhEzc\n\ttBMevtvljMlQ478IqH9r5tDYSIZHc4sK624mJU4RJiG6ahH1ZU2vh9Qf2h9solkO+wLg\n\tFDdK/lrpM/381A0sz7cTe6n8m0fQmsxvrl8o6xQV773JUNWtGSne115fOVUMeVi0pppa\n\tAzYQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=YsLkAYx4rUDXYF5WdVBATIg6lWA6O/bC19Vhs9ldyOk=;\n\tb=bkvOLtO8eUL50eMzDyuYF9nzbEUzDMZW/s9EONbcI/xUOrjlbd0EeMdSGtSl7EQnAl\n\taSz5apMhuoGLENtT+QP3+5GCnbC3zgghI90CII551wa43OxSI6dSKJojqb8VHG4K0Lxc\n\tpaUNEvE4gfFq8+ec6ptLynspFB7ZGSlqqDrRiqMbNpXH2cHfqWdKVDkAkd1jO/vicVPM\n\tZ5BzcBUC6NoFBgZCZ1qTIN2lu64pT8Vloov50vn4qYbvupzck1fiICTrGGKrSbfytjQr\n\tuRsBGjLMv8axgxt7G2F4KvzDJlcYslO5sHf2atzuP7tT9hWOYVnodzgSMEXP0lP7kaOH\n\tlTxw==", "X-Gm-Message-State": "AOAM532hsqI9rttkebB+4kGD5zWZMpZcrjYXJe8FD2bGCDUBc/2OTLAL\n\tqDIZ193UausUmS6BWyXF+2bK7P2Si39s0A==", "X-Google-Smtp-Source": "ABdhPJyu2ywM2sC4OSYY5uctd3pHWL0SI/1GRgaHVmJupifdzPTg319VOkc2U9v84mTGhpVQTAvdOw==", "X-Received": "by 2002:a5d:4a41:: with SMTP id v1mr4032378wrs.371.1596204487646;\n\tFri, 31 Jul 2020 07:08:07 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 31 Jul 2020 15:07:58 +0100", "Message-Id": "<20200731140801.13253-2-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200731140801.13253-1-david.plowman@raspberrypi.com>", "References": "<20200731140801.13253-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 1/4] libcamera: ipa: raspberrypi: ALSC:\n\tCamera mode does not need to be atomic", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In the libcamera framework, SwitchMode (which overwrites the\ncamera_mode) cannot run concurrently with Prepare (which uses it).\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/raspberrypi/controller/rpi/alsc.hpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.hpp b/src/ipa/raspberrypi/controller/rpi/alsc.hpp\nindex 3806257..e895913 100644\n--- a/src/ipa/raspberrypi/controller/rpi/alsc.hpp\n+++ b/src/ipa/raspberrypi/controller/rpi/alsc.hpp\n@@ -59,7 +59,7 @@ private:\n \t// configuration is read-only, and available to both threads\n \tAlscConfig config_;\n \tbool first_time_;\n-\tstd::atomic<CameraMode> camera_mode_;\n+\tCameraMode camera_mode_;\n \tstd::thread async_thread_;\n \tvoid asyncFunc(); // asynchronous thread function\n \tstd::mutex mutex_;\n", "prefixes": [ "libcamera-devel", "v2", "1/4" ] }