Patch Detail
Show a patch.
GET /api/patches/9079/?format=api
{ "id": 9079, "url": "https://patchwork.libcamera.org/api/patches/9079/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9079/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200730111134.641-2-david.plowman@raspberrypi.com>", "date": "2020-07-30T11:11:32", "name": "[libcamera-devel,1/3] libcamera: ipa: raspberrypi: ALSC: Camera mode does not need to be atomic", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b1978c475bea2a40a7f8c82ef7b9e185ff60c76c", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9079/mbox/", "series": [ { "id": 1165, "url": "https://patchwork.libcamera.org/api/series/1165/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1165", "date": "2020-07-30T11:11:31", "name": "Raspberry Pi ALSC improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1165/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9079/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9079/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C1C8BD878\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 30 Jul 2020 11:11:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 365FC61DC3;\n\tThu, 30 Jul 2020 13:11:44 +0200 (CEST)", "from mail-wr1-x443.google.com (mail-wr1-x443.google.com\n\t[IPv6:2a00:1450:4864:20::443])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DA1B2605B2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Jul 2020 13:11:40 +0200 (CEST)", "by mail-wr1-x443.google.com with SMTP id a14so24519753wra.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Jul 2020 04:11:40 -0700 (PDT)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tl10sm9526651wru.3.2020.07.30.04.11.39\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 30 Jul 2020 04:11:39 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"corUk9et\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=/vU50YwdRbjN/X7IPem/bDcMy210W4lUqKwV06EiTB8=;\n\tb=corUk9et8Ftl991qFarTB8UCL8wd6vVoPy3DvxYzB30top7FUqpjYD2+S0/V8ErqZK\n\t1w8Kf9GQKhAcxXyilqjOZ8evNIhWZYUy2327/aZDuuhX1YLuiUtwTRaHNS1vAguAYJoc\n\ts+KSMv0fIgRqKhvsDGs1smv1jzsrMEaoSgINdruAIp+PRtnqvqXOTZwVeDcSQkmyXTHL\n\t0Y+Ahd0VF6UTAqTfktbJNzu2EqYTzr7TLNAyRW1dxCK9PwEyTlei4JM5+C/eZXi/VFeI\n\tmnnR4xHG3djM4/YbgqvHtJmnkvTUHzpZnpXbSV5Kw1VkVe3Tygqll97fOVGWYH3RPckC\n\tFm9Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=/vU50YwdRbjN/X7IPem/bDcMy210W4lUqKwV06EiTB8=;\n\tb=BgFFsOT0J0pgDgFanpKrCIcGppnZW8VXf2IbRC1hLsjTbq0xCMoBeNLl/CRXl5tVe6\n\tbJe65R9caKRZIr2L/vcB2KwM+E5IMMCzLbs3wjRsrR34urxqLtQhfyZY0QuzNM15hgWS\n\t2+ZVTJypcOcgj/xPBopCdzQx9PKAdfnVwn/Isl8z4PbLEHKadj4MzL17o+lETXfQez4N\n\td+QYGVesBiG5BPgttUU57etVYyTAkeAMbZwJEBIkdtax6W2hlCCSYU9TACCayIiaZDsY\n\tlX8NdGFfVXy9bUYCLHe6RHGwEBX001RW9Vj8eSkK/bh95/CO82Y0Hp73qmhx/Jpm6FN8\n\tzD6w==", "X-Gm-Message-State": "AOAM531JS6Kaj/E3BXk8skDCppYJKNrsNBGP9HW7joWFGfX3uy/D3hZt\n\tc8pm2gAkAoR3vxVRltj3vG3zO9bH2pX0vg==", "X-Google-Smtp-Source": "ABdhPJx07B9bgznzQly7gpWk2iQZjQhHQezpqRSzL2FxVZvxRgdvMhP3eBTWpIj9D9J4v+v3BmwADw==", "X-Received": "by 2002:adf:ee51:: with SMTP id\n\tw17mr35193322wro.239.1596107500350; \n\tThu, 30 Jul 2020 04:11:40 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 30 Jul 2020 12:11:32 +0100", "Message-Id": "<20200730111134.641-2-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200730111134.641-1-david.plowman@raspberrypi.com>", "References": "<20200730111134.641-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 1/3] libcamera: ipa: raspberrypi: ALSC:\n\tCamera mode does not need to be atomic", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In the libcamera framework, SwitchMode (which overwrites the\ncamera_mode) cannot run concurrently with Prepare (which uses it).\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/raspberrypi/controller/rpi/alsc.hpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.hpp b/src/ipa/raspberrypi/controller/rpi/alsc.hpp\nindex 3806257..e895913 100644\n--- a/src/ipa/raspberrypi/controller/rpi/alsc.hpp\n+++ b/src/ipa/raspberrypi/controller/rpi/alsc.hpp\n@@ -59,7 +59,7 @@ private:\n \t// configuration is read-only, and available to both threads\n \tAlscConfig config_;\n \tbool first_time_;\n-\tstd::atomic<CameraMode> camera_mode_;\n+\tCameraMode camera_mode_;\n \tstd::thread async_thread_;\n \tvoid asyncFunc(); // asynchronous thread function\n \tstd::mutex mutex_;\n", "prefixes": [ "libcamera-devel", "1/3" ] }