Patch Detail
Show a patch.
GET /api/patches/9067/?format=api
{ "id": 9067, "url": "https://patchwork.libcamera.org/api/patches/9067/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9067/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200729111202.3812677-2-niklas.soderlund@ragnatech.se>", "date": "2020-07-29T11:12:00", "name": "[libcamera-devel,v2,1/3] android: camera_device: Prepare for none-mandatory formats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "aa6c21f0d0b2fe0fd30dc2486882913e484429dc", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9067/mbox/", "series": [ { "id": 1161, "url": "https://patchwork.libcamera.org/api/series/1161/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1161", "date": "2020-07-29T11:11:59", "name": "android: camera_device: Add RAW support", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1161/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9067/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9067/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B3923BD86F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 29 Jul 2020 11:12:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4B7176196B;\n\tWed, 29 Jul 2020 13:12:13 +0200 (CEST)", "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AD5956039D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 29 Jul 2020 13:12:11 +0200 (CEST)", "from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 55cbb221-d18c-11ea-933e-005056917a89;\n\tWed, 29 Jul 2020 13:12:05 +0200 (CEST)" ], "X-Halon-ID": "55cbb221-d18c-11ea-933e-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 29 Jul 2020 13:12:00 +0200", "Message-Id": "<20200729111202.3812677-2-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200729111202.3812677-1-niklas.soderlund@ragnatech.se>", "References": "<20200729111202.3812677-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 1/3] android: camera_device: Prepare\n\tfor none-mandatory formats", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When probing what formats a libcamera Camera supports we want to allow\nto probe for none-mandatory formats. Add a new flag to indicate if a\nformat in camera3FormatsMap is mandatory or not.\n\nAll current defined formats are mandatory.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/android/camera_device.cpp | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex b49d6681e5a52d32..ce37fcb8cf5cd4b3 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -46,6 +46,7 @@ const std::vector<Size> camera3Resolutions = {\n */\n struct Camera3Format {\n \tstd::vector<PixelFormat> libcameraFormats;\n+\tbool mandatory;\n \tconst char *name;\n };\n \n@@ -57,11 +58,13 @@ const std::map<int, const Camera3Format> camera3FormatsMap = {\n \t{\n \t\tHAL_PIXEL_FORMAT_BLOB, {\n \t\t\t{ formats::MJPEG },\n+\t\t\ttrue,\n \t\t\t\"BLOB\"\n \t\t}\n \t}, {\n \t\tHAL_PIXEL_FORMAT_YCbCr_420_888, {\n \t\t\t{ formats::NV12, formats::NV21 },\n+\t\t\ttrue,\n \t\t\t\"YCbCr_420_888\"\n \t\t}\n \t}, {\n@@ -71,6 +74,7 @@ const std::map<int, const Camera3Format> camera3FormatsMap = {\n \t\t */\n \t\tHAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED, {\n \t\t\t{ formats::NV12, formats::NV21 },\n+\t\t\ttrue,\n \t\t\t\"IMPLEMENTATION_DEFINED\"\n \t\t}\n \t},\n@@ -281,7 +285,7 @@ int CameraDevice::initializeStreamConfigurations()\n \t\t\t\tbreak;\n \t\t\t}\n \t\t}\n-\t\tif (!mappedFormat.isValid()) {\n+\t\tif (format.mandatory && !mappedFormat.isValid()) {\n \t\t\tLOG(HAL, Error) << \"Failed to map Android format \"\n \t\t\t\t\t<< camera3Format.name << \" (\"\n \t\t\t\t\t<< utils::hex(androidFormat) << \")\";\n", "prefixes": [ "libcamera-devel", "v2", "1/3" ] }