Patch Detail
Show a patch.
GET /api/patches/9033/?format=api
{ "id": 9033, "url": "https://patchwork.libcamera.org/api/patches/9033/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9033/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200727185731.21618-1-laurent.pinchart@ideasonboard.com>", "date": "2020-07-27T18:57:31", "name": "[libcamera-devel] test: Remove list-cameras test", "commit_ref": "624f6d54fff0b5cd370c4e21b9fdb03ab9993cd8", "pull_url": null, "state": "accepted", "archived": false, "hash": "14f5783f0afbf1726a8c64811283e09516a63a17", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9033/mbox/", "series": [ { "id": 1154, "url": "https://patchwork.libcamera.org/api/series/1154/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1154", "date": "2020-07-27T18:57:31", "name": "[libcamera-devel] test: Remove list-cameras test", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1154/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9033/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9033/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 701D7BD86F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 27 Jul 2020 18:57:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F363D6118A;\n\tMon, 27 Jul 2020 20:57:46 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7852605B2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Jul 2020 20:57:45 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2325B556\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Jul 2020 20:57:43 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hU7mQ5qf\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595876263;\n\tbh=pN9sdjXSCdkQ7vypmHaoV6lxfn0YKcNdLbBo6TinKcc=;\n\th=From:To:Subject:Date:From;\n\tb=hU7mQ5qfCF9eB6vqLTXkbVO//qsVFmrAp6xDRLjz3lB5vut6o/L+11szkXCRdCBFI\n\tYU23X/3R5qi1iWROy1hz8ckI1KPEMfxS0pP8tKjB0kYWYBONcde7iqTy4oC8HwANQm\n\tTqj6+sFBajSljJ/O215deSvhrGFxmVKeH+G78H1Q=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 27 Jul 2020 21:57:31 +0300", "Message-Id": "<20200727185731.21618-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] test: Remove list-cameras test", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The list-cameras test case is the very first test case that has been\nadded to libcamera. It has served to start the development of the unit\ntests infrastructure. Since then, libcamera has grown several tests that\ncover the same API, and more. It's time for list-cameras to retire.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/list-cameras.cpp | 54 -------------------------------------------\n test/meson.build | 1 -\n 2 files changed, 55 deletions(-)\n delete mode 100644 test/list-cameras.cpp", "diff": "diff --git a/test/list-cameras.cpp b/test/list-cameras.cpp\ndeleted file mode 100644\nindex e6a407aca7f8..000000000000\n--- a/test/list-cameras.cpp\n+++ /dev/null\n@@ -1,54 +0,0 @@\n-/* SPDX-License-Identifier: GPL-2.0-or-later */\n-/*\n- * Copyright (C) 2018, Google Inc.\n- *\n- * list.cpp - camera list tests\n- */\n-\n-#include <iostream>\n-\n-#include <libcamera/camera.h>\n-#include <libcamera/camera_manager.h>\n-\n-#include \"test.h\"\n-\n-using namespace std;\n-using namespace libcamera;\n-\n-class ListTest : public Test\n-{\n-protected:\n-\tint init()\n-\t{\n-\t\tcm_ = new CameraManager();\n-\t\tif (cm_->start()) {\n-\t\t\tstd::cout << \"Failed to start camera\" << std::endl;\n-\t\t\treturn TestFail;\n-\t\t}\n-\n-\t\treturn 0;\n-\t}\n-\n-\tint run()\n-\t{\n-\t\tunsigned int count = 0;\n-\n-\t\tfor (const std::shared_ptr<Camera> &camera : cm_->cameras()) {\n-\t\t\tcout << \"- \" << camera->name() << endl;\n-\t\t\tcount++;\n-\t\t}\n-\n-\t\treturn count ? 0 : -ENODEV;\n-\t}\n-\n-\tvoid cleanup()\n-\t{\n-\t\tcm_->stop();\n-\t\tdelete cm_;\n-\t}\n-\n-private:\n-\tCameraManager *cm_;\n-};\n-\n-TEST_REGISTER(ListTest)\ndiff --git a/test/meson.build b/test/meson.build\nindex f41d6e740e6a..c0fb9bdfac17 100644\n--- a/test/meson.build\n+++ b/test/meson.build\n@@ -18,7 +18,6 @@ subdir('v4l2_videodevice')\n \n public_tests = [\n ['geometry', 'geometry.cpp'],\n- ['list-cameras', 'list-cameras.cpp'],\n ['signal', 'signal.cpp'],\n ['span', 'span.cpp'],\n ]\n", "prefixes": [ "libcamera-devel" ] }