Patch Detail
Show a patch.
GET /api/patches/9004/?format=api
{ "id": 9004, "url": "https://patchwork.libcamera.org/api/patches/9004/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9004/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200725144058.129388-5-jacopo@jmondi.org>", "date": "2020-07-25T14:40:56", "name": "[libcamera-devel,v2,4/6] android: camera_metadata: Add method to update an entry", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b6abea49a41b264b14f98f535b38f11b12b761ac", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9004/mbox/", "series": [ { "id": 1146, "url": "https://patchwork.libcamera.org/api/series/1146/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1146", "date": "2020-07-25T14:40:52", "name": "android: camera_device: Generate correct preview template", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1146/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9004/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9004/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2CBF5BD879\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 25 Jul 2020 14:37:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E44DA613AF;\n\tSat, 25 Jul 2020 16:37:31 +0200 (CEST)", "from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 935AD6138C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 25 Jul 2020 16:37:29 +0200 (CEST)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id B36AF240008;\n\tSat, 25 Jul 2020 14:37:28 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 25 Jul 2020 16:40:56 +0200", "Message-Id": "<20200725144058.129388-5-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200725144058.129388-1-jacopo@jmondi.org>", "References": "<20200725144058.129388-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 4/6] android: camera_metadata: Add\n\tmethod to update an entry", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a method to update an existing metadata tag entry, by wrapping\nthe update_metadata_entry() function provided by the Android\nmetadata library.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_metadata.cpp | 27 +++++++++++++++++++++++++++\n src/android/camera_metadata.h | 1 +\n 2 files changed, 28 insertions(+)", "diff": "diff --git a/src/android/camera_metadata.cpp b/src/android/camera_metadata.cpp\nindex ea33e9c2de25..f0da9ea92924 100644\n--- a/src/android/camera_metadata.cpp\n+++ b/src/android/camera_metadata.cpp\n@@ -46,6 +46,33 @@ bool CameraMetadata::addEntry(uint32_t tag, const void *data, size_t count)\n \treturn false;\n }\n \n+bool CameraMetadata::updateEntry(uint32_t tag, const void *data, size_t count)\n+{\n+\tif (!valid_)\n+\t\treturn false;\n+\n+\tcamera_metadata_entry_t entry;\n+\tint ret = find_camera_metadata_entry(metadata_, tag, &entry);\n+\tif (ret) {\n+\t\tconst char *name = get_camera_metadata_tag_name(tag);\n+\t\tLOG(CameraMetadata, Error)\n+\t\t\t<< \"Failed to update tag \"\n+\t\t\t<< (name ? name : \"<unknown>\") << \": not present\";\n+\t\treturn false;\n+\t}\n+\n+\tret = update_camera_metadata_entry(metadata_, entry.index, data,\n+\t\t\t\t\t count, nullptr);\n+\tif (ret) {\n+\t\tconst char *name = get_camera_metadata_tag_name(tag);\n+\t\tLOG(CameraMetadata, Error)\n+\t\t\t<< \"Failed to update tag \" << (name ? name : \"<unknown>\");\n+\t\treturn false;\n+\t}\n+\n+\treturn true;\n+}\n+\n camera_metadata_t *CameraMetadata::get()\n {\n \treturn valid_ ? metadata_ : nullptr;\ndiff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\nindex f16dd27bbf44..9d047b1bb534 100644\n--- a/src/android/camera_metadata.h\n+++ b/src/android/camera_metadata.h\n@@ -19,6 +19,7 @@ public:\n \n \tbool isValid() const { return valid_; }\n \tbool addEntry(uint32_t tag, const void *data, size_t data_count);\n+\tbool updateEntry(uint32_t tag, const void *data, size_t data_count);\n \n \tcamera_metadata_t *get();\n \tconst camera_metadata_t *get() const;\n", "prefixes": [ "libcamera-devel", "v2", "4/6" ] }