Patch Detail
Show a patch.
GET /api/patches/8993/?format=api
{ "id": 8993, "url": "https://patchwork.libcamera.org/api/patches/8993/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8993/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200724230841.27838-3-laurent.pinchart@ideasonboard.com>", "date": "2020-07-24T23:08:41", "name": "[libcamera-devel,2/2] test: Add tests for the Flags class", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "0462039a9772e4c9e1b9aadce60e9c82cd283fb1", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": { "id": 14, "url": "https://patchwork.libcamera.org/api/users/14/?format=api", "username": "pinchartl", "first_name": "Laurent", "last_name": "Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/8993/mbox/", "series": [ { "id": 1143, "url": "https://patchwork.libcamera.org/api/series/1143/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1143", "date": "2020-07-24T23:08:39", "name": "libcamera: Add type-safe enum-based flags", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1143/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8993/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8993/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 59195BD878\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 24 Jul 2020 23:08:57 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D9B7661366;\n\tSat, 25 Jul 2020 01:08:56 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D8D1260939\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 25 Jul 2020 01:08:55 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 711BD538\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 25 Jul 2020 01:08:52 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nfflp8g/\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595632132;\n\tbh=W9sXLdPHFJjTnt29uwOhGRc0ZoouWOc7dFyhBAWlX+M=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=nfflp8g/cvjLwAKN6fHw8dMxFrY5N5j0mW+RoZx6eMII1kp5NTqX2cKAEmWFWySDO\n\tbmdL0LBpshgJGSmfFGZQsYi2XnNED1CuvvR5/ZPmtRl+j9jw6d7gMC3R163W9GjdPk\n\tBVwTAsPGXLMbxOz65sz2z7si9ZlBlLsE2TvYwtA8=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 25 Jul 2020 02:08:41 +0300", "Message-Id": "<20200724230841.27838-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200724230841.27838-1-laurent.pinchart@ideasonboard.com>", "References": "<20200724230841.27838-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 2/2] test: Add tests for the Flags class", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add tests that exercise the whole API of the Flags class.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/flags.cpp | 204 +++++++++++++++++++++++++++++++++++++++++++++++\n test/meson.build | 1 +\n 2 files changed, 205 insertions(+)\n create mode 100644 test/flags.cpp", "diff": "diff --git a/test/flags.cpp b/test/flags.cpp\nnew file mode 100644\nindex 000000000000..82eca556f35e\n--- /dev/null\n+++ b/test/flags.cpp\n@@ -0,0 +1,204 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2020, Google Inc.\n+ *\n+ * flags.cpp - Flags tests\n+ */\n+\n+#include <iostream>\n+\n+#include <libcamera/flags.h>\n+\n+#include \"test.h\"\n+\n+using namespace libcamera;\n+using namespace std;\n+\n+class FlagsTest : public Test\n+{\n+protected:\n+\tenum class Option {\n+\t\tFirst = (1 << 0),\n+\t\tSecond = (1 << 1),\n+\t\tThird = (1 << 2),\n+\t};\n+\n+\tusing Options = Flags<Option>;\n+\n+\tenum class Mode {\n+\t\tAlpha = (1 << 0),\n+\t\tBeta = (1 << 2),\n+\t\tGamma = (1 << 2),\n+\t};\n+\n+\tusing Modes = Flags<Mode>;\n+\n+\tint run() override;\n+};\n+\n+namespace libcamera {\n+\n+LIBCAMERA_FLAGS_ENABLE_OPERATORS(FlagsTest::Option)\n+\n+} /* namespace libcamera */\n+\n+int FlagsTest::run()\n+{\n+\t/* Commented-out constructs are expected not compile. */\n+\n+\t/* Flags<int> f; */\n+\n+\t/*\n+\t * Unary operators with enum argument.\n+\t */\n+\n+\tOptions options;\n+\n+\tif (options) {\n+\t\tcerr << \"Default-constructed Flags<> is not zero\" << endl;\n+\t\treturn TestFail;\n+\t}\n+\n+\toptions |= Option::First;\n+\n+\tif (!options || options != Option::First) {\n+\t\tcerr << \"Unary bitwise OR with enum failed\" << endl;\n+\t\treturn TestFail;\n+\t}\n+\n+\t/* options &= Mode::Alpha; */\n+\t/* options |= Mode::Beta; */\n+\t/* options ^= Mode::Gamma; */\n+\n+\toptions &= ~Option::First;\n+\n+\tif (options) {\n+\t\tcerr << \"Unary bitwise AND with enum failed\" << endl;\n+\t\treturn TestFail;\n+\t}\n+\n+\toptions ^= Option::Second;\n+\n+\tif (options != Option::Second) {\n+\t\tcerr << \"Unary bitwise XOR with enum failed\" << endl;\n+\t\treturn TestFail;\n+\t}\n+\n+\toptions = Options();\n+\n+\t/*\n+\t * Unary operators with Flags argument.\n+\t */\n+\n+\toptions |= Options(Option::First);\n+\n+\tif (options != Option::First) {\n+\t\tcerr << \"Unary bitwise OR with Flags<> failed\" << endl;\n+\t\treturn TestFail;\n+\t}\n+\n+\t/* options &= Options(Mode::Alpha); */\n+\t/* options |= Options(Mode::Beta); */\n+\t/* options ^= Options(Mode::Gamma); */\n+\n+\toptions &= ~Options(Option::First);\n+\n+\tif (options) {\n+\t\tcerr << \"Unary bitwise AND with Flags<> failed\" << endl;\n+\t\treturn TestFail;\n+\t}\n+\n+\toptions ^= Options(Option::Second);\n+\n+\tif (options != Option::Second) {\n+\t\tcerr << \"Unary bitwise XOR with Flags<> failed\" << endl;\n+\t\treturn TestFail;\n+\t}\n+\n+\toptions = Options();\n+\n+\t/*\n+\t * Binary operators with enum argument.\n+\t */\n+\n+\toptions = options | Option::First;\n+\n+\tif (!(options & Option::First)) {\n+\t\tcerr << \"Binary bitwise OR with enum failed\" << endl;\n+\t\treturn TestFail;\n+\t}\n+\n+\t/* options = options & Mode::Alpha; */\n+\t/* options = options | Mode::Beta; */\n+\t/* options = options ^ Mode::Gamma; */\n+\n+\toptions = options & ~Option::First;\n+\n+\tif (options != (Option::First & Option::Second)) {\n+\t\tcerr << \"Binary bitwise AND with enum failed\" << endl;\n+\t\treturn TestFail;\n+\t}\n+\n+\toptions = options ^ (Option::First ^ Option::Second);\n+\n+\tif (options != (Option::First | Option::Second)) {\n+\t\tcerr << \"Binary bitwise XOR with enum failed\" << endl;\n+\t\treturn TestFail;\n+\t}\n+\n+\toptions = Options();\n+\n+\t/*\n+\t * Binary operators with Flags argument.\n+\t */\n+\n+\toptions |= Options(Option::First);\n+\n+\tif (!(options & Option::First)) {\n+\t\tcerr << \"Binary bitwise OR with Flags<> failed\" << endl;\n+\t\treturn TestFail;\n+\t}\n+\n+\t/* options = options & Options(Mode::Alpha); */\n+\t/* options = options | Options(Mode::Beta); */\n+\t/* options = options ^ Options(Mode::Gamma); */\n+\n+\toptions = options & ~Options(Option::First);\n+\n+\tif (options) {\n+\t\tcerr << \"Binary bitwise AND with Flags<> failed\" << endl;\n+\t\treturn TestFail;\n+\t}\n+\n+\toptions = options ^ Options(Option::Second);\n+\n+\tif (options != Option::Second) {\n+\t\tcerr << \"Binary bitwise XOR with Flags<> failed\" << endl;\n+\t\treturn TestFail;\n+\t}\n+\n+\toptions = Options();\n+\n+\t/*\n+\t * Conversion operators.\n+\t */\n+\toptions |= Option::First | Option::Second | Option::Third;\n+\tif (static_cast<Options::Type>(options) != 7) {\n+\t\tcerr << \"Cast to underlying type failed\" << endl;\n+\t\treturn TestFail;\n+\t}\n+\n+\t/*\n+\t * Conversion of the result of ninary operators on the underlying enum.\n+\t */\n+\n+\t/* unsigned int val1 = Option::First; */\n+\t/* unsigned int val2 = ~Option::First; */\n+\t/* unsigned int val3 = Option::First | Option::Second; */\n+\t/* Option val4 = ~Option::First; */\n+\t/* Option val5 = Option::First | Option::Second; */\n+\n+\treturn TestPass;\n+}\n+\n+TEST_REGISTER(FlagsTest)\ndiff --git a/test/meson.build b/test/meson.build\nindex f41d6e740e6a..81b20521e8cb 100644\n--- a/test/meson.build\n+++ b/test/meson.build\n@@ -31,6 +31,7 @@ internal_tests = [\n ['event-thread', 'event-thread.cpp'],\n ['file', 'file.cpp'],\n ['file-descriptor', 'file-descriptor.cpp'],\n+ ['flags', 'flags.cpp'],\n ['hotplug-cameras', 'hotplug-cameras.cpp'],\n ['message', 'message.cpp'],\n ['object', 'object.cpp'],\n", "prefixes": [ "libcamera-devel", "2/2" ] }