Patch Detail
Show a patch.
GET /api/patches/8971/?format=api
{ "id": 8971, "url": "https://patchwork.libcamera.org/api/patches/8971/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8971/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200724142120.95538-4-jacopo@jmondi.org>", "date": "2020-07-24T14:21:17", "name": "[libcamera-devel,3/6] andrdid: camera_device: Store const templates", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a7ee7a99243d5774a055b81c546e0b3d9c6a0950", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8971/mbox/", "series": [ { "id": 1137, "url": "https://patchwork.libcamera.org/api/series/1137/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1137", "date": "2020-07-24T14:21:14", "name": "android: camera_device: generate templates per use-case", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1137/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8971/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8971/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A9A0BD879\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 24 Jul 2020 14:17:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 35DCA611B4;\n\tFri, 24 Jul 2020 16:17:52 +0200 (CEST)", "from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0DAD760535\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Jul 2020 16:17:50 +0200 (CEST)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 6A35E60003;\n\tFri, 24 Jul 2020 14:17:49 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 24 Jul 2020 16:21:17 +0200", "Message-Id": "<20200724142120.95538-4-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200724142120.95538-1-jacopo@jmondi.org>", "References": "<20200724142120.95538-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 3/6] andrdid: camera_device: Store const\n\ttemplates", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The request capture templates stored in the\nCameraDevice::requestTemplates_ should not be modified once created.\n\nStore a const reference to the request templates in the class member\nmap.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_device.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/android/camera_device.h b/src/android/camera_device.h\nindex 5b8b9c3e26e2..af1b58ab6b4e 100644\n--- a/src/android/camera_device.h\n+++ b/src/android/camera_device.h\n@@ -95,7 +95,7 @@ private:\n \tstd::unique_ptr<libcamera::CameraConfiguration> config_;\n \n \tCameraMetadata *staticMetadata_;\n-\tstd::map<unsigned int, CameraMetadata *> requestTemplates_;\n+\tstd::map<unsigned int, const CameraMetadata *> requestTemplates_;\n \tconst camera3_callback_ops_t *callbacks_;\n \n \tstd::vector<Camera3StreamConfiguration> streamConfigurations_;\n", "prefixes": [ "libcamera-devel", "3/6" ] }