Patch Detail
Show a patch.
GET /api/patches/8970/?format=api
{ "id": 8970, "url": "https://patchwork.libcamera.org/api/patches/8970/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8970/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200724142120.95538-3-jacopo@jmondi.org>", "date": "2020-07-24T14:21:16", "name": "[libcamera-devel,2/6] android: camera_metadata: Add const version of get()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9ed2dbdd9f06013999236c61c9791e3d3282aa02", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8970/mbox/", "series": [ { "id": 1137, "url": "https://patchwork.libcamera.org/api/series/1137/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1137", "date": "2020-07-24T14:21:14", "name": "android: camera_device: generate templates per use-case", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1137/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8970/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8970/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 339AEBD878\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 24 Jul 2020 14:17:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0F9BF611B0;\n\tFri, 24 Jul 2020 16:17:52 +0200 (CEST)", "from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3C93C60535\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Jul 2020 16:17:49 +0200 (CEST)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id B003B60003;\n\tFri, 24 Jul 2020 14:17:48 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 24 Jul 2020 16:21:16 +0200", "Message-Id": "<20200724142120.95538-3-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200724142120.95538-1-jacopo@jmondi.org>", "References": "<20200724142120.95538-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 2/6] android: camera_metadata: Add const\n\tversion of get()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a const version of the CameraMetadata::get() method to retrieve\na const reference to the camera metadata wrapped by the class instance.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_metadata.cpp | 5 +++++\n src/android/camera_metadata.h | 1 +\n 2 files changed, 6 insertions(+)", "diff": "diff --git a/src/android/camera_metadata.cpp b/src/android/camera_metadata.cpp\nindex 47b2e4ef117a..ea33e9c2de25 100644\n--- a/src/android/camera_metadata.cpp\n+++ b/src/android/camera_metadata.cpp\n@@ -50,3 +50,8 @@ camera_metadata_t *CameraMetadata::get()\n {\n \treturn valid_ ? metadata_ : nullptr;\n }\n+\n+const camera_metadata_t *CameraMetadata::get() const\n+{\n+\treturn valid_ ? metadata_ : nullptr;\n+}\ndiff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\nindex 348a018165ef..f16dd27bbf44 100644\n--- a/src/android/camera_metadata.h\n+++ b/src/android/camera_metadata.h\n@@ -21,6 +21,7 @@ public:\n \tbool addEntry(uint32_t tag, const void *data, size_t data_count);\n \n \tcamera_metadata_t *get();\n+\tconst camera_metadata_t *get() const;\n \n private:\n \tcamera_metadata_t *metadata_;\n", "prefixes": [ "libcamera-devel", "2/6" ] }