Patch Detail
Show a patch.
GET /api/patches/8963/?format=api
{ "id": 8963, "url": "https://patchwork.libcamera.org/api/patches/8963/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8963/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200724112950.957955-1-naush@raspberrypi.com>", "date": "2020-07-24T11:29:50", "name": "[libcamera-devel] libcamera: request: Add log point on a completed request", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3003e074229ba97be3ab7d3c608cafe6022a0e47", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8963/mbox/", "series": [ { "id": 1135, "url": "https://patchwork.libcamera.org/api/series/1135/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1135", "date": "2020-07-24T11:29:50", "name": "[libcamera-devel] libcamera: request: Add log point on a completed request", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1135/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8963/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8963/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BCF3DBD878\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 24 Jul 2020 11:29:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3C81E611AA;\n\tFri, 24 Jul 2020 13:29:56 +0200 (CEST)", "from mail-wr1-x441.google.com (mail-wr1-x441.google.com\n\t[IPv6:2a00:1450:4864:20::441])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 997206039B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Jul 2020 13:29:54 +0200 (CEST)", "by mail-wr1-x441.google.com with SMTP id z18so4426795wrm.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Jul 2020 04:29:54 -0700 (PDT)", "from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\to7sm952956wrv.50.2020.07.24.04.29.53\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 24 Jul 2020 04:29:53 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"PJWmXx/1\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=JZ98mCYIUxxywBuqfgnRj2F0kTZVCXXRhNghWQ6qjMQ=;\n\tb=PJWmXx/181j6+YLjRF4p7qz+qsaosHQytAyqKR3je/y7arGJ+LzUNpyG85pVGZJf+e\n\tiboHLa6U0lhmVwXzZCuG0GnX6EciVRXOm/gSK8xZ/rOrrN+ePo+9fiB98EnKyhK7y+3g\n\tm7xVJ+OKa2aDhU5MkG8f4BW+/vW/QYJ5uCGnuc5FX0b5QeGfsmMNVVxXYRLRvRTJLN79\n\t9dtbHwIGiSlxZdvPY23YJ+OBdgyYXzbViHRHRU0T+0U0bT+eZ0luzJSHKTpWWykzL0AA\n\tWUIardc7nM12CKyqe1X9QyJR2lDlB8cVdpVfW0W4hcBo4zM+svC8CzgfPHsOQk0sYpcg\n\tpPsw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=JZ98mCYIUxxywBuqfgnRj2F0kTZVCXXRhNghWQ6qjMQ=;\n\tb=DDCZikNGPi6biuW/+tpiSQv2ccxTTFfwpX1ZaCjgOf99bOtQfhIwB2awf6fdzm6qu0\n\tw3XUGnvSRViW/rimyJkNj8VokZSWvmE9fqnlmQEr0Cfduvx9/dOAqanZDKFBvKOCfSeR\n\tlxMP6YGJrNzJs2U37idxA7S8ZvfcG0L5B/4hCM0ru8laTMpu2bxZPZrZ8iTYPGnjT6L8\n\tvGWab6B+XBkW6RxvA+mTsPK0h3H8Mq6WvuBfE0cnO25Jot0AzPrrOsxALTUAnyYaHfPn\n\tHbk496N3JkBgXGqYQJN1OkEuCiNcEjUoifODohMyqAXdrG6P65TFXoPNsggllv/wUMkM\n\tuhjA==", "X-Gm-Message-State": "AOAM533Rb+loSA6WDWwzE9sMSDYBBdP/QcF6+EpVO84gKGF06YI9GVD/\n\tUraJGvfH1oKSVasygxZ8Ajym9hrHFahYmQ==", "X-Google-Smtp-Source": "ABdhPJyaHiwXN9sPRDaQJE3vcWXZk1n1nUunpseKE68m1PRlYioI7LWVEr0iqMp7eua7BO1UTcL2lA==", "X-Received": "by 2002:adf:c986:: with SMTP id f6mr8360109wrh.168.1595590193967;\n\tFri, 24 Jul 2020 04:29:53 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 24 Jul 2020 12:29:50 +0100", "Message-Id": "<20200724112950.957955-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200724072218.943245-4-naush@raspberrypi.com>", "References": "<20200724072218.943245-4-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] libcamera: request: Add log point on a\n\tcompleted request", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a debug log point to indicate a request has completed.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/request.cpp | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 6b9e0b4a..bcb0a1a7 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -212,6 +212,10 @@ void Request::complete()\n {\n \tASSERT(!hasPendingBuffers());\n \tstatus_ = cancelled_ ? RequestCancelled : RequestComplete;\n+\n+\tLOG(Request, Debug) << \"Request has completed - cookie: \"\n+\t\t\t << cookie_\n+\t\t\t << (cancelled_ ? \" [Cancelled]\" : \"\");\n }\n \n /**\n", "prefixes": [ "libcamera-devel" ] }