Patch Detail
Show a patch.
GET /api/patches/8960/?format=api
{ "id": 8960, "url": "https://patchwork.libcamera.org/api/patches/8960/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8960/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200724090744.508110-3-niklas.soderlund@ragnatech.se>", "date": "2020-07-24T09:07:42", "name": "[libcamera-devel,v2,2/4] android: camera_device: Use HAL_PIXEL_FORMAT_* defines for formats", "commit_ref": "142a9ee3f87726a8842a32bc132ca4a11d750a9e", "pull_url": null, "state": "accepted", "archived": false, "hash": "4d9a29b3be5b5ffe93581f47288e48edd804c98c", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8960/mbox/", "series": [ { "id": 1134, "url": "https://patchwork.libcamera.org/api/series/1134/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1134", "date": "2020-07-24T09:07:40", "name": "android: camera_device: Improve on format related tags", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1134/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8960/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8960/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 16CCABD86F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 24 Jul 2020 09:07:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E99C9611B4;\n\tFri, 24 Jul 2020 11:07:58 +0200 (CEST)", "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EE6C3611A2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Jul 2020 11:07:54 +0200 (CEST)", "from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 286546c7-cd8d-11ea-8fb8-005056917f90;\n\tFri, 24 Jul 2020 11:07:54 +0200 (CEST)" ], "X-Halon-ID": "286546c7-cd8d-11ea-8fb8-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 24 Jul 2020 11:07:42 +0200", "Message-Id": "<20200724090744.508110-3-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200724090744.508110-1-niklas.soderlund@ragnatech.se>", "References": "<20200724090744.508110-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 2/4] android: camera_device: Use\n\tHAL_PIXEL_FORMAT_* defines for formats", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The documentation says the HAL_PIXEL_FORMAT_* defines shall be used for\nformats instead of ANDROID_SCALER_AVAILABLE_FORMATS_* for the\nANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS and\nANDROID_SCALER_AVAILABLE_MIN_FRAME_DURATIONS tags.\n\nThis have worked in the past as the numerical value of the two sets are\nthe same for the formats supported.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_device.cpp | 8 ++++----\n src/android/camera_device.h | 2 +-\n 2 files changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 6e7673583f6a8f85..96dd8d5a99082966 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -317,14 +317,14 @@ int CameraDevice::initializeStreamConfigurations()\n \t\t\t status != CameraConfiguration::Valid)\n \t\t\t\tcontinue;\n \n-\t\t\tstreamConfigurations_.push_back({ res, camera3Format.scalerFormat });\n+\t\t\tstreamConfigurations_.push_back({ res, androidFormat });\n \t\t}\n \t}\n \n \tLOG(HAL, Debug) << \"Collected stream configuration map: \";\n \tfor (const auto &entry : streamConfigurations_)\n \t\tLOG(HAL, Debug) << \"{ \" << entry.resolution.toString() << \" - \"\n-\t\t\t\t<< utils::hex(entry.androidScalerCode) << \" }\";\n+\t\t\t\t<< utils::hex(entry.androidFormat) << \" }\";\n \n \treturn 0;\n }\n@@ -658,7 +658,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \tstd::vector<uint32_t> availableStreamConfigurations;\n \tavailableStreamConfigurations.reserve(streamConfigurations_.size() * 4);\n \tfor (const auto &entry : streamConfigurations_) {\n-\t\tavailableStreamConfigurations.push_back(entry.androidScalerCode);\n+\t\tavailableStreamConfigurations.push_back(entry.androidFormat);\n \t\tavailableStreamConfigurations.push_back(entry.resolution.width);\n \t\tavailableStreamConfigurations.push_back(entry.resolution.height);\n \t\tavailableStreamConfigurations.push_back(\n@@ -679,7 +679,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \tstd::vector<int64_t> minFrameDurations;\n \tminFrameDurations.reserve(streamConfigurations_.size() * 4);\n \tfor (const auto &entry : streamConfigurations_) {\n-\t\tminFrameDurations.push_back(entry.androidScalerCode);\n+\t\tminFrameDurations.push_back(entry.androidFormat);\n \t\tminFrameDurations.push_back(entry.resolution.width);\n \t\tminFrameDurations.push_back(entry.resolution.height);\n \t\tminFrameDurations.push_back(33333333);\ndiff --git a/src/android/camera_device.h b/src/android/camera_device.h\nindex 5b8b9c3e26e2871e..00472c21938871a1 100644\n--- a/src/android/camera_device.h\n+++ b/src/android/camera_device.h\n@@ -75,7 +75,7 @@ private:\n \n \tstruct Camera3StreamConfiguration {\n \t\tlibcamera::Size resolution;\n-\t\tint androidScalerCode;\n+\t\tint androidFormat;\n \t};\n \n \tint initializeStreamConfigurations();\n", "prefixes": [ "libcamera-devel", "v2", "2/4" ] }