Patch Detail
Show a patch.
GET /api/patches/8950/?format=api
{ "id": 8950, "url": "https://patchwork.libcamera.org/api/patches/8950/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8950/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200724072218.943245-7-naush@raspberrypi.com>", "date": "2020-07-24T07:22:14", "name": "[libcamera-devel,v5,06/10] libcamera: pipeline: raspberrypi: Remove const qualifier from RPiStream", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d3a8251a2f5e74688c84cc50425133bda0b6e516", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8950/mbox/", "series": [ { "id": 1132, "url": "https://patchwork.libcamera.org/api/series/1132/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1132", "date": "2020-07-24T07:22:08", "name": "Zero-copy RAW stream work", "version": 5, "mbox": "https://patchwork.libcamera.org/series/1132/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8950/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8950/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8FEDBD86F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 24 Jul 2020 07:22:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4A4086117D;\n\tFri, 24 Jul 2020 09:22:58 +0200 (CEST)", "from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com\n\t[IPv6:2a00:1450:4864:20::32c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7CF12611B1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Jul 2020 09:22:54 +0200 (CEST)", "by mail-wm1-x32c.google.com with SMTP id p14so6672478wmg.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Jul 2020 00:22:54 -0700 (PDT)", "from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\t32sm246595wrn.86.2020.07.24.00.22.53\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 24 Jul 2020 00:22:53 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Ft7S7ZqL\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=iEyyfA3+WNqQRC7R74q9CPRwheLMtJQvOOHm7j6/5qo=;\n\tb=Ft7S7ZqLHNwEu8nWNTbEsl8fG28OG3DrDReYCEn99swmuc3eEM9XLeUF8GpFovAyB3\n\t7fKUpYP+FJz+RONwn4M+bNncd3X8TZU2OpDywEVOheni/G4w6Tkc/hgnibPcBkYmhuhh\n\tIk4Ips62Ek7N1w1bBDxCEUGAuh4gk/3eb9Ybc2GAyuKXt4YWrdDzZFNojhSNn8HejsN1\n\tViRXck98jGYBZifNvuGaIvpp+ekx7wi9xSU6N7vjtXlgAQFv/cf7ZzU+0nxwzZ/nnAgB\n\tSIq102cBVGbobVM2YDlC7vRim9UIeKRRuvZN6LxEm+Fs50t9jFyrIRjHIqyEiOljAkWt\n\t3UiQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=iEyyfA3+WNqQRC7R74q9CPRwheLMtJQvOOHm7j6/5qo=;\n\tb=IPX/8NORtCVSQOtP4ybbD23p9VYvW1Cm4DLxiVvEPuU7DcoO6a2z58qZPFTD3RD931\n\t2oT9ryshu8hX/77N1ZLl2J6HpMOAAv1HyX8Cu5C6CHHW36AvDgQls74e1GFgYy77z4g+\n\tsLcpQ18HJxo1q8109wIu0GsMVM3ICbJEzN/NeE0YWMN9U/p9g3fDzZoGBAvE1V/wIQN8\n\t0UoT+2JJ0TrdVXWxCo8NxHQt3OjsKDopF3AFEcUYbWfEe8NZ6Wef390sUucDYoTOspni\n\t/rRaBeaZwu06EkatsdQvQoategOm89V7O+tfR6s4cHPbcmWt5tzi9upguYbJd8rCp/CV\n\tcyqA==", "X-Gm-Message-State": "AOAM531oDGeQ7kiVZGAsduRsVFHaxQRNAMfCnf4AZWNr5SFpR/UtQuW3\n\t3uHkdYSg3y2+fXmlsTTrfZFTfxsTEM5Udw==", "X-Google-Smtp-Source": "ABdhPJyvxs2EQs3evKx5vsKWCCZeNB7kgucIlbs68Xj6ak43bifpozh0AupTsm79MoTXBxmx9KXmMw==", "X-Received": "by 2002:a7b:c205:: with SMTP id x5mr7953352wmi.161.1595575373900;\n\tFri, 24 Jul 2020 00:22:53 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 24 Jul 2020 08:22:14 +0100", "Message-Id": "<20200724072218.943245-7-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200724072218.943245-1-naush@raspberrypi.com>", "References": "<20200724072218.943245-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v5 06/10] libcamera: pipeline:\n\traspberrypi: Remove const qualifier from RPiStream", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "For the zero-copy RAW capture feature, the RPiStream will have to be\nmodified. Remove the const qualifier in anticipation of the future\ncommits for this feature.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nTested-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 31e15a45..e2afccc0 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -150,7 +150,7 @@ public:\n \tvoid ispOutputDequeue(FrameBuffer *buffer);\n \n \tvoid clearIncompleteRequests();\n-\tvoid handleStreamBuffer(FrameBuffer *buffer, const RPi::RPiStream *stream);\n+\tvoid handleStreamBuffer(FrameBuffer *buffer, RPi::RPiStream *stream);\n \tvoid handleState();\n \n \tCameraSensor *sensor_;\n@@ -1105,12 +1105,12 @@ done:\n \n void RPiCameraData::unicamBufferDequeue(FrameBuffer *buffer)\n {\n-\tconst RPi::RPiStream *stream = nullptr;\n+\tRPi::RPiStream *stream = nullptr;\n \n \tif (state_ == State::Stopped)\n \t\treturn;\n \n-\tfor (RPi::RPiStream const &s : unicam_) {\n+\tfor (RPi::RPiStream &s : unicam_) {\n \t\tif (s.findFrameBuffer(buffer)) {\n \t\t\tstream = &s;\n \t\t\tbreak;\n@@ -1171,12 +1171,12 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer)\n \n void RPiCameraData::ispOutputDequeue(FrameBuffer *buffer)\n {\n-\tconst RPi::RPiStream *stream = nullptr;\n+\tRPi::RPiStream *stream = nullptr;\n \n \tif (state_ == State::Stopped)\n \t\treturn;\n \n-\tfor (RPi::RPiStream const &s : isp_) {\n+\tfor (RPi::RPiStream &s : isp_) {\n \t\tif (s.findFrameBuffer(buffer)) {\n \t\t\tstream = &s;\n \t\t\tbreak;\n@@ -1257,7 +1257,7 @@ void RPiCameraData::clearIncompleteRequests()\n \t}\n }\n \n-void RPiCameraData::handleStreamBuffer(FrameBuffer *buffer, const RPi::RPiStream *stream)\n+void RPiCameraData::handleStreamBuffer(FrameBuffer *buffer, RPi::RPiStream *stream)\n {\n \tif (stream->isExternal()) {\n \t\tif (!dropFrameCount_) {\n", "prefixes": [ "libcamera-devel", "v5", "06/10" ] }