Patch Detail
Show a patch.
GET /api/patches/8939/?format=api
{ "id": 8939, "url": "https://patchwork.libcamera.org/api/patches/8939/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8939/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200723173942.98182-2-niklas.soderlund@ragnatech.se>", "date": "2020-07-23T17:39:39", "name": "[libcamera-devel,1/4] android: camera_device: Remove ANDROID_SCALER_AVAILABLE_FORMATS", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ea343d7fcdeb2965805648af29480d4038d9efe0", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8939/mbox/", "series": [ { "id": 1130, "url": "https://patchwork.libcamera.org/api/series/1130/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1130", "date": "2020-07-23T17:39:38", "name": "android: camera_device: Improve on format related tags", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1130/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8939/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8939/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 16607BD878\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Jul 2020 17:40:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E3F92611A2;\n\tThu, 23 Jul 2020 19:40:51 +0200 (CEST)", "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6B5E960496\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Jul 2020 19:40:48 +0200 (CEST)", "from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid a407d5b5-cd0b-11ea-933e-005056917a89;\n\tThu, 23 Jul 2020 19:40:47 +0200 (CEST)" ], "X-Halon-ID": "a407d5b5-cd0b-11ea-933e-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 23 Jul 2020 19:39:39 +0200", "Message-Id": "<20200723173942.98182-2-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200723173942.98182-1-niklas.soderlund@ragnatech.se>", "References": "<20200723173942.98182-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 1/4] android: camera_device: Remove\n\tANDROID_SCALER_AVAILABLE_FORMATS", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "According to the documentation the tag\nANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS deprecates the\nANDROID_SCALER_AVAILABLE_FORMATS tag. As the HAL implements both tags\nremove the deprecated one.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/android/camera_device.cpp | 15 ++-------------\n 1 file changed, 2 insertions(+), 13 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 48f8090a93db454d..6e7673583f6a8f85 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -376,7 +376,7 @@ std::tuple<uint32_t, uint32_t> CameraDevice::calculateStaticMetadataSize()\n \t * \\todo Keep this in sync with the actual number of entries.\n \t * Currently: 50 entries, 647 bytes of static metadata\n \t */\n-\tuint32_t numEntries = 50;\n+\tuint32_t numEntries = 49;\n \tuint32_t byteSize = 647;\n \n \t/*\n@@ -385,10 +385,9 @@ std::tuple<uint32_t, uint32_t> CameraDevice::calculateStaticMetadataSize()\n \t *\n \t * Each stream configuration entry requires 52 bytes:\n \t * 4 32bits integers for ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS\n-\t * 1 32bits integer for ANDROID_SCALER_AVAILABLE_FORMATS\n \t * 4 64bits integers for ANDROID_SCALER_AVAILABLE_MIN_FRAME_DURATIONS\n \t */\n-\tbyteSize += streamConfigurations_.size() * 52;\n+\tbyteSize += streamConfigurations_.size() * 48;\n \n \treturn std::make_tuple(numEntries, byteSize);\n }\n@@ -656,15 +655,6 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_MAX_DIGITAL_ZOOM,\n \t\t\t\t &maxDigitalZoom, 1);\n \n-\tstd::vector<uint32_t> availableStreamFormats;\n-\tavailableStreamFormats.reserve(streamConfigurations_.size());\n-\tstd::transform(streamConfigurations_.begin(), streamConfigurations_.end(),\n-\t\t std::back_inserter(availableStreamFormats),\n-\t\t [](const auto &entry) { return entry.androidScalerCode; });\n-\tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_FORMATS,\n-\t\t\t\t availableStreamFormats.data(),\n-\t\t\t\t availableStreamFormats.size());\n-\n \tstd::vector<uint32_t> availableStreamConfigurations;\n \tavailableStreamConfigurations.reserve(streamConfigurations_.size() * 4);\n \tfor (const auto &entry : streamConfigurations_) {\n@@ -761,7 +751,6 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t\tANDROID_LENS_INFO_MINIMUM_FOCUS_DISTANCE,\n \t\tANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES,\n \t\tANDROID_SCALER_AVAILABLE_MAX_DIGITAL_ZOOM,\n-\t\tANDROID_SCALER_AVAILABLE_FORMATS,\n \t\tANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS,\n \t\tANDROID_SCALER_AVAILABLE_STALL_DURATIONS,\n \t\tANDROID_SCALER_AVAILABLE_MIN_FRAME_DURATIONS,\n", "prefixes": [ "libcamera-devel", "1/4" ] }