Patch Detail
Show a patch.
GET /api/patches/8875/?format=api
{ "id": 8875, "url": "https://patchwork.libcamera.org/api/patches/8875/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8875/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200720104736.19986-4-jacopo@jmondi.org>", "date": "2020-07-20T10:47:20", "name": "[libcamera-devel,v4,03/19] libcamera: geometry: Add isNull() function to Rectangle class", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e12ca3ca4d0ac7d5b4bdf3b3133d86aae5768da6", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8875/mbox/", "series": [ { "id": 1118, "url": "https://patchwork.libcamera.org/api/series/1118/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1118", "date": "2020-07-20T10:47:17", "name": "ipu3: rework pipe confiuguration", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1118/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8875/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8875/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 546AEC0109\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 20 Jul 2020 10:44:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 10B77605BB;\n\tMon, 20 Jul 2020 12:44:19 +0200 (CEST)", "from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7BA1360537\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 Jul 2020 12:44:15 +0200 (CEST)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id AE2BC60011;\n\tMon, 20 Jul 2020 10:44:14 +0000 (UTC)" ], "X-Originating-IP": "93.34.118.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 20 Jul 2020 12:47:20 +0200", "Message-Id": "<20200720104736.19986-4-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200720104736.19986-1-jacopo@jmondi.org>", "References": "<20200720104736.19986-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 03/19] libcamera: geometry: Add\n\tisNull() function to Rectangle class", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "It's common for code to check if a rectangle is null. Add a helper function\nto do so and test the function in test/geometry.cpp\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n include/libcamera/geometry.h | 1 +\n src/libcamera/geometry.cpp | 6 ++++++\n test/geometry.cpp | 14 ++++++++++++++\n 3 files changed, 21 insertions(+)", "diff": "diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\nindex d858f85cf1f0..02fb63c08f60 100644\n--- a/include/libcamera/geometry.h\n+++ b/include/libcamera/geometry.h\n@@ -181,6 +181,7 @@ public:\n \tunsigned int width;\n \tunsigned int height;\n \n+\tbool isNull() const { return !width && !height; }\n \tconst std::string toString() const;\n };\n \ndiff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\nindex 23181bdec969..b12e1a62f939 100644\n--- a/src/libcamera/geometry.cpp\n+++ b/src/libcamera/geometry.cpp\n@@ -385,6 +385,12 @@ bool operator==(const SizeRange &lhs, const SizeRange &rhs)\n * \\brief The distance between the top and bottom sides\n */\n \n+/**\n+ * \\fn bool Rectangle::isNull() const\n+ * \\brief Check if the rectangle is null\n+ * \\return True if both the width and height are 0, or false otherwise\n+ */\n+\n /**\n * \\brief Assemble and return a string describing the rectangle\n * \\return A string describing the Rectangle\ndiff --git a/test/geometry.cpp b/test/geometry.cpp\nindex 1a9fc1b8e3ed..08e268c9c312 100644\n--- a/test/geometry.cpp\n+++ b/test/geometry.cpp\n@@ -182,6 +182,20 @@ protected:\n \t\tif (!compare(Size(200, 100), Size(100, 200), &operator>=, \">=\", true))\n \t\t\treturn TestFail;\n \n+\t\t/* Test Rectangle::isNull(). */\n+\t\tif (!Rectangle(0, 0, 0, 0).isNull() ||\n+\t\t !Rectangle(1, 1, 0, 0).isNull()) {\n+\t\t\tcout << \"Null rectangle incorrectly reported as not null\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (Rectangle(0, 0, 0, 1).isNull() ||\n+\t\t Rectangle(0, 0, 1, 0).isNull() ||\n+\t\t Rectangle(0, 0, 1, 1).isNull()) {\n+\t\t\tcout << \"Non-null rectangle incorrectly reported as null\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n \t\treturn TestPass;\n \t}\n };\n", "prefixes": [ "libcamera-devel", "v4", "03/19" ] }