Patch Detail
Show a patch.
GET /api/patches/8869/?format=api
{ "id": 8869, "url": "https://patchwork.libcamera.org/api/patches/8869/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8869/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200720091311.805092-8-naush@raspberrypi.com>", "date": "2020-07-20T09:13:09", "name": "[libcamera-devel,v4,7/9] libcamera: pipeline: raspberrypi: Fix bug in passing configuration to IPA", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bff231561128ef256652363ed8cdc354fd95fd7e", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8869/mbox/", "series": [ { "id": 1117, "url": "https://patchwork.libcamera.org/api/series/1117/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1117", "date": "2020-07-20T09:13:02", "name": "Zero-copy RAW stream work", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1117/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8869/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8869/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A5503BD792\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 20 Jul 2020 09:13:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 591CB60724;\n\tMon, 20 Jul 2020 11:13:36 +0200 (CEST)", "from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com\n\t[IPv6:2a00:1450:4864:20::42c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2E33E60732\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 Jul 2020 11:13:34 +0200 (CEST)", "by mail-wr1-x42c.google.com with SMTP id f7so17068602wrw.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 Jul 2020 02:13:34 -0700 (PDT)", "from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tu1sm38137185wrb.78.2020.07.20.02.13.32\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 20 Jul 2020 02:13:32 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"QhLoulLM\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=0ZvNILQsT/lrTa1SsqTTVdBjGKFPz1KeBl7JphindJQ=;\n\tb=QhLoulLMa2cNuszm97/RgrOnersc41RquF1jSChsns6+WaiPYOaxcuxAV0mjyI5LDJ\n\t1pc+YKBx+jGszvaAEOTn7QbENySyIrrsvTh3odRIjDpkZfcL4B+7KMzXRYBDm3g85/SQ\n\tsfI9bxdk/aJ7AGVyiWajX2C7o8vOjvFgzQKSJr9mA9lwaQEDlrpiAkBFkKPSelKOkdHJ\n\tYzawiyXI0/ZLR/zd1q0VpOw9N2e238tlG9eJdAiV8mXy3zikbQeMFkC4MrJIJ5gMr9rI\n\tkWQA+U9eKMwlzMwRxRmQ8T3VyM27C7xEgWMkqhLFx4ANhTro179ThMg1EemWBx7niEEm\n\tfn+g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=0ZvNILQsT/lrTa1SsqTTVdBjGKFPz1KeBl7JphindJQ=;\n\tb=XIGm1xhthNXI5XpbuRAIt83s1/CAIJJ2P4RkaXw5YOCambzxSZPY+T0KbO09PUiwDy\n\tozP9KYqt5u7aeU87/laLJFH7IutRywlsF68dlQ4psF1P6EJIN7tV0qIWvRaOK4RZDXF5\n\tu/XxF6r8WW19+b+eIs55O431dHxrsCntt2VJOMeh6NslcQgyVleU0gWftIAc+B9EcgJv\n\tcHf+WiHLlTXUiNCcxXqTQlIXOKwvVGXrZVG63HuDe+RR4koJTjenGL4f4qYJfLQBrZGC\n\tbBDwaHLC/laQPktejDZU1RjZ6djh+1XycXUoAtbIUhj59qkxXJGXEv6ZvkOqg9chPWl/\n\tvOEA==", "X-Gm-Message-State": "AOAM532avDF5Bj7xqX3ByZnoswJo69VgGkMploBuuwaOhraJvXGCwsRn\n\tQlbsttCpSO0vaGVCW6jRqH1QYDH3fa1XNw==", "X-Google-Smtp-Source": "ABdhPJzYkngW4Mq30toJwbQzFbs+7+h7Y9SVRvCJ/F7G+mqvmAr8LLrVwKsV8cbGtYv2DLi6S/Molw==", "X-Received": "by 2002:a05:6000:124c:: with SMTP id\n\tj12mr4455843wrx.83.1595236413431; \n\tMon, 20 Jul 2020 02:13:33 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 20 Jul 2020 10:13:09 +0100", "Message-Id": "<20200720091311.805092-8-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200720091311.805092-1-naush@raspberrypi.com>", "References": "<20200720091311.805092-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 7/9] libcamera: pipeline: raspberrypi:\n\tFix bug in passing configuration to IPA", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The counter was not incremented, so multiple streams would only pass the\nlast stream config to the IPA.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex dbc22521..c28fe997 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -976,14 +976,14 @@ int RPiCameraData::configureIPA()\n \tunicam_[Unicam::Image].dev()->getFormat(&sensorFormat);\n \t/* Inform IPA of stream configuration and sensor controls. */\n \tunsigned int i = 0;\n-\tfor (auto const &stream : isp_) {\n+\tfor (auto const &stream : isp_)\n \t\tif (stream.isExternal()) {\n-\t\t\tstreamConfig[i] = {\n+\t\t\tstreamConfig[i++] = {\n \t\t\t\t.pixelFormat = stream.configuration().pixelFormat,\n \t\t\t\t.size = stream.configuration().size\n \t\t\t};\n \t\t}\n-\t}\n+\n \tentityControls.emplace(0, unicam_[Unicam::Image].dev()->controls());\n \tentityControls.emplace(1, isp_[Isp::Input].dev()->controls());\n \n", "prefixes": [ "libcamera-devel", "v4", "7/9" ] }