Patch Detail
Show a patch.
GET /api/patches/8867/?format=api
{ "id": 8867, "url": "https://patchwork.libcamera.org/api/patches/8867/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8867/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200720091311.805092-6-naush@raspberrypi.com>", "date": "2020-07-20T09:13:07", "name": "[libcamera-devel,v4,5/9] libcamera: pipeline: raspberrypi: Remove const qualifier from RPiStream", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d3a8251a2f5e74688c84cc50425133bda0b6e516", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8867/mbox/", "series": [ { "id": 1117, "url": "https://patchwork.libcamera.org/api/series/1117/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1117", "date": "2020-07-20T09:13:02", "name": "Zero-copy RAW stream work", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1117/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8867/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8867/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9B45EBD792\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 20 Jul 2020 09:13:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4A617605B2;\n\tMon, 20 Jul 2020 11:13:34 +0200 (CEST)", "from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n\t[IPv6:2a00:1450:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 12093605BB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 Jul 2020 11:13:32 +0200 (CEST)", "by mail-wm1-x32f.google.com with SMTP id 17so24394775wmo.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 Jul 2020 02:13:32 -0700 (PDT)", "from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tu1sm38137185wrb.78.2020.07.20.02.13.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 20 Jul 2020 02:13:30 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"HC8r2PZZ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=mlnlsKaKP2HEw7g4p82W82aRH/V0hITuA/ZGL2qH+mQ=;\n\tb=HC8r2PZZyjvzHjdYfqMEWR+IlZjy8pAerCNwpwhfBLjadxiodLBymR2CXJ4xUHf+q9\n\tgz4b4IggV0/HUznX2/ZV7xXaPus2HVywCZM6g3FDxkLB0fSxprPOgtlJfGHAUVxWl+VQ\n\tsfUEkrgWgy/J3ZT62YIwmWtA330u3IJluI0DmdblqmCutZOPzls23fAUW/Stm1jhzngR\n\tg1gboEXVLl2PlAgYt0j0JUoGEoR+ItWy32etkk+6vvxxeHemdbNcDL8d5Xfxh5FE6ksV\n\tH3ekQMoLZo4lMzojeOQ7EGiFZRdT6rCXz/ECAD8gSdeKjhQj6WnI5+fm3NYA1BpcQbq7\n\tYuSQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=mlnlsKaKP2HEw7g4p82W82aRH/V0hITuA/ZGL2qH+mQ=;\n\tb=Mb+o0Q/YATYYi5Bm0xK1Srq2siNC5jCHLBANi4S9yQyRUaXhODepSlhFyroExoWVFG\n\tUJHhAfW3WnGw8hxGNzkuMxGyZ+sPbCzXEfaDr8Nl0SYnrRPVVcHldjvff2mecD9uZPYW\n\trlYdXWcbAJLu3zez7WYjOIzBBhYh7851Ny+CpGxa4zIHafH6M0b9gmiQV/cTsudMMoOQ\n\tYc4sNf1xYlEGeVnbW3AFddgjx59QGWYCMLECNo6t08O9RCvaQCuG0JZioneL5yjxv5ga\n\tcaADZfCLcMR0oJ7Eoru6MtwLNRWyLt+bDCF4dhcc1+LhgNKVYaQmKG3DSsSfRKLP1RmL\n\txMIA==", "X-Gm-Message-State": "AOAM531AcPTqvRxdFz4oUXOsy9HDcDoBcwsN+yz7oPBlEotisfgOwWa9\n\tak0NJH2OKMEgNbYQj01bMddV1kKotxybdw==", "X-Google-Smtp-Source": "ABdhPJzET71JUjMTHS1JHY5Nfvafj7xyfFQcq1HvqRloHYQedmaTniNGNMu9ySIBUBVW6c+Ev1611A==", "X-Received": "by 2002:a1c:f219:: with SMTP id s25mr19938168wmc.2.1595236411517;\n\tMon, 20 Jul 2020 02:13:31 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 20 Jul 2020 10:13:07 +0100", "Message-Id": "<20200720091311.805092-6-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200720091311.805092-1-naush@raspberrypi.com>", "References": "<20200720091311.805092-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 5/9] libcamera: pipeline: raspberrypi:\n\tRemove const qualifier from RPiStream", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "For the zero-copy RAW capture feature, the RPiStream will have to be\nmodified. Remove the const qualifier in anticipation of the future\ncommits for this feature.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 486345fa..8f6a999b 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -150,7 +150,7 @@ public:\n \tvoid ispOutputDequeue(FrameBuffer *buffer);\n \n \tvoid clearIncompleteRequests();\n-\tvoid handleStreamBuffer(FrameBuffer *buffer, const RPi::RPiStream *stream);\n+\tvoid handleStreamBuffer(FrameBuffer *buffer, RPi::RPiStream *stream);\n \tvoid handleState();\n \n \tCameraSensor *sensor_;\n@@ -1105,12 +1105,12 @@ done:\n \n void RPiCameraData::unicamBufferDequeue(FrameBuffer *buffer)\n {\n-\tconst RPi::RPiStream *stream = nullptr;\n+\tRPi::RPiStream *stream = nullptr;\n \n \tif (state_ == State::Stopped)\n \t\treturn;\n \n-\tfor (RPi::RPiStream const &s : unicam_) {\n+\tfor (RPi::RPiStream &s : unicam_) {\n \t\tif (s.findFrameBuffer(buffer)) {\n \t\t\tstream = &s;\n \t\t\tbreak;\n@@ -1171,12 +1171,12 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer)\n \n void RPiCameraData::ispOutputDequeue(FrameBuffer *buffer)\n {\n-\tconst RPi::RPiStream *stream = nullptr;\n+\tRPi::RPiStream *stream = nullptr;\n \n \tif (state_ == State::Stopped)\n \t\treturn;\n \n-\tfor (RPi::RPiStream const &s : isp_) {\n+\tfor (RPi::RPiStream &s : isp_) {\n \t\tif (s.findFrameBuffer(buffer)) {\n \t\t\tstream = &s;\n \t\t\tbreak;\n@@ -1257,7 +1257,7 @@ void RPiCameraData::clearIncompleteRequests()\n \t}\n }\n \n-void RPiCameraData::handleStreamBuffer(FrameBuffer *buffer, const RPi::RPiStream *stream)\n+void RPiCameraData::handleStreamBuffer(FrameBuffer *buffer, RPi::RPiStream *stream)\n {\n \tif (stream->isExternal()) {\n \t\tif (!dropFrameCount_) {\n", "prefixes": [ "libcamera-devel", "v4", "5/9" ] }