Patch Detail
Show a patch.
GET /api/patches/8861/?format=api
{ "id": 8861, "url": "https://patchwork.libcamera.org/api/patches/8861/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8861/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200718143428.1060441-3-niklas.soderlund@ragnatech.se>", "date": "2020-07-18T14:34:28", "name": "[libcamera-devel,2/2] libcamera: Add support for RGB565 format", "commit_ref": "d9295552b17c72c57357e901cd256bcf66528233", "pull_url": null, "state": "accepted", "archived": false, "hash": "b346dd6183731a96deea3be1dc300a28e9c822ce", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8861/mbox/", "series": [ { "id": 1116, "url": "https://patchwork.libcamera.org/api/series/1116/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1116", "date": "2020-07-18T14:34:26", "name": "libcamera: Add support for YVU420 and RGB565", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1116/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8861/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8861/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 597EAC2E67\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 18 Jul 2020 14:34:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3DF15605C6;\n\tSat, 18 Jul 2020 16:34:46 +0200 (CEST)", "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5880060544\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 18 Jul 2020 16:34:43 +0200 (CEST)", "from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid d17a15d8-c903-11ea-8fb8-005056917f90;\n\tSat, 18 Jul 2020 16:34:42 +0200 (CEST)" ], "X-Halon-ID": "d17a15d8-c903-11ea-8fb8-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 18 Jul 2020 16:34:28 +0200", "Message-Id": "<20200718143428.1060441-3-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200718143428.1060441-1-niklas.soderlund@ragnatech.se>", "References": "<20200718143428.1060441-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 2/2] libcamera: Add support for RGB565\n\tformat", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add support for RGB565 format.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/formats.cpp | 10 ++++++++++\n src/libcamera/formats.yaml | 3 +++\n src/libcamera/v4l2_pixelformat.cpp | 1 +\n 3 files changed, 14 insertions(+)", "diff": "diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 8f9bdafe821b2e69..af3996c954ae1457 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -233,6 +233,16 @@ const PixelFormatInfo pixelFormatInfoInvalid{};\n \n const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n \t/* RGB formats. */\n+\t{ formats::RGB565, {\n+\t\t.name = \"RGB565\",\n+\t\t.format = formats::RGB565,\n+\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_RGB565),\n+\t\t.bitsPerPixel = 16,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n+\t\t.packed = false,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n \t{ formats::BGR888, {\n \t\t.name = \"BGR888\",\n \t\t.format = formats::BGR888,\ndiff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml\nindex 6b5f084bb2e4e970..3a69c05fcc04fb93 100644\n--- a/src/libcamera/formats.yaml\n+++ b/src/libcamera/formats.yaml\n@@ -8,6 +8,9 @@ formats:\n - R8:\n fourcc: DRM_FORMAT_R8\n \n+ - RGB565:\n+ fourcc: DRM_FORMAT_RGB565\n+\n - RGB888:\n fourcc: DRM_FORMAT_RGB888\n - BGR888:\ndiff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\nindex 1609f8bb6370fa65..9799d389e20b358d 100644\n--- a/src/libcamera/v4l2_pixelformat.cpp\n+++ b/src/libcamera/v4l2_pixelformat.cpp\n@@ -45,6 +45,7 @@ namespace {\n \n const std::map<V4L2PixelFormat, PixelFormat> vpf2pf{\n \t/* RGB formats. */\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB565), formats::RGB565 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB24), formats::BGR888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_BGR24), formats::RGB888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBA32), formats::ABGR8888 },\n", "prefixes": [ "libcamera-devel", "2/2" ] }