Patch Detail
Show a patch.
GET /api/patches/8843/?format=api
{ "id": 8843, "url": "https://patchwork.libcamera.org/api/patches/8843/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8843/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200717085410.732308-6-naush@raspberrypi.com>", "date": "2020-07-17T08:54:05", "name": "[libcamera-devel,v3,05/10] libcamera: pipeline: raspberrypi: Remove const qualifier from RPiStream", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d3a8251a2f5e74688c84cc50425133bda0b6e516", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8843/mbox/", "series": [ { "id": 1114, "url": "https://patchwork.libcamera.org/api/series/1114/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1114", "date": "2020-07-17T08:54:00", "name": "Zero-copy RAW stream work", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1114/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8843/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8843/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A118EC0109\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 17 Jul 2020 08:54:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6D5E860546;\n\tFri, 17 Jul 2020 10:54:24 +0200 (CEST)", "from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com\n\t[IPv6:2a00:1450:4864:20::42a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2BC2C6053B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 17 Jul 2020 10:54:20 +0200 (CEST)", "by mail-wr1-x42a.google.com with SMTP id z15so10142816wrl.8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 17 Jul 2020 01:54:20 -0700 (PDT)", "from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\t92sm14582375wrr.96.2020.07.17.01.54.18\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 17 Jul 2020 01:54:18 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"ZD0wpdhb\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=Tdh1WQNfL/rgxBl0g9CSC/ICD3ZSxZ6i1j3jpF6dEvQ=;\n\tb=ZD0wpdhbGQ1JGB7TS5dDRIgLI78jR7QIuerxgEUx2t0Y8ykSGSWdREgPdrFmOwUQPG\n\tt7fQq6PrK+XKy1AEjFJ5wk7hnifHlYu+Z7iI6tKv/mBlj8hQjplHffh5hpSvijXstcLM\n\tH2q+SwYz3xX72we6pW+rbc2wl5O27YPJfpYOkO4acB0s5+Ij2Xrl/psO76586Ews+rR4\n\tSqvvMSObbFsd3FTCg2Ag9uObcHwV4+4FqiDGiGUpKSht72QmBH03OQX1lsISowsM7Hu3\n\tTwxq8OInKIN0nK2+q2uCby3+VXB9f0XCT3yh9wFkJEh7Y30qCTuJMSTecbcHBpVJ4SO7\n\tMhwg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=Tdh1WQNfL/rgxBl0g9CSC/ICD3ZSxZ6i1j3jpF6dEvQ=;\n\tb=s2WS0yNuXqFNhfUXD09Xr6yA2rKYsKiD4rARfAyK1HR5TW12pUMXEUMkSy0Jutifp0\n\tYHlEvDsxOYlNHiDdUP048czeufgIeCfZsgHeU4+/E8/AxraF0J18L1kxSYramg9zRk+V\n\ta/gi5K4Y+zY0IOB8pghXNQU4n8/eKzh6WCV2efwz6C0utgXeC5LOfBgzFKcK5GH652hB\n\t4H7jlAU/gYpRUywHHct7OmneKjzCy3fhbDTPCeTO3CCEagR+kueAHCbEE0TjVNjm8MRA\n\tfl0h/+X2qiuXzH8RKy81Y5BqhZdcfBJukJ+49rn3B+GCbv82XlM4sxnBIOmUmGhftXHr\n\t5dTw==", "X-Gm-Message-State": "AOAM531315uRcFzlPuXFKcC25P+mSPzOl6+q5ijyzJVErnXYYBH+sSNw\n\tLkgLz2Q1pva6GiWpjSWrpY+vxHhoYgI=", "X-Google-Smtp-Source": "ABdhPJxseFHz8hzIOo3WDNzQZyHejlcbqg0QY1Zmr39o5WAXFReTA4acc/aKoPv3xkovAF/kW5QNVA==", "X-Received": "by 2002:adf:f54d:: with SMTP id\n\tj13mr8834197wrp.427.1594976059634; \n\tFri, 17 Jul 2020 01:54:19 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 17 Jul 2020 09:54:05 +0100", "Message-Id": "<20200717085410.732308-6-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200717085410.732308-1-naush@raspberrypi.com>", "References": "<20200717085410.732308-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 05/10] libcamera: pipeline:\n\traspberrypi: Remove const qualifier from RPiStream", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "For the zero-copy RAW capture feature, the RPiStream will have to be\nmodified. Remove the const qualifier in anticipation of the future\ncommits for this feature.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex c324efc1..ca8434a3 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -162,7 +162,7 @@ public:\n \tvoid ispOutputDequeue(FrameBuffer *buffer);\n \n \tvoid clearIncompleteRequests();\n-\tvoid handleStreamBuffer(FrameBuffer *buffer, const RPi::RPiStream *stream);\n+\tvoid handleStreamBuffer(FrameBuffer *buffer, RPi::RPiStream *stream);\n \tvoid handleState();\n \n \tCameraSensor *sensor_;\n@@ -1128,12 +1128,12 @@ done:\n \n void RPiCameraData::unicamBufferDequeue(FrameBuffer *buffer)\n {\n-\tconst RPi::RPiStream *stream = nullptr;\n+\tRPi::RPiStream *stream = nullptr;\n \n \tif (state_ == State::Stopped)\n \t\treturn;\n \n-\tfor (RPi::RPiStream const &s : unicam_) {\n+\tfor (RPi::RPiStream &s : unicam_) {\n \t\tif (s.findFrameBuffer(buffer)) {\n \t\t\tstream = &s;\n \t\t\tbreak;\n@@ -1194,12 +1194,12 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer)\n \n void RPiCameraData::ispOutputDequeue(FrameBuffer *buffer)\n {\n-\tconst RPi::RPiStream *stream = nullptr;\n+\tRPi::RPiStream *stream = nullptr;\n \n \tif (state_ == State::Stopped)\n \t\treturn;\n \n-\tfor (RPi::RPiStream const &s : isp_) {\n+\tfor (RPi::RPiStream &s : isp_) {\n \t\tif (s.findFrameBuffer(buffer)) {\n \t\t\tstream = &s;\n \t\t\tbreak;\n@@ -1280,7 +1280,7 @@ void RPiCameraData::clearIncompleteRequests()\n \t}\n }\n \n-void RPiCameraData::handleStreamBuffer(FrameBuffer *buffer, const RPi::RPiStream *stream)\n+void RPiCameraData::handleStreamBuffer(FrameBuffer *buffer, RPi::RPiStream *stream)\n {\n \tif (stream->isExternal()) {\n \t\tif (!dropFrameCount_) {\n", "prefixes": [ "libcamera-devel", "v3", "05/10" ] }