Patch Detail
Show a patch.
GET /api/patches/8828/?format=api
{ "id": 8828, "url": "https://patchwork.libcamera.org/api/patches/8828/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8828/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200715140703.566298-6-naush@raspberrypi.com>", "date": "2020-07-15T14:06:58", "name": "[libcamera-devel,v2,05/10] libcamera: pipeline: raspberrypi: Remove const qualifier from RPiStream", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d3a8251a2f5e74688c84cc50425133bda0b6e516", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8828/mbox/", "series": [ { "id": 1111, "url": "https://patchwork.libcamera.org/api/series/1111/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1111", "date": "2020-07-15T14:06:53", "name": "Zero-copy RAW stream work", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1111/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8828/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8828/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4BC36BD790\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 15 Jul 2020 14:07:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 180C16093A;\n\tWed, 15 Jul 2020 16:07:21 +0200 (CEST)", "from mail-wm1-x332.google.com (mail-wm1-x332.google.com\n\t[IPv6:2a00:1450:4864:20::332])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 152BA6093A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 15 Jul 2020 16:07:19 +0200 (CEST)", "by mail-wm1-x332.google.com with SMTP id j18so5744798wmi.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 15 Jul 2020 07:07:19 -0700 (PDT)", "from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tl67sm4195339wml.13.2020.07.15.07.07.15\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 15 Jul 2020 07:07:15 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"rP3jMW6i\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=NC23Yh0Jo9Xk9clV400Nvp3F4rLVrpwh1znNskXO+qY=;\n\tb=rP3jMW6i1C07YmcXRE+euAic5pps2SF+Uu661PAik0Ifdo9/kUOH2Dw/SidQJeOfGS\n\tvANVvN4wePi2NCApWrA0Ge/mgUzZ7bcQoopkHcy+04tHEV9bzZjrSAu1IppF8ltSZqAw\n\tvjH8yXsTijBSnzxTW4gpig/CNCx5rU8N8m9+abvEq9df0P+kDDLN4WevsOv8aQMN6hCM\n\tOd7g2/Fd7B96k1aRXZxMjeH4RD7QZzntnkS79SHQhg0MGwKSHQUxJwqaXmUotnpEQWOq\n\tQw0yiZ4AptaA93++VeFfxSfy0L4cVfQm3OkzJij/+CNqyawUlbjweChDnccmsZ0iW7A4\n\tV7VA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=NC23Yh0Jo9Xk9clV400Nvp3F4rLVrpwh1znNskXO+qY=;\n\tb=lkldCZ1Es62ccrFLU5RogWA0V7W/csvU3CyAfkX80xTYYmqsrS8fesvMR11XYAc//4\n\t/rmtbOVgnasUKsTeURoRYpvIPXqJYjETRA15BN2cam1yonF9ahX4Pyi37qZIT3PUaEeA\n\tkjtsarEYlUY4WAMEd/z1jXDeXKqRAKOGH+ZE3xa4i8oAtDyAtH6W1nJK+CXgLIaYY1Qf\n\tyHBzMwLErzfFn/zazMHNssLdvshAqjG+Gy44elPcQU7WKJLyuq1BZVCfB0oGDqzjf60+\n\t9U9PIAVmzbUpqOHEmD4laXX1BxTyuAqgpIPcRNv3THPvJX1UX4+h2mp24p442nW1qCPE\n\tmsww==", "X-Gm-Message-State": "AOAM533GKo+bCWd32QFi2ZAR5jf17NSLde1W0fZaVGOeQyP2+bhtQvNb\n\tf8dPLG6IyEtb5PeMxhsVqB/HuC3WfbM=", "X-Google-Smtp-Source": "ABdhPJxC+XnUt13GydW9lAm5uNGV+h6vriV9pnm9Ch51RWwOKWbWCzRnOofDzwydPuGJFZccb111Cw==", "X-Received": "by 2002:a1c:a90d:: with SMTP id\n\ts13mr8466186wme.184.1594822037531; \n\tWed, 15 Jul 2020 07:07:17 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 15 Jul 2020 15:06:58 +0100", "Message-Id": "<20200715140703.566298-6-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200715140703.566298-1-naush@raspberrypi.com>", "References": "<20200715140703.566298-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 05/10] libcamera: pipeline:\n\traspberrypi: Remove const qualifier from RPiStream", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "For the zero-copy RAW capture feature, the RPiStream will have to be\nmodified. Remove the const qualifier in anticipation of the future\ncommits for this feature.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex a613ce65..2f4255a4 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -163,7 +163,7 @@ public:\n \tvoid ispOutputDequeue(FrameBuffer *buffer);\n \n \tvoid clearIncompleteRequests();\n-\tvoid handleStreamBuffer(FrameBuffer *buffer, const RPi::RPiStream *stream);\n+\tvoid handleStreamBuffer(FrameBuffer *buffer, RPi::RPiStream *stream);\n \tvoid handleState();\n \n \tCameraSensor *sensor_;\n@@ -1120,12 +1120,12 @@ done:\n \n void RPiCameraData::unicamBufferDequeue(FrameBuffer *buffer)\n {\n-\tconst RPi::RPiStream *stream = nullptr;\n+\tRPi::RPiStream *stream = nullptr;\n \n \tif (state_ == State::Stopped)\n \t\treturn;\n \n-\tfor (RPi::RPiStream const &s : unicam_) {\n+\tfor (RPi::RPiStream &s : unicam_) {\n \t\tif (s.findFrameBuffer(buffer)) {\n \t\t\tstream = &s;\n \t\t\tbreak;\n@@ -1186,12 +1186,12 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer)\n \n void RPiCameraData::ispOutputDequeue(FrameBuffer *buffer)\n {\n-\tconst RPi::RPiStream *stream = nullptr;\n+\tRPi::RPiStream *stream = nullptr;\n \n \tif (state_ == State::Stopped)\n \t\treturn;\n \n-\tfor (RPi::RPiStream const &s : isp_) {\n+\tfor (RPi::RPiStream &s : isp_) {\n \t\tif (s.findFrameBuffer(buffer)) {\n \t\t\tstream = &s;\n \t\t\tbreak;\n@@ -1272,7 +1272,7 @@ void RPiCameraData::clearIncompleteRequests()\n \t}\n }\n \n-void RPiCameraData::handleStreamBuffer(FrameBuffer *buffer, const RPi::RPiStream *stream)\n+void RPiCameraData::handleStreamBuffer(FrameBuffer *buffer, RPi::RPiStream *stream)\n {\n \tif (stream->isExternal()) {\n \t\tif (!dropFrameCount_) {\n", "prefixes": [ "libcamera-devel", "v2", "05/10" ] }