Patch Detail
Show a patch.
GET /api/patches/8816/?format=api
{ "id": 8816, "url": "https://patchwork.libcamera.org/api/patches/8816/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8816/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200715011833.24600-11-laurent.pinchart@ideasonboard.com>", "date": "2020-07-15T01:18:30", "name": "[libcamera-devel,v2,10/13] media: i2c: imx477: Parse and register properties", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "32b492e75e3e58c85397f952efae31d885e03d1d", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": { "id": 14, "url": "https://patchwork.libcamera.org/api/users/14/?format=api", "username": "pinchartl", "first_name": "Laurent", "last_name": "Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/8816/mbox/", "series": [ { "id": 1108, "url": "https://patchwork.libcamera.org/api/series/1108/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1108", "date": "2020-07-15T01:18:21", "name": "raspberrypi: Report sensor orientation through DT", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1108/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8816/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8816/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 56E52BD790\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 15 Jul 2020 01:18:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2583160929;\n\tWed, 15 Jul 2020 03:18:56 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 517AF60930\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 15 Jul 2020 03:18:49 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E53081254;\n\tWed, 15 Jul 2020 03:18:48 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"C+KN7LgE\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594775929;\n\tbh=aRV+CHxXX69bDArlpfjq4ExyZPdep14xaqOg2awowvs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=C+KN7LgEP3XJOmoZII2gyxm4OCe1wnzrkCt6EV0GykrhjUHM3U4WlSUUlMEzUATOG\n\t6M7/BnD0roKvwkpiPWqRVeN0X6Sv+38DS1muo+A83w6Qu887PTM5sXC+FXZWgxmloQ\n\t+iDgUixUZlqbcyGQfR0RtlpYjfDe8Ye2ATH3mgVs=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "Dave Stevenson <dave.stevenson@raspberrypi.com>", "Date": "Wed, 15 Jul 2020 04:18:30 +0300", "Message-Id": "<20200715011833.24600-11-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200715011833.24600-1-laurent.pinchart@ideasonboard.com>", "References": "<20200715011833.24600-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 10/13] media: i2c: imx477: Parse and\n\tregister properties", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "libcamera-devel@lists.libcamera.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Parse device properties and register controls for them using the V4L2\nfwnode properties helpers.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n drivers/media/i2c/imx477.c | 12 +++++++++++-\n 1 file changed, 11 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/media/i2c/imx477.c b/drivers/media/i2c/imx477.c\nindex e42a8633087d..3fbb173fa079 100644\n--- a/drivers/media/i2c/imx477.c\n+++ b/drivers/media/i2c/imx477.c\n@@ -1957,11 +1957,12 @@ static int imx477_init_controls(struct imx477 *imx477)\n {\n \tstruct v4l2_ctrl_handler *ctrl_hdlr;\n \tstruct i2c_client *client = v4l2_get_subdevdata(&imx477->sd);\n+\tstruct v4l2_fwnode_device_properties props;\n \tunsigned int i;\n \tint ret;\n \n \tctrl_hdlr = &imx477->ctrl_handler;\n-\tret = v4l2_ctrl_handler_init(ctrl_hdlr, 14);\n+\tret = v4l2_ctrl_handler_init(ctrl_hdlr, 16);\n \tif (ret)\n \t\treturn ret;\n \n@@ -2045,6 +2046,15 @@ static int imx477_init_controls(struct imx477 *imx477)\n \t\tgoto error;\n \t}\n \n+\tret = v4l2_fwnode_device_parse(&client->dev, &props);\n+\tif (ret)\n+\t\tgoto error;\n+\n+\tret = v4l2_ctrl_new_fwnode_properties(ctrl_hdlr, &imx477_ctrl_ops,\n+\t\t\t\t\t &props);\n+\tif (ret)\n+\t\tgoto error;\n+\n \timx477->sd.ctrl_handler = ctrl_hdlr;\n \n \t/* Setup exposure and frame/line length limits. */\n", "prefixes": [ "libcamera-devel", "v2", "10/13" ] }