Patch Detail
Show a patch.
GET /api/patches/8791/?format=api
{ "id": 8791, "url": "https://patchwork.libcamera.org/api/patches/8791/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8791/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200714104212.48683-17-jacopo@jmondi.org>", "date": "2020-07-14T10:42:08", "name": "[libcamera-devel,16/20] libcamera: ipu3: Remove camera_ from IPU3CameraConfiguration", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "77b4dec9dd99b549057482249e2db2eefbacc482", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8791/mbox/", "series": [ { "id": 1104, "url": "https://patchwork.libcamera.org/api/series/1104/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1104", "date": "2020-07-14T10:41:52", "name": "libcamera: ipu3: Rework pipe configuration", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1104/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8791/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8791/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 099C5BD792\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 14 Jul 2020 10:39:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BB06F6087E;\n\tTue, 14 Jul 2020 12:39:02 +0200 (CEST)", "from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 586596090F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Jul 2020 12:38:59 +0200 (CEST)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id C08ED240013;\n\tTue, 14 Jul 2020 10:38:58 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 14 Jul 2020 12:42:08 +0200", "Message-Id": "<20200714104212.48683-17-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200714104212.48683-1-jacopo@jmondi.org>", "References": "<20200714104212.48683-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 16/20] libcamera: ipu3: Remove camera_\n\tfrom IPU3CameraConfiguration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The IPU3CameraConfiguration::camera_ shared pointer is not used.\nRemove it.\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 9 +++------\n 1 file changed, 3 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 2d8b3c501294..804d68d47c92 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -62,7 +62,7 @@ public:\n class IPU3CameraConfiguration : public CameraConfiguration\n {\n public:\n-\tIPU3CameraConfiguration(Camera *camera, IPU3CameraData *data);\n+\tIPU3CameraConfiguration(IPU3CameraData *data);\n \n \tStatus validate() override;\n \n@@ -74,7 +74,6 @@ private:\n \t * corresponding Camera instance is valid. In order to borrow a\n \t * reference to the camera data, store a new reference to the camera.\n \t */\n-\tstd::shared_ptr<Camera> camera_;\n \tconst IPU3CameraData *data_;\n \n \tStreamConfiguration cio2Configuration_;\n@@ -124,11 +123,9 @@ private:\n \tMediaDevice *imguMediaDev_;\n };\n \n-IPU3CameraConfiguration::IPU3CameraConfiguration(Camera *camera,\n-\t\t\t\t\t\t IPU3CameraData *data)\n+IPU3CameraConfiguration::IPU3CameraConfiguration(IPU3CameraData *data)\n \t: CameraConfiguration()\n {\n-\tcamera_ = camera->shared_from_this();\n \tdata_ = data;\n }\n \n@@ -296,7 +293,7 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n \t\t\t\t\t\t\t\tconst StreamRoles &roles)\n {\n \tIPU3CameraData *data = cameraData(camera);\n-\tIPU3CameraConfiguration *config = new IPU3CameraConfiguration(camera, data);\n+\tIPU3CameraConfiguration *config = new IPU3CameraConfiguration(data);\n \n \tif (roles.empty())\n \t\treturn config;\n", "prefixes": [ "libcamera-devel", "16/20" ] }