Patch Detail
Show a patch.
GET /api/patches/8768/?format=api
{ "id": 8768, "url": "https://patchwork.libcamera.org/api/patches/8768/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8768/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200713132451.2944673-8-kieran.bingham@ideasonboard.com>", "date": "2020-07-13T13:24:49", "name": "[libcamera-devel,7/9] libcamera: pipeline: vivid: Queue requeusts", "commit_ref": null, "pull_url": null, "state": "awaiting-upstream", "archived": false, "hash": "515c922414b1236ace261085c6c932ac11c69e37", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8768/mbox/", "series": [ { "id": 1102, "url": "https://patchwork.libcamera.org/api/series/1102/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1102", "date": "2020-07-13T13:24:42", "name": "Introduce a new PipelineHandler", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1102/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8768/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8768/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 61AF4BD792\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 13 Jul 2020 13:25:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2B8816073F;\n\tMon, 13 Jul 2020 15:25:04 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 02C67605A9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Jul 2020 15:24:58 +0200 (CEST)", "from Q.local (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net\n\t[86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 83250C9;\n\tMon, 13 Jul 2020 15:24:58 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jRyBEv0l\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594646698;\n\tbh=FbRWsciGPZY8ETGVLpH4mHsCr8sdLC6Oh1CXcxMmp/M=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jRyBEv0lD45sKv+TkJ3tmnIN/OyTW4YZSigHQ3vuz3vlrOloi38xePYZt05JWmDkO\n\tHpb0G3/Ow0Uzt1Ws0+/gBqpQSVA8sgEEPoxCA6oBN3LZ1yWKFysdisTCJVB5AnPtz6\n\t/tiehav0mOJpgoiEQsqS3o/KIXNPDbW5u3whwEjo=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Mon, 13 Jul 2020 14:24:49 +0100", "Message-Id": "<20200713132451.2944673-8-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200713132451.2944673-1-kieran.bingham@ideasonboard.com>", "References": "<20200713132451.2944673-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 7/9] libcamera: pipeline: vivid: Queue\n\trequeusts", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Chris Ward <chris@gregariousmammal.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When a reqeust is given to a pipeline handler, it must parse the request\nand identify what actions the pipeline handler should take to enact on hardware.\n\nIn the case of the VIVID pipeline handler, we identify the buffer from the only\nsupported stream, and queue it to the video capture device.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/vivid/vivid.cpp | 15 ++++++++++++++-\n 1 file changed, 14 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/vivid/vivid.cpp b/src/libcamera/pipeline/vivid/vivid.cpp\nindex 1a945a744055..4362e73f49a5 100644\n--- a/src/libcamera/pipeline/vivid/vivid.cpp\n+++ b/src/libcamera/pipeline/vivid/vivid.cpp\n@@ -210,7 +210,20 @@ void PipelineHandlerVivid::stop(Camera *camera)\n \n int PipelineHandlerVivid::queueRequestDevice(Camera *camera, Request *request)\n {\n-\treturn -1;\n+\tVividCameraData *data = cameraData(camera);\n+\tFrameBuffer *buffer = request->findBuffer(&data->stream_);\n+\tif (!buffer) {\n+\t\tLOG(VIVID, Error)\n+\t\t\t<< \"Attempt to queue request with invalid stream\";\n+\n+\t\treturn -ENOENT;\n+\t}\n+\n+\tint ret = data->video_->queueBuffer(buffer);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\n+\treturn 0;\n }\n \n bool PipelineHandlerVivid::match(DeviceEnumerator *enumerator)\n", "prefixes": [ "libcamera-devel", "7/9" ] }