Patch Detail
Show a patch.
GET /api/patches/8763/?format=api
{ "id": 8763, "url": "https://patchwork.libcamera.org/api/patches/8763/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8763/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200713132451.2944673-3-kieran.bingham@ideasonboard.com>", "date": "2020-07-13T13:24:44", "name": "[libcamera-devel,2/9] libcamera: pipeline: vivid: Match device", "commit_ref": null, "pull_url": null, "state": "awaiting-upstream", "archived": false, "hash": "4c1066d84ab8e910c2ffcd0aa117b3cfa2d91033", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8763/mbox/", "series": [ { "id": 1102, "url": "https://patchwork.libcamera.org/api/series/1102/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1102", "date": "2020-07-13T13:24:42", "name": "Introduce a new PipelineHandler", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1102/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8763/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8763/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0CC67BD792\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 13 Jul 2020 13:25:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9450960741;\n\tMon, 13 Jul 2020 15:24:59 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 20864605AE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Jul 2020 15:24:57 +0200 (CEST)", "from Q.local (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net\n\t[86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8D0A39B1;\n\tMon, 13 Jul 2020 15:24:55 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"p/ETJTRN\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594646695;\n\tbh=pK/gzlJCFpILRjqW9+slg2XjWKgH7PRhtU6f5FylbBU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=p/ETJTRNdPhzbkb3fOM3vXPsWy0Sa49bdgv1xytkGwnlmJ2/oxBr+q5J9lzFjwhYr\n\toDKpkHoXxjuLj1qh5gNe9xyAVf9DRoExcEhUoTYPf5wNw743qB3+A6cdepLfyb0SNT\n\t+3m/Fdwhy6XQ6Wn+UoSIMRmXM9bxWjgabjPuKiXU=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Mon, 13 Jul 2020 14:24:44 +0100", "Message-Id": "<20200713132451.2944673-3-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200713132451.2944673-1-kieran.bingham@ideasonboard.com>", "References": "<20200713132451.2944673-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 2/9] libcamera: pipeline: vivid: Match\n\tdevice", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Chris Ward <chris@gregariousmammal.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Verify that we can match on our expected device(s).\n\nUse a temporary debug print to check that the pipeline finds\nour device:\n\n\"\"\"\nLIBCAMERA_LOG_LEVELS=Pipeline,VIVID:0 ./src/cam/cam -l\n<snipped>\n[230:51:10.670503423] [2872877] DEBUG VIVID vivid.cpp:81 Obtained Vivid Device\n\"\"\"\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/vivid/vivid.cpp | 12 +++++++++++-\n 1 file changed, 11 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/vivid/vivid.cpp b/src/libcamera/pipeline/vivid/vivid.cpp\nindex 4418f616fe84..9811f6ef5095 100644\n--- a/src/libcamera/pipeline/vivid/vivid.cpp\n+++ b/src/libcamera/pipeline/vivid/vivid.cpp\n@@ -5,6 +5,7 @@\n * vivid.cpp - Pipeline handler for the vivid capture device\n */\n \n+#include \"libcamera/internal/device_enumerator.h\"\n #include \"libcamera/internal/log.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n \n@@ -70,7 +71,16 @@ int PipelineHandlerVivid::queueRequestDevice(Camera *camera, Request *request)\n \n bool PipelineHandlerVivid::match(DeviceEnumerator *enumerator)\n {\n-\treturn false;\n+\tDeviceMatch dm(\"vivid\");\n+\tdm.add(\"vivid-000-vid-cap\");\n+\n+\tMediaDevice *media = acquireMediaDevice(enumerator, dm);\n+\tif (!media)\n+\t\treturn false;\n+\n+\tLOG(VIVID, Debug) << \"Obtained Vivid Device\";\n+\n+\treturn false; // Prevent infinite loops for now\n }\n \n REGISTER_PIPELINE_HANDLER(PipelineHandlerVivid);\n", "prefixes": [ "libcamera-devel", "2/9" ] }