Patch Detail
Show a patch.
GET /api/patches/8760/?format=api
{ "id": 8760, "url": "https://patchwork.libcamera.org/api/patches/8760/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8760/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200713121122.20000-1-email@uajain.com>", "date": "2020-07-13T12:11:28", "name": "[libcamera-devel] cam: Add --monitor option", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "137dd59cd3d10c0e4b2e07157f645ecf74d9ab74", "submitter": { "id": 1, "url": "https://patchwork.libcamera.org/api/people/1/?format=api", "name": "Umang Jain", "email": "email@uajain.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8760/mbox/", "series": [ { "id": 1101, "url": "https://patchwork.libcamera.org/api/series/1101/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1101", "date": "2020-07-13T12:11:28", "name": "[libcamera-devel] cam: Add --monitor option", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1101/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8760/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8760/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C01E8BD790\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 13 Jul 2020 12:11:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 599E26071A;\n\tMon, 13 Jul 2020 14:11:32 +0200 (CEST)", "from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 53F7C6048F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Jul 2020 14:11:30 +0200 (CEST)", "by filterdrecv-p3las1-7754f7d4cc-kq8b5 with SMTP id\n\tfilterdrecv-p3las1-7754f7d4cc-kq8b5-18-5F0C4F6F-79\n\t2020-07-13 12:11:28.190442971 +0000 UTC m=+1533475.696335492", "from mail.uajain.com (unknown)\n\tby ismtpd0003p1maa1.sendgrid.net (SG) with ESMTP id\n\tEbRUWEykStWa5s5FnifalQ for <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Jul 2020 12:11:27.450 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"Ue7Rbe0c\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:mime-version:to:cc:content-transfer-encoding:\n\tcontent-type;\n\ts=s1; bh=15jb+7tFkcZa+L9Y5uNpbxI4e4HfLzix6fEBPS2l3J0=;\n\tb=Ue7Rbe0cUqUtI4cXGsmqofqxT64OROx3byGh+W7HUowYCLbx94YP6sAyhUYjcHfncoZb\n\tlXviRqmY8+sB7ugoLu03WnePFVxH9ltJaAQUXnWhBz1P38yTCNGaDacAtPWmKutFNmclpq\n\tW0hxzQo/umZm5HD+bLltwrmeUj3xPRZbo=", "From": "Umang Jain <email@uajain.com>", "Date": "Mon, 13 Jul 2020 12:11:28 +0000 (UTC)", "Message-Id": "<20200713121122.20000-1-email@uajain.com>", "Mime-Version": "1.0", "X-SG-EID": "1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcsqq2IL5HKct149ShwfIDnrLpgJ1TpMDnQutF1M0l6THp2ymP3WZ1zH9VkJFi4+F/V8g5RwWjqOagWTmqV3rD5defNtbhIe26loe6l+akpCRWMJ6Z0UHvK/ZaYyEeP940YSimZ/ecJ9nijOueNWP5u1Z7/4bU2pSjI/10SYZIlXdHiuZoFyDv5byoBat88Sd+zwD2WbSSKthZzoZcpRl5yw==", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[libcamera-devel] [PATCH] cam: Add --monitor option", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add --monitor to monitor new hotplug and unplug camera events from\nthe CameraManager.\n\nSigned-off-by: Umang Jain <email@uajain.com>\n---\n src/cam/main.cpp | 24 ++++++++++++++++++++++++\n src/cam/main.h | 1 +\n 2 files changed, 25 insertions(+)", "diff": "diff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex 2512fe9..3488315 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -36,6 +36,8 @@ public:\n \tvoid quit();\n \n private:\n+\tvoid cameraAdded(std::shared_ptr<Camera> cam);\n+\tvoid cameraRemoved(std::shared_ptr<Camera> cam);\n \tint parseOptions(int argc, char *argv[]);\n \tint prepareConfig();\n \tint listControls();\n@@ -115,6 +117,10 @@ int CamApp::init(int argc, char **argv)\n \t\tret = prepareConfig();\n \t\tif (ret)\n \t\t\treturn ret;\n+\t} else if (options_.isSet(OptMonitor)) {\n+\t\tcm_->cameraAdded.connect(this, &CamApp::cameraAdded);\n+\t\tcm_->cameraRemoved.connect(this, &CamApp::cameraRemoved);\n+\t\tstd::cout << \"Monitoring new hotplug and unplug events...\" << std::endl;\n \t}\n \n \tloop_ = new EventLoop(cm_->eventDispatcher());\n@@ -179,6 +185,8 @@ int CamApp::parseOptions(int argc, char *argv[])\n \t\t\t \"list-controls\");\n \tparser.addOption(OptListProperties, OptionNone, \"List cameras properties\",\n \t\t\t \"list-properties\");\n+\tparser.addOption(OptMonitor, OptionNone, \"Monitor for hotplug and unplug camera events\",\n+\t\t\t \"monitor\");\n \n \toptions_ = parser.parse(argc, argv);\n \tif (!options_.valid())\n@@ -293,6 +301,16 @@ int CamApp::infoConfiguration()\n \treturn 0;\n }\n \n+void CamApp::cameraAdded(std::shared_ptr<Camera> cam)\n+{\n+\tstd::cout << \"Camera Added: \" << cam->name() << std::endl;\n+}\n+\n+void CamApp::cameraRemoved(std::shared_ptr<Camera> cam)\n+{\n+\tstd::cout << \"Camera Removed: \" << cam->name() << std::endl;\n+}\n+\n int CamApp::run()\n {\n \tint ret;\n@@ -330,6 +348,12 @@ int CamApp::run()\n \t\treturn capture.run(loop_, options_);\n \t}\n \n+\tif (options_.isSet(OptMonitor)) {\n+\t\tret = loop_->exec();\n+\t\tif (ret)\n+\t\t\tstd::cout << \"Failed to run monitor loop\" << std::endl;\n+\t}\n+\n \treturn 0;\n }\n \ndiff --git a/src/cam/main.h b/src/cam/main.h\nindex 4a130d8..f61d288 100644\n--- a/src/cam/main.h\n+++ b/src/cam/main.h\n@@ -15,6 +15,7 @@ enum {\n \tOptInfo = 'I',\n \tOptList = 'l',\n \tOptListProperties = 'p',\n+\tOptMonitor = 'm',\n \tOptStream = 's',\n \tOptListControls = 256,\n };\n", "prefixes": [ "libcamera-devel" ] }