Patch Detail
Show a patch.
GET /api/patches/8705/?format=api
{ "id": 8705, "url": "https://patchwork.libcamera.org/api/patches/8705/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8705/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200709084128.5316-15-jacopo@jmondi.org>", "date": "2020-07-09T08:41:22", "name": "[libcamera-devel,v2,14/20] libcamera: ipu3: Remove streams from IPU3CameraConfiguration", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a62a1b833d29ee8bac00bbea3e93e6ea34962cc8", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8705/mbox/", "series": [ { "id": 1091, "url": "https://patchwork.libcamera.org/api/series/1091/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1091", "date": "2020-07-09T08:41:08", "name": "libcamera: ipu3: Rework configuration", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1091/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8705/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8705/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 09667BD790\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 9 Jul 2020 08:38:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D5659611B2;\n\tThu, 9 Jul 2020 10:38:19 +0200 (CEST)", "from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 709B6611B9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 9 Jul 2020 10:38:17 +0200 (CEST)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 91AFF100004;\n\tThu, 9 Jul 2020 08:38:16 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 9 Jul 2020 10:41:22 +0200", "Message-Id": "<20200709084128.5316-15-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200709084128.5316-1-jacopo@jmondi.org>", "References": "<20200709084128.5316-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 14/20] libcamera: ipu3: Remove streams\n\tfrom IPU3CameraConfiguration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The IPU3CameraConfiguration::streams_ field was used to keep an\nassociation between the StreamConfiguration and the assigned streams\nbefore CameraConfiguration::setStream() was called at configure() time.\n\nThe stream assignment was based on the order in which elements were\ninserted in the vector, implementing a fragile association between\nstreams and their intended configurations.\n\nAs it is now possible to assign streams at validation time, there is no\nneed to keep that association in place, and the streams_ vector is now\nunused.\n\nRemove it and the associated accessor method from the\nIPU3CameraConfiguration class.\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 9fed6c1e5aa7..1c6627e561c4 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -66,7 +66,6 @@ public:\n \tStatus validate() override;\n \n \tconst StreamConfiguration &cio2Format() const { return cio2Configuration_; };\n-\tconst std::vector<const Stream *> &streams() { return streams_; }\n \n private:\n \t/*\n@@ -78,7 +77,6 @@ private:\n \tIPU3CameraData *data_;\n \n \tStreamConfiguration cio2Configuration_;\n-\tstd::vector<const Stream *> streams_;\n };\n \n class PipelineHandlerIPU3 : public PipelineHandler\n", "prefixes": [ "libcamera-devel", "v2", "14/20" ] }