Patch Detail
Show a patch.
GET /api/patches/8670/?format=api
{ "id": 8670, "url": "https://patchwork.libcamera.org/api/patches/8670/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8670/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200708134417.67747-2-paul.elder@ideasonboard.com>", "date": "2020-07-08T13:43:57", "name": "[libcamera-devel,v4,01/21] libcamera: formats: Add NV24 and NV42, and reorder NV formats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8c55f2e73659e1e90f24959a343264072d794511", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8670/mbox/", "series": [ { "id": 1090, "url": "https://patchwork.libcamera.org/api/series/1090/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1090", "date": "2020-07-08T13:43:56", "name": "Clean up formats in v4l2-compat and pipeline handlers", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1090/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8670/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8670/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA04BBD792\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 8 Jul 2020 13:44:33 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9692161113;\n\tWed, 8 Jul 2020 15:44:33 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1182B60E0D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 8 Jul 2020 15:44:32 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D9A6451B;\n\tWed, 8 Jul 2020 15:44:29 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"m6Gq0ud3\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594215871;\n\tbh=J1mYtl8y9ioXW3oCRqPcuLg6/kvOq/dUW0PJWivI2eY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=m6Gq0ud3d2RnZn1P/uWEQusLy8NcwxoqizE4AJVutwHLehI513tOcRXdq6gvKV5x8\n\tyvN/XUHVj9L3iBiTaDyOdcBqqIDfr+cuReweanKsXzwUXWOJobmGXV/qUWOsOCCuzX\n\txLTajkSZxPl3DxNRrOCXsJOOc72/w0WfUKJXfN5U=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 8 Jul 2020 22:43:57 +0900", "Message-Id": "<20200708134417.67747-2-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200708134417.67747-1-paul.elder@ideasonboard.com>", "References": "<20200708134417.67747-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 01/21] libcamera: formats: Add NV24 and\n\tNV42, and reorder NV formats", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add formats for NV24 and NV42. While at it, reorder the NV formats so\nthat NV12 and NV21 come first, followed by NV16, NV61, NV24, and NV42.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\nNo change in v4\n\nNo change in v3\n---\n src/libcamera/formats.cpp | 36 ++++++++++++++++++++++++++----------\n 1 file changed, 26 insertions(+), 10 deletions(-)", "diff": "diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 436672e..d3b722c 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -256,6 +256,22 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n \t} },\n \n \t/* YUV planar formats. */\n+\t{ formats::NV12, {\n+\t\t.name = \"NV12\",\n+\t\t.format = formats::NV12,\n+\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_NV12),\n+\t\t.bitsPerPixel = 12,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n+\t\t.packed = false,\n+\t} },\n+\t{ formats::NV21, {\n+\t\t.name = \"NV21\",\n+\t\t.format = formats::NV21,\n+\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_NV21),\n+\t\t.bitsPerPixel = 12,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n+\t\t.packed = false,\n+\t} },\n \t{ formats::NV16, {\n \t\t.name = \"NV16\",\n \t\t.format = formats::NV16,\n@@ -272,19 +288,19 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n \t\t.packed = false,\n \t} },\n-\t{ formats::NV12, {\n-\t\t.name = \"NV12\",\n-\t\t.format = formats::NV12,\n-\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_NV12),\n-\t\t.bitsPerPixel = 12,\n+\t{ formats::NV24, {\n+\t\t.name = \"NV24\",\n+\t\t.format = formats::NV24,\n+\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_NV24),\n+\t\t.bitsPerPixel = 24,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n \t\t.packed = false,\n \t} },\n-\t{ formats::NV21, {\n-\t\t.name = \"NV21\",\n-\t\t.format = formats::NV21,\n-\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_NV21),\n-\t\t.bitsPerPixel = 12,\n+\t{ formats::NV42, {\n+\t\t.name = \"NV42\",\n+\t\t.format = formats::NV42,\n+\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_NV42),\n+\t\t.bitsPerPixel = 24,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n \t\t.packed = false,\n \t} },\n", "prefixes": [ "libcamera-devel", "v4", "01/21" ] }