Patch Detail
Show a patch.
GET /api/patches/8659/?format=api
{ "id": 8659, "url": "https://patchwork.libcamera.org/api/patches/8659/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8659/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200706153808.2340919-9-kieran.bingham@ideasonboard.com>", "date": "2020-07-06T15:38:08", "name": "[libcamera-devel,v4,8/8] android: camera_device: Remove single buffer restriction.", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ddb42c8e33ce431d10619f4e3887fd27f8c3a64b", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8659/mbox/", "series": [ { "id": 1088, "url": "https://patchwork.libcamera.org/api/series/1088/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1088", "date": "2020-07-06T15:38:00", "name": "android: Multi-stream support", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1088/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8659/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8659/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9FAE2BD790\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 6 Jul 2020 15:38:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 62C5D60E37;\n\tMon, 6 Jul 2020 17:38:20 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E835C60E43\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 6 Jul 2020 17:38:15 +0200 (CEST)", "from Q.local (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net\n\t[86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6C4ECA16;\n\tMon, 6 Jul 2020 17:38:15 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DDJZ6eES\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594049895;\n\tbh=PBdLF9d9XJ9Ifeo73geGqBk2Gs4+P2YX4dlHv7Td2us=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=DDJZ6eESK29m+BNkli9Kp7H3iKSnB148tv8xg4Bk8NJEbYNO6v8IpD558WQWDYyAU\n\tuJuZDkCLExjayw9G6Qz9ah6Mz+Iu5RkKQLjuMD30TrKjjfTDRjp5mn08NNgRhfBoBh\n\tRFDdWv0SI6yDtuil1YwKI+c+mEc60SQapasdz8BM=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Mon, 6 Jul 2020 16:38:08 +0100", "Message-Id": "<20200706153808.2340919-9-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200706153808.2340919-1-kieran.bingham@ideasonboard.com>", "References": "<20200706153808.2340919-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 8/8] android: camera_device: Remove\n\tsingle buffer restriction.", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "A capture request is no longer limited to a single output buffer.\nRemove the limitation, but (for now) keep the check to ensure that\nat least one buffer is always provided.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_device.cpp | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex f368726091f4..e7ed873d64c0 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1050,9 +1050,8 @@ FrameBuffer *CameraDevice::createFrameBuffer(const buffer_handle_t camera3buffer\n \n int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Request)\n {\n-\tif (camera3Request->num_output_buffers != 1) {\n-\t\tLOG(HAL, Error) << \"Invalid number of output buffers: \"\n-\t\t\t\t<< camera3Request->num_output_buffers;\n+\tif (!camera3Request->num_output_buffers) {\n+\t\tLOG(HAL, Error) << \"No output buffers provided\";\n \t\treturn -EINVAL;\n \t}\n \n", "prefixes": [ "libcamera-devel", "v4", "8/8" ] }