Patch Detail
Show a patch.
GET /api/patches/8646/?format=api
{ "id": 8646, "url": "https://patchwork.libcamera.org/api/patches/8646/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8646/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200706085625.1625432-3-naush@raspberrypi.com>", "date": "2020-07-06T08:56:24", "name": "[libcamera-devel,v2,2/3] libcamera: ipa: raspberrypi: Populate libcamera metadata after controller process", "commit_ref": "64652e26d7dbae24ab90a1a4bed19b733985fcf7", "pull_url": null, "state": "accepted", "archived": false, "hash": "c3e17b5711f2f33c0cc6b4edc6b666430eb2c10d", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8646/mbox/", "series": [ { "id": 1084, "url": "https://patchwork.libcamera.org/api/series/1084/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1084", "date": "2020-07-06T08:56:22", "name": "Focus feedback control", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1084/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8646/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8646/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5B1E8BD794\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 6 Jul 2020 08:56:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CC18260E14;\n\tMon, 6 Jul 2020 10:56:39 +0200 (CEST)", "from mail-wm1-x342.google.com (mail-wm1-x342.google.com\n\t[IPv6:2a00:1450:4864:20::342])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E076860E01\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 6 Jul 2020 10:56:38 +0200 (CEST)", "by mail-wm1-x342.google.com with SMTP id g10so15202787wmc.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 06 Jul 2020 01:56:38 -0700 (PDT)", "from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tk185sm22600282wmk.47.2020.07.06.01.56.37\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 06 Jul 2020 01:56:37 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"EHRyymkp\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=2SGLNdyFdsUGjI3R6sQATmjr6zk1FJpyPnlDLESP9oY=;\n\tb=EHRyymkpY8P7vQPkO4qUNwUsop6F9Myo9Qx5lmuPzwezOLqw+3v9F8FnvE9Gj70qh2\n\tXUSNOh5FCXB70oZDMShMzwLd5P5KUTf5WhMOsRoFBTVbR/+7gPuexhhwLYukJ2ux3dSJ\n\t/ujWwhSppTbdZU0XW5DzpmSisxXgneMKuUX8Xxw+IipfYFH6iMwUHGcEcSlVgFZ79PuK\n\ta0HeUKaAZ/npL2HUDPqkK26F0xDeSwXmLrvtwGlYazVRCJBQoma9T4Anq33lvR4MTcgT\n\tGCKMi/LkRzhivXJ1sGqWpGLM8Wz+xPeiL27aU4iToa+6EavPfkWH0NrlC7aXVBmJcW3u\n\tOufA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=2SGLNdyFdsUGjI3R6sQATmjr6zk1FJpyPnlDLESP9oY=;\n\tb=iMiCOVI1+ZK7et6uWpKmVNabtduMDnhybjJqXeiFF4YB/j0iN5FhnRzYEsnvFQRJ1F\n\tI0ZsENdhxCgXy0lJL6Fv5mgGfguEs/9q7/8e9+LYoiDyjY5eBsxrlvtmFzNX6xvfeLpB\n\tkE5uQD/MfltUJmByiq/Rbv8eJEnFXC06bl6yg5dmm2eirEOytxear8SetNDQAXbXMsej\n\theQKNgA+D7XHwDVg3AUagG9figUQsFnbJHSXLjJFbZr5VkXGHzK/qfB/IXR2r/7SH5s2\n\t8Gs8noWUD/H6BGJ0KSaK1SqxEEfxNUyY+ohWlFYeZqudGLiF8cNfmT3hwRNgqm6q6AOR\n\tf8Tg==", "X-Gm-Message-State": "AOAM532p/eGjToK3ViCrR2m3kMvHMv+gxDMFNjORUkDLA6CAaiwNYq3O\n\tYttHUEZnbH1vtxCDq5Dc+KALG1s6/5k=", "X-Google-Smtp-Source": "ABdhPJy8aI0Jyv49cstyUm5W35HzLVmXQGxWY4uGd9w9S+7l19kbEwOlLmCyhyDMPUd0hk3o4YO+KA==", "X-Received": "by 2002:a1c:a4c6:: with SMTP id\n\tn189mr47012939wme.173.1594025798350; \n\tMon, 06 Jul 2020 01:56:38 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 6 Jul 2020 09:56:24 +0100", "Message-Id": "<20200706085625.1625432-3-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200706085625.1625432-1-naush@raspberrypi.com>", "References": "<20200706085625.1625432-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 2/3] libcamera: ipa: raspberrypi:\n\tPopulate libcamera metadata after controller process", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "For control algorithms like focus, this is needed to return out the\nthe current frame focus statistics. For other algorithms, there is no\nfunctional change.\n\nSigned-off-By: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/raspberrypi/raspberrypi.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex bc89ab58..62730198 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -318,6 +318,8 @@ void IPARPi::processEvent(const IPAOperationData &event)\n \t\tif (frame_count_ > mistrust_count_)\n \t\t\tprocessStats(bufferId);\n \n+\t\treportMetadata();\n+\n \t\tIPAOperationData op;\n \t\top.operation = RPI_IPA_ACTION_STATS_METADATA_COMPLETE;\n \t\top.data = { bufferId & RPiIpaMask::ID };\n@@ -336,7 +338,6 @@ void IPARPi::processEvent(const IPAOperationData &event)\n \t\t * they are \"unreliable\".\n \t\t */\n \t\tprepareISP(embeddedbufferId);\n-\t\treportMetadata();\n \n \t\t/* Ready to push the input buffer into the ISP. */\n \t\tIPAOperationData op;\n", "prefixes": [ "libcamera-devel", "v2", "2/3" ] }