Patch Detail
Show a patch.
GET /api/patches/8642/?format=api
{ "id": 8642, "url": "https://patchwork.libcamera.org/api/patches/8642/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8642/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200704133140.1738660-22-paul.elder@ideasonboard.com>", "date": "2020-07-04T13:31:39", "name": "[libcamera-devel,v3,21/22] libcamera: vimc: Fill stride and frameSize at config validation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "249073ef869529bef4ca1df24b70ec26cd8aadfe", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8642/mbox/", "series": [ { "id": 1083, "url": "https://patchwork.libcamera.org/api/series/1083/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1083", "date": "2020-07-04T13:31:18", "name": "Clean up formats in v4l2-compat and pipeline handlers", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1083/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8642/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8642/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CE802BD792\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 4 Jul 2020 13:32:37 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 984AE60E50;\n\tSat, 4 Jul 2020 15:32:37 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4178060E50\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 4 Jul 2020 15:32:36 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CA738296;\n\tSat, 4 Jul 2020 15:32:34 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hNyX+0Bf\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593869556;\n\tbh=sL5Ok/ETfy4ghPm4q8RWjKSIazeBSdb/sZg3P16wiFM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=hNyX+0BfPsNPKTsI51WAWEoJe770F9bAtWuBUe29cqgHdsz9O05UiAwzUlXExsJnd\n\tnMQrmOnL43uLV7ngMeIcnusFOSVJ1XKJUP+Ym4l4JRGoM+1aMrnbMIB9WNM+Y0DLPk\n\tulN+muApLbEcyOuQBUtXZikYGbQGhzNT9z1jnYPk=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 4 Jul 2020 22:31:39 +0900", "Message-Id": "<20200704133140.1738660-22-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200704133140.1738660-1-paul.elder@ideasonboard.com>", "References": "<20200704133140.1738660-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 21/22] libcamera: vimc: Fill stride and\n\tframeSize at config validation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Fill the stride and frameSize fields of the StreamConfiguration at\nconfiguration validation time instead of at camera configuration time.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nNew in v3\n---\n src/libcamera/pipeline/vimc/vimc.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\nindex b653066..e55a861 100644\n--- a/src/libcamera/pipeline/vimc/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc/vimc.cpp\n@@ -160,6 +160,10 @@ CameraConfiguration::Status VimcCameraConfiguration::validate()\n \n \tcfg.bufferCount = 4;\n \n+\tconst PixelFormatInfo &info = PixelFormatInfo::info(cfg.pixelFormat);\n+\tcfg.stride = info.stride(cfg.size.width, 0);\n+\tcfg.frameSize = info.frameSize(cfg.size);\n+\n \treturn status;\n }\n \n@@ -282,7 +286,6 @@ int PipelineHandlerVimc::configure(Camera *camera, CameraConfiguration *config)\n \t\treturn ret;\n \n \tcfg.setStream(&data->stream_);\n-\tcfg.stride = format.planes[0].bpl;\n \n \treturn 0;\n }\n", "prefixes": [ "libcamera-devel", "v3", "21/22" ] }