Patch Detail
Show a patch.
GET /api/patches/8636/?format=api
{ "id": 8636, "url": "https://patchwork.libcamera.org/api/patches/8636/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8636/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200704133140.1738660-16-paul.elder@ideasonboard.com>", "date": "2020-07-04T13:31:33", "name": "[libcamera-devel,v3,15/22] libcamera: pipeline: uvcvideo: Filter out unsupported formats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "510be52871de400b5a9477dd04e927a6ec25184f", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8636/mbox/", "series": [ { "id": 1083, "url": "https://patchwork.libcamera.org/api/series/1083/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1083", "date": "2020-07-04T13:31:18", "name": "Clean up formats in v4l2-compat and pipeline handlers", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1083/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8636/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8636/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 94051BD792\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 4 Jul 2020 13:32:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 60EED609C7;\n\tSat, 4 Jul 2020 15:32:25 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AE994609C7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 4 Jul 2020 15:32:24 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3EEEF55B;\n\tSat, 4 Jul 2020 15:32:22 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OIaOiwjt\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593869544;\n\tbh=304qWkFJhzz5hiUw0JsTJA1QPxTaFJLvsa9Is2QFqUw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=OIaOiwjtPYfxj/7wuYNLYQVmdsEGy/UeFgGqoCe/MffBNhs+UiUiMJ9WlHUTWXf75\n\tZgQlOM6RQOwnb/U1HYFIYObt+9B2lIP+C6ooKv6CMKXlYq02ZZfGTI5pcuw92opvQP\n\tgNo2Lb2TKqoPTXh+yND/xn+U2gy/xRv8eU0F3i84=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 4 Jul 2020 22:31:33 +0900", "Message-Id": "<20200704133140.1738660-16-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200704133140.1738660-1-paul.elder@ideasonboard.com>", "References": "<20200704133140.1738660-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 15/22] libcamera: pipeline: uvcvideo:\n\tFilter out unsupported formats", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Unsupported formats should not be added to the configuration when\ngenerating the configuration. Filter them out.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nNo change in v3\n---\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 13 +++++--------\n 1 file changed, 5 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nindex 80a0e77..a5feab6 100644\n--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n@@ -161,14 +161,11 @@ CameraConfiguration *PipelineHandlerUVC::generateConfiguration(Camera *camera,\n \tstd::map<V4L2PixelFormat, std::vector<SizeRange>> v4l2Formats =\n \t\tdata->video_->formats();\n \tstd::map<PixelFormat, std::vector<SizeRange>> deviceFormats;\n-\tstd::transform(v4l2Formats.begin(), v4l2Formats.end(),\n-\t\t std::inserter(deviceFormats, deviceFormats.begin()),\n-\t\t [&](const decltype(v4l2Formats)::value_type &format) {\n-\t\t\t return decltype(deviceFormats)::value_type{\n-\t\t\t\t format.first.toPixelFormat(),\n-\t\t\t\t format.second\n-\t\t\t };\n-\t\t });\n+\tfor (auto format : v4l2Formats) {\n+\t\tPixelFormat pixelFormat = format.first.toPixelFormat();\n+\t\tif (pixelFormat.isValid())\n+\t\t\tdeviceFormats[pixelFormat] = format.second;\n+\t}\n \n \tStreamFormats formats(deviceFormats);\n \tStreamConfiguration cfg(formats);\n", "prefixes": [ "libcamera-devel", "v3", "15/22" ] }