Patch Detail
Show a patch.
GET /api/patches/8624/?format=api
{ "id": 8624, "url": "https://patchwork.libcamera.org/api/patches/8624/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8624/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200704133140.1738660-4-paul.elder@ideasonboard.com>", "date": "2020-07-04T13:31:21", "name": "[libcamera-devel,v3,03/22] libcamera: StreamConfiguration: Add frameSize field", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "387ebe7b9cda8d0a26c3cc5e6f86dae4e8be4e7a", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8624/mbox/", "series": [ { "id": 1083, "url": "https://patchwork.libcamera.org/api/series/1083/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1083", "date": "2020-07-04T13:31:18", "name": "Clean up formats in v4l2-compat and pipeline handlers", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1083/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8624/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8624/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4D1A5BD792\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 4 Jul 2020 13:32:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 18A0260E30;\n\tSat, 4 Jul 2020 15:32:02 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B69F60C50\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 4 Jul 2020 15:32:01 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 93439296;\n\tSat, 4 Jul 2020 15:31:59 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OpC4FeWc\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593869520;\n\tbh=KeI1eX8ffrVBk9a2my1Z7cKMDWikUEP48MeZZsKnNjg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=OpC4FeWcoop26LAsYOSelg8EjDBucyXzfDNmV6VaGIkYFOpYmcHw8oQkLJnwe2zbr\n\tT1bIlnzwWSu2B0WhZKr0TJ5dXkg0h2WDJ5v+GFEZSaP5wbgDEmxz6DRPWtUyEHkIN7\n\tUwupNt6rw5JutupltkRS9enRfCJTXmojFILLT71o=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 4 Jul 2020 22:31:21 +0900", "Message-Id": "<20200704133140.1738660-4-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200704133140.1738660-1-paul.elder@ideasonboard.com>", "References": "<20200704133140.1738660-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 03/22] libcamera: StreamConfiguration:\n\tAdd frameSize field", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In addition to the stride field, we want the pipeline handler to be able\nto declare the frame size for the configuration. Add a frameSize field\nto StreamConfiguration for this purpose.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nNew in v3\n---\n include/libcamera/stream.h | 1 +\n src/libcamera/stream.cpp | 17 ++++++++++++++---\n 2 files changed, 15 insertions(+), 3 deletions(-)", "diff": "diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\nindex 1a68bd2..f502b35 100644\n--- a/include/libcamera/stream.h\n+++ b/include/libcamera/stream.h\n@@ -43,6 +43,7 @@ struct StreamConfiguration {\n \tPixelFormat pixelFormat;\n \tSize size;\n \tunsigned int stride;\n+\tunsigned int frameSize;\n \n \tunsigned int bufferCount;\n \ndiff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\nindex 6df5882..6d6e279 100644\n--- a/src/libcamera/stream.cpp\n+++ b/src/libcamera/stream.cpp\n@@ -279,7 +279,8 @@ SizeRange StreamFormats::range(const PixelFormat &pixelformat) const\n * handlers provide StreamFormats.\n */\n StreamConfiguration::StreamConfiguration()\n-\t: pixelFormat(0), stride(0), bufferCount(0), stream_(nullptr)\n+\t: pixelFormat(0), stride(0), frameSize(0), bufferCount(0),\n+\t stream_(nullptr)\n {\n }\n \n@@ -287,8 +288,8 @@ StreamConfiguration::StreamConfiguration()\n * \\brief Construct a configuration with stream formats\n */\n StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n-\t: pixelFormat(0), stride(0), bufferCount(0), stream_(nullptr),\n-\t formats_(formats)\n+\t: pixelFormat(0), stride(0), frameSize(0), bufferCount(0),\n+\t stream_(nullptr), formats_(formats)\n {\n }\n \n@@ -315,6 +316,16 @@ StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n * the camera is configured.\n */\n \n+/**\n+ * \\var StreamConfiguration::frameSize\n+ * \\brief Frame size for the stream, in bytes\n+ *\n+ * The frameSize value reports the number of bytes necessary to contain one\n+ * frame of an image buffer for this stream. The value is valid after\n+ * successfully validating the configuration with a call to\n+ * CameraConfiguration::validate().\n+ */\n+\n /**\n * \\var StreamConfiguration::bufferCount\n * \\brief Requested number of buffers to allocate for the stream\n", "prefixes": [ "libcamera-devel", "v3", "03/22" ] }