Patch Detail
Show a patch.
GET /api/patches/8605/?format=api
{ "id": 8605, "url": "https://patchwork.libcamera.org/api/patches/8605/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8605/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200704005227.21782-2-laurent.pinchart@ideasonboard.com>", "date": "2020-07-04T00:52:16", "name": "[libcamera-devel,v2,01/12] libcamera: ipa: Document the parameters of the IPA C configure function", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "be3e808660b2731ffdf08c9ada80a01804dfafc0", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8605/mbox/", "series": [ { "id": 1081, "url": "https://patchwork.libcamera.org/api/series/1081/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1081", "date": "2020-07-04T00:52:15", "name": "Support passing custom data to IPA configure()", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1081/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8605/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8605/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 69CCDBE905\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 4 Jul 2020 00:52:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 80BE860D5E;\n\tSat, 4 Jul 2020 02:52:38 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E95E2603BB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 4 Jul 2020 02:52:36 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 76CD651B;\n\tSat, 4 Jul 2020 02:52:36 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vFbl1E80\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593823956;\n\tbh=2Sh7+X5LCJDZltS7YrZ3EDHVkTSTl+Mg+eJQ2BRTK7Y=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=vFbl1E80hojsdBs9TfgZ6db21D16u0DJTEf4nR3ZxqqfaRATcKxGfLny5vl8+23+4\n\tanGdnTF8hOtl4lL4v16Lv8iTJqJ/+m/d3SX7pkKP8rIIUyljsQR3uk/pec7i5DXp0y\n\tqIQOhIGpOIfiJ5H7/gLt0quf7iKEkBqvasT6fJ0Q=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 4 Jul 2020 03:52:16 +0300", "Message-Id": "<20200704005227.21782-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200704005227.21782-1-laurent.pinchart@ideasonboard.com>", "References": "<20200704005227.21782-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 01/12] libcamera: ipa: Document the\n\tparameters of the IPA C configure function", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The parameters to the configure() function part of the ipa_context_ops\nare not documented. Fix that.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/ipa_interface.cpp | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/src/libcamera/ipa_interface.cpp b/src/libcamera/ipa_interface.cpp\nindex 69835e63ab46..ebe47e1233a5 100644\n--- a/src/libcamera/ipa_interface.cpp\n+++ b/src/libcamera/ipa_interface.cpp\n@@ -340,6 +340,11 @@\n * \\var ipa_context_ops::configure\n * \\brief Configure the IPA stream and sensor settings\n * \\param[in] ctx The IPA context\n+ * \\param[in] sensor_info Camera sensor information\n+ * \\param[in] streams Configuration of all active streams\n+ * \\param[in] num_streams The number of entries in the \\a streams array\n+ * \\param[in] maps Controls provided by the pipeline entities\n+ * \\param[in] num_maps The number of entries in the \\a maps array\n *\n * \\sa libcamera::IPAInterface::configure()\n */\n", "prefixes": [ "libcamera-devel", "v2", "01/12" ] }