Patch Detail
Show a patch.
GET /api/patches/8595/?format=api
{ "id": 8595, "url": "https://patchwork.libcamera.org/api/patches/8595/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8595/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200704004028.21153-5-laurent.pinchart@ideasonboard.com>", "date": "2020-07-04T00:40:20", "name": "[libcamera-devel,04/12] media: v4l2-ctrl: Document V4L2_CID_CAMERA_SENSOR_ROTATION", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8d95ddbaa0b3bbd44009d0d78be23cee295c11bc", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8595/mbox/", "series": [ { "id": 1080, "url": "https://patchwork.libcamera.org/api/series/1080/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1080", "date": "2020-07-04T00:40:16", "name": "raspberrypi: Report sensor orientation through DT", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1080/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8595/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8595/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D768DBFFE2\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 4 Jul 2020 00:40:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A699360DE4;\n\tSat, 4 Jul 2020 02:40:41 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3CAFF609C5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 4 Jul 2020 02:40:38 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B30D151B;\n\tSat, 4 Jul 2020 02:40:37 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bHvpWRG1\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593823238;\n\tbh=M/out22oWg1wHIUZ0ECgB5WH6Q2MRgXlq6VYd2wJeZY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=bHvpWRG16DkBox6hoGj9GC5odVH2LHP9Uu2DpoZqM54gV1Amli5W4tmYNycjYxcsa\n\tvngU7pdO9wTK4gkSuhe/4WbcBKqzGSjEVfVB4HdMzgV7osnEdYZBGDObPf5PZZ24q5\n\tgQSJf1D8uSOwsA5HMx7CNInDn3SrA0mvECdCLtEo=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "Dave Stevenson <dave.stevenson@raspberrypi.com>", "Date": "Sat, 4 Jul 2020 03:40:20 +0300", "Message-Id": "<20200704004028.21153-5-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200704004028.21153-1-laurent.pinchart@ideasonboard.com>", "References": "<20200704004028.21153-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 04/12] media: v4l2-ctrl: Document\n\tV4L2_CID_CAMERA_SENSOR_ROTATION", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "libcamera-devel@lists.libcamera.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Jacopo Mondi <jacopo@jmondi.org>\n\nAdd documentation for the V4L2_CID_CAMERA_SENSOR_ROTATION camera\ncontrol. The newly added read-only control reports the rotation\ncorrection to be applied to images before displaying them to the user.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\nSigned-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>\nSigned-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>\n---\n .../media/uapi/v4l/ext-ctrls-camera.rst | 121 ++++++++++++++++++\n 1 file changed, 121 insertions(+)", "diff": "diff --git a/Documentation/media/uapi/v4l/ext-ctrls-camera.rst b/Documentation/media/uapi/v4l/ext-ctrls-camera.rst\nindex c65a2b66232e..e64c1b2c01e8 100644\n--- a/Documentation/media/uapi/v4l/ext-ctrls-camera.rst\n+++ b/Documentation/media/uapi/v4l/ext-ctrls-camera.rst\n@@ -540,6 +540,127 @@ enum v4l2_scene_mode -\n \n \n \n+``V4L2_CID_CAMERA_SENSOR_ROTATION (integer)``\n+ This read-only control describes the rotation correction in degrees in the\n+ counter-clockwise direction to be applied to the captured images once\n+ captured to memory to compensate for the camera sensor mounting rotation.\n+\n+ For a precise definition of the sensor mounting rotation refer to the\n+ extensive description of the 'rotation' properties in the device tree\n+ bindings file 'video-interfaces.txt'.\n+\n+ A few examples are below reported, using a shark swimming from left to\n+ right in front of the user as the example scene to capture. ::\n+\n+ 0 X-axis\n+ 0 +------------------------------------->\n+ !\n+ !\n+ !\n+ ! |\\____)\\___\n+ ! ) _____ __`<\n+ ! |/ )/\n+ !\n+ !\n+ !\n+ V\n+ Y-axis\n+\n+ Example one - Webcam\n+\n+ Assuming you can bring your laptop with you while swimming with sharks,\n+ the camera module of the laptop is installed on the user facing part of a\n+ laptop screen casing, and is typically used for video calls. The captured\n+ images are meant to be displayed in landscape mode (width > height) on the\n+ laptop screen.\n+\n+ The camera is typically mounted upside-down to compensate the lens optical\n+ inversion effect. In this case the value of the\n+ V4L2_CID_CAMERA_SENSOR_ROTATION control is 0, no rotation is required to\n+ display images correctly to the user.\n+\n+ If the camera sensor is not mounted upside-down it is required to compensate\n+ the lens optical inversion effect and the value of the\n+ V4L2_CID_CAMERA_SENSOR_ROTATION control is 180 degrees, as images will\n+ result rotated when captured to memory. ::\n+\n+ +--------------------------------------+\n+ ! !\n+ ! !\n+ ! !\n+ ! __/(_____/| !\n+ ! >.___ ____ ( !\n+ ! \\( \\| !\n+ ! !\n+ ! !\n+ ! !\n+ +--------------------------------------+\n+\n+ A software rotation correction of 180 degrees has to be applied to correctly\n+ display the image on the user screen. ::\n+\n+ +--------------------------------------+\n+ ! !\n+ ! !\n+ ! !\n+ ! |\\____)\\___ !\n+ ! ) _____ __`< !\n+ ! |/ )/ !\n+ ! !\n+ ! !\n+ ! !\n+ +--------------------------------------+\n+\n+ Example two - Phone camera\n+\n+ It is more handy to go and swim with sharks with only your mobile phone\n+ with you and take pictures with the camera that is installed on the back\n+ side of the device, facing away from the user. The captured images are meant\n+ to be displayed in portrait mode (height > width) to match the device screen\n+ orientation and the device usage orientation used when taking the picture.\n+\n+ The camera sensor is typically mounted with its pixel array longer side\n+ aligned to the device longer side, upside-down mounted to compensate for\n+ the lens optical inversion effect.\n+\n+ The images once captured to memory will be rotated and the value of the\n+ V4L2_CID_CAMERA_SENSOR_ROTATION will report a 90 degree rotation. ::\n+\n+\n+ +-------------------------------------+\n+ | _ _ |\n+ | \\ / |\n+ | | | |\n+ | | | |\n+ | | > |\n+ | < | |\n+ | | | |\n+ | . |\n+ | V |\n+ +-------------------------------------+\n+\n+ A correction of 90 degrees in counter-clockwise direction has to be\n+ applied to correctly display the image in portrait mode on the device\n+ screen. ::\n+\n+ +--------------------+\n+ | |\n+ | |\n+ | |\n+ | |\n+ | |\n+ | |\n+ | |\\____)\\___ |\n+ | ) _____ __`< |\n+ | |/ )/ |\n+ | |\n+ | |\n+ | |\n+ | |\n+ | |\n+ +--------------------+\n+\n+\n .. [#f1]\n This control may be changed to a menu control in the future, if more\n options are required.\n", "prefixes": [ "libcamera-devel", "04/12" ] }